Commits · 286fb1607d361660ec836f43fdfb1eb27e67b594 · Linshizhi / Chromium_Depot_tools

30 Sep, 2019 1 commit

gclient: have git operations specify the git dir by default · 286fb160

Mike Frysinger authored Sep 30, 2019

If the .git/ subdir exists and mostly looks OK, but in reality git
doesn't accept it, gclient will blindly run git in the subdir and
think it's operating on the local .git/.  Kind of like:
  $ cd src/third_party/emoji-segmenter/src/
  $ rm -rf .git && mkdir .git
  # This works on the top level src/.git/.
  $ git <operation>

Instead of relying on this automatic git behavior, use GIT_DIR by
default so we force git to only look at that specific checkout.  If
it's broken, git will fail on us (good) instead of silently falling
back to the parent (bad).
  $ cd src/third_party/emoji-segmenter/src/
  $ rm -rf .git && mkdir .git
  $ GIT_DIR=$PWD/.git git <operation>
  <this now hard fails>

Bug: 1000825
Test: `gclient sync -j1` with a broken src/third_party/emoji-segmenter/src/.git/ caused the sync to halt
Change-Id: I777d67cd5daa354b32c424414d93a61b3b600f54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1785957
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

286fb160

29 Sep, 2019 1 commit

[git-cache] Add option to update_bootstrap to skip the populate step. · 0081c0ff

Robert Iannucci authored Sep 29, 2019

This will allow us to separate the 'populate' and 'upload' phases
in the git cache updater recipe, which will allow us to do all the
'populate' steps in parallel, but then limit the parallelism of the
`pack/gc/upload` operations.

R=tandrii@chromium.org

Change-Id: I8b8a9155f86350be37ed5a67c592ff1fec4d42ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1830857
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

0081c0ff

27 Sep, 2019 4 commits

Reland "gclient: Add a GCLIENT_PY3 env var to allow users to execute gclient using Python 3." · 39058571

Edward Lemur authored Sep 27, 2019

This is a reland of e656e988

Original change's description:
> gclient: Add a GCLIENT_PY3 env var to allow users to execute gclient using Python 3.
> 
> Bug: 1008202
> Change-Id: I23dd70b72089a09c2a7cdc74e2a63c135a924ebe
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1825996
> Reviewed-by: Anthony Polito <apolito@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>

Bug: 1008202
Change-Id: I5181a7f8efb39bdd6adc99db90663cf3cf3cd0bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1828334Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

39058571

Revert "Reland "depot_tools: Use vpython to execute fetch."" · 69d78115

Edward Lesmes authored Sep 27, 2019

This reverts commit b3778411.

Reason for revert: <INSERT REASONING HERE>
Skia still has problems

Original change's description:
> Reland "depot_tools: Use vpython to execute fetch."
> 
> This is a reland of 028367fe
> 
> Should work on Skia after https://skia-review.googlesource.com/c/skia/+/244116
> 
> Original change's description:
> > depot_tools: Use vpython to execute fetch.
> >
> > Bug: 1002153
> > Change-Id: I11286bebc23bedada239d6ddb8ebb86207a41485
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1815707
> > Reviewed-by: Anthony Polito <apolito@google.com>
> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> > Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
> 
> Bug: 1002153
> Change-Id: Ifdde3c4a817ab6ca222c82c5448d630e85bf2a4b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1827719
> Reviewed-by: Anthony Polito <apolito@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

TBR=ehmaldonado@chromium.org,jcgregorio@chromium.org,apolito@google.com

Change-Id: I1963c5bccf36692209dfe10aa30d77650e40c6f1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1002153
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1829971Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

69d78115

Reland "depot_tools: Use vpython to execute fetch." · b3778411

Edward Lemur authored Sep 27, 2019

This is a reland of 028367fe

Should work on Skia after https://skia-review.googlesource.com/c/skia/+/244116

Original change's description:
> depot_tools: Use vpython to execute fetch.
>
> Bug: 1002153
> Change-Id: I11286bebc23bedada239d6ddb8ebb86207a41485
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1815707
> Reviewed-by: Anthony Polito <apolito@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>

Bug: 1002153
Change-Id: Ifdde3c4a817ab6ca222c82c5448d630e85bf2a4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1827719Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

b3778411

Revert "gclient: Add a GCLIENT_PY3 env var to allow users to execute gclient using Python 3." · 2b829368

Edward Lesmes authored Sep 27, 2019

This reverts commit e656e988.

Reason for revert: Defaults to Python 3 unless GCLIENT_PY3 is 1...

Original change's description:
> gclient: Add a GCLIENT_PY3 env var to allow users to execute gclient using Python 3.
> 
> Bug: 1008202
> Change-Id: I23dd70b72089a09c2a7cdc74e2a63c135a924ebe
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1825996
> Reviewed-by: Anthony Polito <apolito@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>

TBR=ehmaldonado@chromium.org,apolito@google.com

Change-Id: I8c63d8c9e0be84b1286275142fab1885597b1551
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1008202
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1828330Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

2b829368

26 Sep, 2019 11 commits

gclient: Add a GCLIENT_PY3 env var to allow users to execute gclient using Python 3. · e656e988

Edward Lemur authored Sep 26, 2019

Bug: 1008202
Change-Id: I23dd70b72089a09c2a7cdc74e2a63c135a924ebe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1825996Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>

e656e988

Add VS 2019 support to package_from_installed.py. · e4174f48

Mirko Bonadei authored Sep 26, 2019

This CL also removes VS 2015 support.

Bug: 1006238
Change-Id: Ib05b3d211341fcd5805c3acca3bc4c0aa894831d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1823961Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>

e4174f48

Roll recipe dependencies (trivial). · e37b1ec5

recipe-roller authored Sep 26, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/210148729e3ecd749cdfc83a1a4e874c04b84f84 delete unused argument (garymm@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic61ec4725e5a3ef46bbe411323eefd1fb7a8a411
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1827720Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

e37b1ec5

depot_tools: Enable more tests for windows. · bbd70fd7

Edward Lemur authored Sep 26, 2019

Bug: 1007580
Change-Id: Ic407566149f78a8de5f173ae4c8726fc25834b8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1750146
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

bbd70fd7

Add `git cl try --retry-failed` · 983111f0

Quinten Yearsley authored Sep 26, 2019

Bug: 985887
Change-Id: I5aab64a21961ea8f57d77f6523f2ddc5f74e78a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1818624
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

983111f0

Roll recipe dependencies (trivial). · 1ab7b681

recipe-roller authored Sep 26, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/d0b2d249e189cfec7a051393a095031d6427f193 Refactoring Context API (liviurau@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifa49f1a9b7daacbd2488c953fd182bc03cc538a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1827477Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

1ab7b681

Roll recipe dependencies (trivial). · f45fc45e

recipe-roller authored Sep 26, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/1e7de3da0e9935baa8bd6ff46e410846728643a0 [luciexe] Use proper base log name for url. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2282b466dd2cb99400b647b7f42fcf1d7d476c61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1827079Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

f45fc45e

Roll recipe dependencies (trivial). · 43d1c05f

recipe-roller authored Sep 26, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/bdb99d9b9906a2abfdf8965e4889a63462fd049e Expose ability to explicitly close currently open step to userspace. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5af3225bbc5fd6359a302c5d3dd8c8968b3290b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1827077Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

43d1c05f

Roll recipe dependencies (trivial). · 07cec8f6

recipe-roller authored Sep 26, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/bb7ba6bbd413d490ff7a74bcf1bbfcfa7247ae5c [luciexe] Protocol updates/fixes. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4ac2e2d6fac5cc53760a19154bdbfbf48acfa087
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1825911Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

07cec8f6

Roll recipe dependencies (trivial). · 731ce5cd

recipe-roller authored Sep 26, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/53f8e3450bf14f7bad9c585a4b9d6cf49768e72f [protos] Generalize update script and update protos. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia6d0ecf1fcbc643d48cd7ef375e2addfdf6d8ad5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1825910Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

731ce5cd

git-cl: Make Ctrl+C work again. · 9a5bb612

Edward Lemur authored Sep 26, 2019

Bug: 961724
Change-Id: I4fc8f86c02fb53310c5967284594ba1fbbbcbafc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1826054
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

9a5bb612

25 Sep, 2019 4 commits

git-cl: Set legacy properties. · f0faf48d

Edward Lemur authored Sep 25, 2019

Will be removed back again on Oct 9, 2019.

Bug: 1004447
Change-Id: I7003fac9ae8b184e2a7073b516535e8fd599f4f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1825446
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

f0faf48d

Fix sys.platform mapping in download_from_google_storage.py. · 69b63c9f

Victor Costan authored Sep 25, 2019

Relevant documentation: https://docs.python.org/3/library/sys.html#sys.platform

Bug: 1007872
Change-Id: Id4bb6e1da1d3244fcd245569fd74fd204ce1e9ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1824843
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Victor Costan <pwnall@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

69b63c9f

Roll recipe dependencies (trivial). · 6a5cb251

recipe-roller authored Sep 25, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/92e5e4828b44e502f549181cfc9aeebbbaf0ba7a cipd: link directly to created package on chrome-infra-packages. (jbudorick@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I23c457fa5248378b2fc9894fd3e46cf2a692d925
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1825693Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

6a5cb251

Import gclient_utils for gclient_paths CheckCallAndFilter · 7211cf64

Robert Liao authored Sep 25, 2019

CheckCallAndFilter isn't part of the global namespace, and as a result,
this call was silently failing.

BUG=1007553

Change-Id: Ie2f3135fc3d56be189d8be0fe996a068e0645705
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1823664
Auto-Submit: Robert Liao <robliao@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>

7211cf64

24 Sep, 2019 4 commits

Revert "depot_tools: Use vpython to execute fetch." · d48cbf93

Edward Lesmes authored Sep 24, 2019

This reverts commit 028367fe.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> depot_tools: Use vpython to execute fetch.
> 
> Bug: 1002153
> Change-Id: I11286bebc23bedada239d6ddb8ebb86207a41485
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1815707
> Reviewed-by: Anthony Polito <apolito@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>

TBR=tandrii@google.com,ehmaldonado@chromium.org,apolito@google.com

Change-Id: I0924e77a3862b8a75195db7fe719286e1cb3ac7e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1002153
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1824217Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

d48cbf93

depot_tools: Use vpython to execute fetch. · 028367fe

Edward Lemur authored Sep 24, 2019

Bug: 1002153
Change-Id: I11286bebc23bedada239d6ddb8ebb86207a41485
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1815707Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>

028367fe

git-cl: Re-write some tests to use mock. · 4c707a2c

Edward Lemur authored Sep 24, 2019

I think this makes tests easier to read and write.

Change-Id: I9430a5d40e3466ff2a24b6b40253419aea3f30b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1820034Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

4c707a2c

[git-cl] allow setting the bug during force mode · 8b95534d

Anthony Polito authored Sep 24, 2019

Bug: 1001709
Change-Id: I53e7699cb38d810d0a8c88d40907bf249174ad8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1804603Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Anthony Polito <apolito@google.com>

8b95534d

23 Sep, 2019 8 commits

auth: Use luci-auth to get credentials. · ba5bc99b

Edward Lemur authored Sep 23, 2019

Bug: 1001756
Change-Id: Ieab5391662e92ec9e2715a81fce2cef41717c2e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1790607
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

ba5bc99b

Remove unused imports in depot_tools/*.py · 3841eaa1

Quinten Yearsley authored Sep 23, 2019

I know that sometimes imports can have side-effects,
so unused imports shouldn't always be removed, but these
ones look like they could be.

Change-Id: Iea9f82afa99b0ea35f29a28f20ce0493b579cfee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1819860Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>

3841eaa1

gclient: Execute python hooks using vpython. · 6f18e687

Edward Lemur authored Sep 23, 2019

Change-Id: I032c838c07ca8b715976bd9dc428c1bd6a77d80b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1793009Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

6f18e687

Revert "git-cache: don't limit pack files to 2GiB." · fdb59f0d

Andrii Shyshkalov authored Sep 23, 2019

This reverts commit 82ae4b4b.

Reason for revert: didn't help. Something else limits 'git gc' by 2GB.
However, even so, total amount of .pack files for chromium/src is <7.5GB.

Original change's description:
> git-cache: don't limit pack files to 2GiB.
>
> This is only relevant to 1 builder which updates git cache bundles.
> Since some time in 2018-2019, it started creating several 2GiB packs
> for chromium/src. I verified that the setting affecting it is
>   core.deltaBaseCacheLimit
>
> Log file of a build which I observed while ssd-ed into the machine (internal):
>   https://logs.chromium.org/logs/infra-internal/buildbucket/cr-buildbucket.appspot.com/8901682638839779824/+/steps/Updating_https:__chromium.googlesource.com_chromium_src/0/stdout
> Git version: version:2.21.0.chromium16
>
> R=ehmaldonado
>
> Change-Id: I52cadfb9f34faea09a57d53387cab7e0538362b9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1818076
> Auto-Submit: Andrii Shyshkalov <tandrii@google.com>
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

TBR=tandrii@google.com,ehmaldonado@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I24915555c703bc92fda921524820405de5d69f7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1817101Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

fdb59f0d

Add Dawn to projects for my_activity.py · 06e1869f

Ryan Harrison authored Sep 23, 2019

Change-Id: Id22cde5b5c113fb1145c30afb6671ac2ec32afb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1819547
Auto-Submit: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

06e1869f

Remove some unused private things in git_cl · 90a67e2f

Quinten Yearsley authored Sep 23, 2019

There are many functions in git_cl that appear unused, although
it's possible that some of them are used in other places, where
git_cl may be imported as a library.

This CL just removes some of the private ones, which at least
were not supposed to be used from other places.

Things removed here:

 - _get_commiter_timestamp
 - _git_amend_head
 - GitCookiesChecker._get_usernames_of_domain
 - constants MERGE_BRANCH, CHERRY_PICK_BRANCH;
   the comment says that these are supposed to
   be used in CMDland, but apparently they aren't.
   contextlib which is only used by this, is also
   removed
 - CodereviewSettingsFileMock in git_cl_test;
   it is not used anywhere in the test, and I
   assume that nobody's importing and using
   git_cl_test...

git_cl_test still passes, git cl seems to still work

Change-Id: Ib8eee0dfb181c8cda04c0894d2daea52b3ad42ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1818621Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>

90a67e2f

Roll recipe dependencies (trivial). · 314adcb8

recipe-roller authored Sep 23, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/494a88f6f8c345512a5dbb9136ca99ab10bc6dd5 Convert entire tricium Results message to JSON only once (garymm@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I23d06ccdd70f5e03f6e81574c05a06fb5d192d4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1819539Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

314adcb8

Roll recipe dependencies (trivial). · b5578f4f

recipe-roller authored Sep 23, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/e8d0b68df47a63f3a184f64c138404a139e046ed [swarming] expose current bot_id and task_id on api.swarming. (tandrii@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I02270fd71a462c1b3a342e851baef35af27ec655
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1818976Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

b5578f4f

22 Sep, 2019 2 commits

git-cache: fix bug in prior CL. · 7cb60e81

Andrii Shyshkalov authored Sep 22, 2019

cwd param isn't necessary, because actual cwd is already correct --
see 'git gc' invocation below.

R=ehmaldonado, iannucci

Change-Id: Ia885ad32b11b0de37d3b0e4e5359d2031b6852d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1818455
Auto-Submit: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

7cb60e81

git-cache: don't limit pack files to 2GiB. · 82ae4b4b

Andrii Shyshkalov authored Sep 22, 2019

This is only relevant to 1 builder which updates git cache bundles.
Since some time in 2018-2019, it started creating several 2GiB packs
for chromium/src. I verified that the setting affecting it is
core.deltaBaseCacheLimit

Log file of a build which I observed while ssd-ed into the machine (internal):
https://logs.chromium.org/logs/infra-internal/buildbucket/cr-buildbucket.appspot.com/8901682638839779824/+/steps/Updating_https:__chromium.googlesource.com_chromium_src/0/stdout
Git version: version:2.21.0.chromium16

R=ehmaldonado

Change-Id: I52cadfb9f34faea09a57d53387cab7e0538362b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1818076
Auto-Submit: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

82ae4b4b

21 Sep, 2019 3 commits

gclient_utils: Actually pass the include_zero parameter to Annotated constructor · 383f6cf0

Raul Tambre authored Sep 21, 2019

Change-Id: I3d1e155ed2b6c4b4d6549bfb609358538dcdcd0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1815868
Auto-Submit: Raul Tambre <raul@tambre.ee>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

383f6cf0

tests/gclient_scm_test.py: Fix invalid escape sequences in regex strings · a79f0e50

Raul Tambre authored Sep 21, 2019

Note that on line 504 I also fixed the test on windows by allowing \. Also properly escaped /.

Errors:
C:\Google\depot_tools\tests\gclient_scm_test.py:42: SyntaxWarning: invalid escape sequence \[
  TIMESTAMP_RE = re.compile('\[[0-9]{1,2}:[0-9]{2}:[0-9]{2}\] (.*)', re.DOTALL)
C:\Google\depot_tools\tests\gclient_scm_test.py:504: SyntaxWarning: invalid escape sequence \.
  "breaking lock.*\.git/index\.lock")

Bug: 958138
Change-Id: I19ef98538a1c172d7139ca2d7097a7fbc33ebe80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1815866
Commit-Queue: Raul Tambre <raul@tambre.ee>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Raul Tambre <raul@tambre.ee>

a79f0e50

git-cache: add --gc-aggressive support. · dcfe55f1

Andrii Shyshkalov authored Sep 21, 2019

This will be used on internal cache updater.

For instance, I've just compressed chromium/src resulting bootstrap
files from 20GiB to 7.5 GiB.

R=ehmaldonado

Change-Id: I15411700eb2ac3a26d1c658a12288cc49e48fd48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1802877Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>

dcfe55f1

20 Sep, 2019 2 commits

git-cl: Use buildbucket v2 to schedule try jobs. · d4d1ba49

Edward Lemur authored Sep 20, 2019

Change-Id: I3bad4314973cda7e285b5b9cb823f61cd7fb2dff
Bug: 976104
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1809516
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

d4d1ba49

Roll recipe dependencies (trivial). · 410cf3af

recipe-roller authored Sep 20, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/849795f393c621ebbe81a1be35cb45ec0ab3ede5 Spellcheck recipes-py docs (qyearsley@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I958bcf431ef1707357bf5d9c758fea0e48bce250
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1816909Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

410cf3af