Skip to content

C
Chromium_Depot_tools
Switch branch/tag
  1. 27 Jul, 2016 5 commits
  3. 26 Jul, 2016 3 commits
  5. 25 Jul, 2016 3 commits
  7. 23 Jul, 2016 2 commits
  9. 22 Jul, 2016 7 commits
  11. 21 Jul, 2016 4 commits
  13. 20 Jul, 2016 7 commits
  15. 19 Jul, 2016 3 commits
    • techtonik's avatar
      map-branches: Fix crash with --show-subject when branch name matches files · 2e24812d
      techtonik authored 
      Traceback (most recent call last):
  ...
  File "...\\git_map_branches.py", line 303, in main
    mapper.start()
  File "...\\git_map_branches.py", line 169, in start
    self.__append_branch(root)
  File "...\\git_map_branches.py", line 272, in __append_branch
    self.__append_branch(child, depth=depth + 1)
  File "...\\git_map_branches.py", line 267, in __append_branch
    line.append(run('log', '-n1', '--format=%s', branch))
  File "...\git_common.py", line 599, in run
    return run_with_stderr(*cmd, **kwargs)[0]
  File "...\git_common.py", line 668, in run_with_stderr
    raise subprocess2.CalledProcessError(retcode, cmd, os.getcwd(), ret, err)
subprocess2.CalledProcessError: Command '...\\git.bat -c color.ui=never log -n1 --format=%s readme' returned non-zero exit status 128 in ...
fatal: ambiguous argument 'readme': both revision and filename
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

BUG=

Review-Url: https://codereview.chromium.org/2153803002
      2e24812d
    • sdefresne's avatar
      Add new parameter --project_root to cpplint.py. · 263e9287
      sdefresne authored 
      Chrome on iOS downstream repository tracks Chromium via DEPS and wants
to use cpplint canned presubmit check but the cpplint.py errors due at
the include guard as it stops at the inner most git repository.

Add a new parameter --project_root to cpplint.py. If set, it overrides
the automatic detection of the project root that searches the root of
the version control repository.

The --root parameter cannot be used as it is used after the automatic
resolution is performed (and allow chopping the head of the relative
path while the need is to expend the path to include ios_internal/).

BUG=598090

Review-Url: https://codereview.chromium.org/2036773002
      263e9287
    • asanka's avatar
      [git-map-branches] Show CL status verbatim. · 97f3949a
      asanka authored 
      git-map-branches -v -v -v currently indicates the status of the CL using
a color. This change adds the status string alongside the CL to match
the output of 'git-cl status'.

  $ git map-branches -v -v -v

Before:
  A        354ccf6 [ ahead 1 ] https://codereview...
    B      e701150 [ ahead 1 ] https://codereview...
      C *  094cedd [ ahead 1 ] https://codereview...

After:
  A        354ccf6 [ ahead 1 ] https://codereview... (commit)
    B      e701150 [ ahead 1 ] https://codereview... (lgtm)
      C *  094cedd [ ahead 1 ] https://codereview... (waiting)

R=dpranke@chromium.org
BUG=none

Review-Url: https://codereview.chromium.org/2138703003
      97f3949a
  17. 18 Jul, 2016 1 commit
  19. 15 Jul, 2016 2 commits
  21. 14 Jul, 2016 3 commits
    • dtu's avatar
      Fix per-file owners check for deleted files. · 944b6053
      dtu authored 
      Previously if you deleted a file that you had per-file owners on, it would fail
the owners check. This fixes that.

Originally, owners.Database used glob to enumerate the directory and added all
the matching files in the directory to some dicts holding the owners
information. If a CL deleted a file, it'd no longer be on the filesystem, so it
wouldn't be in these dicts. There'd be no per-file owners information for it.

With this patch, the Database no longer enumerates individual files. It instead
keeps track of the glob patterns and checks the CL's files against the patterns
at lookup time.

BUG=622381
TEST=tests/owners_unittest.py && tests/owners_finder_test.py  # Unit test included.

Review-Url: https://codereview.chromium.org/2148153002
      944b6053
    • mbjorge's avatar
      Fix relative file: paths in OWNERS with roots other than '/' · f2d73522
      mbjorge authored 
      If an OWNERS file used the file: directive with a relative file
path, but was using a root other than '/' (e.g.
'/path/to/my/real/root'), then the include resolver would incorrectly
leave a leading '/' on the include path. When os_path.join was then
called, the leading '/' meant the path was treated as an absolute path
and the join did not behave as expected.

Review-Url: https://codereview.chromium.org/2148683003
      f2d73522
    • hinoka's avatar
      Add cipd binary support to cit.py · 9a0de0b9
      hinoka authored 
      BUG=

Review-Url: https://codereview.chromium.org/2117943002
      9a0de0b9