add this to PRESUBMIT.py in the chromium tree later).
- Update cpplint.py to the latest version from the style guide.

Review URL: http://codereview.chromium.org/395022

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32180 0039d316-1c4b-4281-b951-d872f2087c98

Revert "Group SCM-specific functions in classes to simplify generalization of the interface."
Revert "Fix 2 recently introduced errors."
Revert "Fix a variable aliasing error."
Revert "Fix typo."

TBR=dpranke
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/391075

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32065 0039d316-1c4b-4281-b951-d872f2087c98

TEST=presubmit check
BUG=none

Review URL: http://codereview.chromium.org/400002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32062 0039d316-1c4b-4281-b951-d872f2087c98

TBR=mad
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/395018

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32059 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/391072

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32058 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Move scm functions into a class to make it simpler to manage.

Review URL: http://codereview.chromium.org/391052

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32057 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25824
TEST=gcl change in a read-only checkout is now a warning
instead of a hard error
Review URL: http://codereview.chromium.org/384128

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31942 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31916 0039d316-1c4b-4281-b951-d872f2087c98

ssh://test@example.com wasn't being parsed correctly for revinfo.

Fixed by factoring out all code which splits url into a base_url
and revision.

Review URL: http://codereview.chromium.org/391048

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31910 0039d316-1c4b-4281-b951-d872f2087c98

Reapplies r31809 is typo fixed.

TEST=unit tests fixed and reclassified
BUG=none

Review URL: http://codereview.chromium.org/393001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31812 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 7489404c56dcc725c7c13214f410b2d375a6630a.

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31810 0039d316-1c4b-4281-b951-d872f2087c98

TEST=unit tests fixed and reclassified
BUG=none

Review URL: http://codereview.chromium.org/389020

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31809 0039d316-1c4b-4281-b951-d872f2087c98

Removed lines in the process.

TEST=unit tests
BUG=none
Review URL: http://codereview.chromium.org/387033

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31759 0039d316-1c4b-4281-b951-d872f2087c98

TEST=unit tests
BUG=none

Review URL: http://codereview.chromium.org/392006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31754 0039d316-1c4b-4281-b951-d872f2087c98

TEST=unit tests
BUG=none

Review URL: http://codereview.chromium.org/387007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31593 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/387005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31592 0039d316-1c4b-4281-b951-d872f2087c98

TEST=unit tests
BUG=none

Review URL: http://codereview.chromium.org/385007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31590 0039d316-1c4b-4281-b951-d872f2087c98

Fix GetCachedFile() to skip local mods when use_root is True. The files
that exist in the root of the tree don't even seem to exist in the normal
source checkouts, and we were looking at a different file as a result.

  BUG=none
  R=maruel@chromium.org
  TEST=locally modify a PRESUBMIT.py file and look for duplicate results. 
    If you get duplicates, this didn't fix it

Review URL: http://codereview.chromium.org/379021

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31586 0039d316-1c4b-4281-b951-d872f2087c98

BUG=27241
TEST=running 'gcl change --force' in a read-only checkout creates random changename.

M      gcl.py

Review URL: http://codereview.chromium.org/387001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31552 0039d316-1c4b-4281-b951-d872f2087c98

BUG=27243
TEST=Create change which contains no files and confirm 'gcl diff createdchange' doesn't output anything.

M      gcl.py

Review URL: http://codereview.chromium.org/388001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31551 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31454 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25824
TEST=running 'gcl change foo' in a read-only checkout
shows an error, --force creates a CL anyway, and gcl
change in read-write checkouts continues to work.
Review URL: http://codereview.chromium.org/378027

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31452 0039d316-1c4b-4281-b951-d872f2087c98

ssh://test@example.org/test.git was not parsed correctly because we
would split at the '@' assuming what followed was a revision.

Review URL: http://codereview.chromium.org/372045

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31444 0039d316-1c4b-4281-b951-d872f2087c98

for the try servers and fallback on EMAIL_ADDRESS, since 
WebKit uses that. 

The reason is that some people have WebKit emails that 
predate Chromium emails so some separation is warranted 
so that people don't have to fix up emails all the time. 

BUG=None 
TEST=None 
Original review: http://codereview.chromium.org/372048


git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31437 0039d316-1c4b-4281-b951-d872f2087c98

Requirement for build system.

Review URL: http://codereview.chromium.org/372036

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31362 0039d316-1c4b-4281-b951-d872f2087c98

* Add revinfo as part of SCMWrapper interface.
* Implement revinfo for git and svn.
* Add unit tests.

Review URL: http://codereview.chromium.org/362008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31280 0039d316-1c4b-4281-b951-d872f2087c98

If you're not running gclient sync with --verbose and you get a conflict on
a file, the conflict message prints *before* the message that you're running
update in the appropriate directory. This is happening because we intercept
stdout but not stderr, and the conflict prompt goes to stderr. redirecting
stderr in the popen() to the pipe fixes this.

  R=maruel@chromium.org
  BUG=none
  TEST=none

Review URL: http://codereview.chromium.org/373003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31276 0039d316-1c4b-4281-b951-d872f2087c98

codereview.settings files.

  BUG=none
  TEST=none
  R=maruel@chromium.org

Review URL: http://codereview.chromium.org/354023

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@30910 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=drover can access SVN server from outside Google
Review URL: http://codereview.chromium.org/340079

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@30888 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST='gcl try' should succeed even if EMAIL_ADDRESS env variable is not set.

Review URL: http://codereview.chromium.org/351025

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@30870 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/341013

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@30865 0039d316-1c4b-4281-b951-d872f2087c98

Enforce --bot when --url is used.
Add a warning when --email is not defined.
Set a default --name on rietveld patches.
Set return value.

TEST=not much
BUG=when using --url and not --bot, an exception was thrown

Review URL: http://codereview.chromium.org/348044

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@30848 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/353001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@30752 0039d316-1c4b-4281-b951-d872f2087c98

modified codereview.settings or presubmit file.

  BUG=none
  R=maruel@chromium.org
  TEST=none

Review URL: http://codereview.chromium.org/340030

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@30503 0039d316-1c4b-4281-b951-d872f2087c98

I've added two settings to codereview.settings - LINT_REGEX and 
LINT_IGNORE_REGEX - to specify which files should be linted. The default
is to lint anything that ends in .cpp, .cc, .inl, or .h, and to ignore 
nothing.

I have also modified GetCachedFile() to look for a locally modified version 
of codereview.settings before looking in the repository.

  R=maruel@chromium.org
  TEST=none
  BUG=none

Review URL: http://codereview.chromium.org/257054

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@30415 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/339037

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@30317 0039d316-1c4b-4281-b951-d872f2087c98

output.

  R=maruel@chromium.org
  BUG=none
  TEST=none

Review URL: http://codereview.chromium.org/344007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@30307 0039d316-1c4b-4281-b951-d872f2087c98

print messages unless the underlying commands actually generate output.
This is a more conservative version of r28271.

  BUG=none
  TEST=none
  R=maruel

Review URL: http://codereview.chromium.org/344004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@30296 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/342008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@30285 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/330008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@29965 0039d316-1c4b-4281-b951-d872f2087c98