Commits · 260ab401aa0bce98a1c8a38d4f6dd4f79636c3a3 · Linshizhi / Chromium_Depot_tools

16 Nov, 2016 1 commit

Remote nested retries on checkout. · 260ab401

Dan Jacques authored Nov 16, 2016

Remove nested retries on checkout. Since the outer loop handles retries
specially, we want to let it exclusively handle retries. This will
prevent the inner retry loop triggering a timeout condition (rather than
a failure condition) with the outer loop.

BUG=chromium:665116
TEST=None

Change-Id: I4bf0c08b75861bf1c95060452118c314a121f9f3
Reviewed-on: https://chromium-review.googlesource.com/411397Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>

260ab401

15 Nov, 2016 4 commits

Remove safesync support from gclient[_scm].py · a98a6cd4
agable authored Nov 15, 2016
```
R=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2395013002
```
a98a6cd4

Strip netrc hack, rewrite file. · 8d11e482

Dan Jacques authored Nov 15, 2016

Strip the netrc hack; apparently it only works on some versions of
Python, and the bots have many different versions.

Instead, we will actually emit the modified netrc as a new file without
comments or newlines, then read that directly from the vanilla netrc
module.

BUG=chromium:664664
TEST=None

Change-Id: I245759e2eae4e6ddcdffa0aaef59866a62bd0240
Reviewed-on: https://chromium-review.googlesource.com/411416
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>

8d11e482

"netrc" hack to strip comments before processing. · 1d949fd3

Dan Jacques authored Nov 15, 2016

Processing comments seems to trigger a bug on (some?) Windows systems
due to a negative seek. This CL runs a comment-free version of the
"netrc" file through the parser.

BUG=chromium:664664
TEST=local
  - Uploaded this CL with the change.

Change-Id: I65f5d2f8c1162b3b3a13c66d8becb1cfccf27991
Reviewed-on: https://chromium-review.googlesource.com/411455Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

1d949fd3

Roll recipe dependencies (trivial). · 1a60c9c7

recipe-roller authored Nov 15, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/672570bf06c6b438b353a4c42d4d38ceab089eea path module: read tmp and cache dirs from properties (nodir@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2498273002

1a60c9c7

14 Nov, 2016 3 commits

gerrit_util: work with all paths. · 6d5bcc2b

Dan Jacques authored Nov 14, 2016

BUG=chromium:664664
TEST=local
  - Didn't work locally, now it does.

Change-Id: I5d470feda420342b0fb00a56e42a2b7d00257920
Reviewed-on: https://chromium-review.googlesource.com/411284Reviewed-by: Aaron Gable <agable@chromium.org>

6d5bcc2b

Fix authorization support · 43906384

smut authored Nov 12, 2016

The path always starts with a / so we need to check if it starts with /a/ to see if it's already authorized, not a/.

BUG=664664

Change-Id: I2bf6abe36dd88bc7d096e67d5e7a56fe9f143f47
Reviewed-on: https://chromium-review.googlesource.com/410721Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: First Last <smut@chromium.org>

43906384

Skip checking local vs remote patchset for Gerrit · fda50ca0

Ravi Mistry authored Nov 14, 2016

BUG=chromium:664520

Change-Id: Idd5855e14f6237577b351ff51582335996522417
Reviewed-on: https://chromium-review.googlesource.com/399118
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

fda50ca0

11 Nov, 2016 2 commits

Make depot_tools upload reviews to Gerrit by default · 9b654aa0

Aaron Gable authored Nov 11, 2016

BUG=634946

Change-Id: I1724395d6ba223854e513543841bdbb317f3ede7
Reviewed-on: https://chromium-review.googlesource.com/410227Reviewed-by: Andrew Bonventre <andybons@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

9b654aa0

Add retries to file operations for Windows. · 4625b5ad

dnj authored Nov 11, 2016

BUG=chromium:663990
TEST=None
R=hinoka@chromium.org, nodir@chromium.org

Review-Url: https://codereview.chromium.org/2497503002

4625b5ad

10 Nov, 2016 2 commits

bot_update: Use 'gclient' from same repository. · b445ef56

dnj authored Nov 10, 2016

Currently, 'bot_update' uses the 'gclient' that is on the system path.
Now, it will use the 'gclient.py' that is in the same 'depot_tools'
checkout as the 'bot_update' recipe module.

Also don't ignore "git_cache" move errors.

BUG=664254,663990,663440
TEST=None

Review-Url: https://codereview.chromium.org/2492963002

b445ef56

Don't --find-copies-harder when printing informational diff, either · b84b5e3a

scottmg authored Nov 10, 2016

We're doing the diff twice afaict, once to print stats to the user, and
once to actually do the upload. Definitely no need to
--find-copies-harder in the print.

Previously: https://codereview.chromium.org/2488823002.

R=dpranke@chromium.org
BUG=544889

Review-Url: https://codereview.chromium.org/2489963003

b84b5e3a

09 Nov, 2016 2 commits

presubmit_support for Gerrit: don't ignore 404. · c6c8b4c9

Andrii Shyshkalov authored Nov 09, 2016

Before, presubmit_support would fail with not very useful stacktrace if
Gerrit returns 404, which is usually due to missing/invalid credentials.

This CL fixes that and improves the exception message, and also improves
logic in git_cl.

R=agable@chromium.org
BUG=

Change-Id: Iae8f0c24422c46af70929c7d5d71993164887511
Reviewed-on: https://chromium-review.googlesource.com/409650
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

c6c8b4c9

Updata ninja to v1.7.2. · 28a1ff42

thakis authored Nov 09, 2016

New binaries for Mac, Linux32, Linux64, Windows.  Also update shell script.
See the bug for how these were built.
The main "new" thing is a regression fix where 1.7.1 broke %e %r in
NINJA_STATUS.

BUG=663749

Review-Url: https://codereview.chromium.org/2489023002

28a1ff42

08 Nov, 2016 2 commits

Default to not using --find-copies-harder · ae09f5fa

scottmg authored Nov 08, 2016

It's too ridiculously slow on Windows and Mac, and there's very little benefit to finding files that were "copied" from an historical file (as
opposed to one that's in the current patch).

BUG=544889

Review-Url: https://codereview.chromium.org/2488823002

ae09f5fa

Clean up gerrit_util's handling of unknown reviewer/cc · df86e301

Aaron Gable authored Nov 08, 2016

This is still important, but at least now it won't result
in a stacktrace.

Change-Id: If6e7e15a98b0a03df7e978201762fea670312ede
Reviewed-on: https://chromium-review.googlesource.com/408660Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

df86e301

07 Nov, 2016 1 commit

Roll recipe dependencies (trivial). · 600d9dfd

recipe-roller authored Nov 07, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/d6020a7ef29d3f7fb77d16a1cd6b32c7b2f09dc2 Delete tryserver_gerrit and its old properties. (tandrii@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2481763002

600d9dfd

04 Nov, 2016 8 commits

fix git-cl-try without parameters · e4f0fe02

nodir authored Nov 04, 2016

Master names were confused with bucket names

R=tandrii@chromium.org, qyearsley@chromium.org
BUG=661580

Review-Url: https://codereview.chromium.org/2482523002

e4f0fe02

swarmbucket: git_cache must be in cwd · dfe6bbbb

nodir authored Nov 04, 2016

on swarmbucket, git_cache must be in cwd

R=vadimsh@chromium.org, martiniss@chromium.org

Review-Url: https://codereview.chromium.org/2473243003

dfe6bbbb

Revert of fix swarmbucket infra path (patchset #3 id:40001 of... · 5da21889

martiniss authored Nov 04, 2016

Revert of fix swarmbucket infra path (patchset #3 id:40001 of https://codereview.chromium.org/2477033002/ )

Reason for revert:
Broke build CQ: https://luci-milo.appspot.com/swarming/task/324a5636a5cfdf10/steps/Uncaught_Exception/0/logs/exception/0

Original issue's description:
> fix swarmbucket infra path
>
> Do not rely on buildbot config which goes up 4 directories. Everything
> should happen in the workdir. Also exclude any project-specific paths.
>
> This fixes the problem that swarmbucket builds expect git_cache to be in
> /b/git_cache. It should be in the CWD/git_cache. This will fix Windows
> builders.
>
> R=vadimsh@chromium.org
> BUG=
>
> Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/b8b5aaea9217f0a2e0b9a48bfa6e6fc054d74d23

TBR=vadimsh@chromium.org,nodir@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2484433002

5da21889

Roll recipe dependencies (trivial). · 3ac992bd

recipe-roller authored Nov 04, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/6d04a2a25f68b37024e9d45ff32252e4d4903664 Revert of Delete tryserver_gerrit and its old properties. (patchset #1 id:1 of https://codereview.chromium.org/2464673002/ ) (martiniss@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2478313005

3ac992bd

fix swarmbucket infra path · b8b5aaea

nodir authored Nov 04, 2016

Do not rely on buildbot config which goes up 4 directories. Everything
should happen in the workdir. Also exclude any project-specific paths.

This fixes the problem that swarmbucket builds expect git_cache to be in
/b/git_cache. It should be in the CWD/git_cache. This will fix Windows
builders.

R=vadimsh@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2477033002

b8b5aaea

Implement and test git cl try for Gerrit. · 8c5a353e

tandrii authored Nov 04, 2016

R=borenet@chromium.org,qyearsley@chromium.org
BUG=599931

Review-Url: https://codereview.chromium.org/2468263005

8c5a353e

Roll recipe dependencies (trivial). · a5025f62

recipe-roller authored Nov 04, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/0e5c8ab8680b51dfe55745ade2b26a7aa15e0f53 Add LogDog environment variables to whitelist. (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2480453003

a5025f62

Disable coverage in depot_tools tests. · 39cec0e7

iannucci authored Nov 04, 2016

R=dnj@chromium.org, martiniss@chromium.org
BUG=662277

Review-Url: https://codereview.chromium.org/2471133006

39cec0e7

03 Nov, 2016 2 commits

Roll recipe dependencies (trivial). · 8c4faee3

recipe-roller authored Nov 03, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/6b5af03500f8ab57a2905d11af2690de990961bd Remove unused --bootstrap-script option. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2469863007

8c4faee3

Roll recipe dependencies (nontrivial). · e0b205e8

recipe-roller authored Nov 03, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must CQ the change manually.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/2c474706779466f2e18e83a632f6d6debf63787f Fix issue overriding bug properties.test_api.tryserver for Gerrit. (tandrii@chromium.org)

R=tandrii@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2473883003

e0b205e8

02 Nov, 2016 3 commits

Roll recipe dependencies (trivial). · 27b7a139

recipe-roller authored Nov 02, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/2ecaa8b5944f016f6bda5cbe93ec6f54e8ead4fb Delete tryserver_gerrit and its old properties. (tandrii@chromium.org)
  https://crrev.com/fabbc26432e0ba2e5492e01640722eb4641519c9 Add exit status proto (martiniss@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2472853002

27b7a139

Recipes: Stop using tryserver_gerrit in depot_tools. · 9701c7c1

tandrii authored Nov 02, 2016

Only changes how test properties are given, no change in functionality.
Should enable recipe roll of https://codereview.chromium.org/2464673002.

R=martiniss@chromium.org,machenbach@chromium.org
BUG=chromium:645616

Review-Url: https://codereview.chromium.org/2468373002

9701c7c1

Remove --bootstrap-script parameter from recipes.py · 1158a545
iannucci authored Nov 02, 2016
```
R=martiniss@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2465613002
```
1158a545

01 Nov, 2016 1 commit
- git-cl-land: print url of final commit location · 32978d96
  agable authored Nov 01, 2016
```
BUG=661187

Review-Url: https://codereview.chromium.org/2466953003
```
  32978d96
31 Oct, 2016 2 commits

Make bot_update on win more resilient · 86fe47d1

katthomas authored Oct 31, 2016

Sometimes Windows has trouble deleting files. This can cause problems
when lockfiles are left in .git directories.

R=agable@google.com
BUG=659178

Review-Url: https://codereview.chromium.org/2454463002

86fe47d1

depot_tools: Remove DoGetTrySlaves, GetTrySlavesExecuter, GetPreferredTrySlaves · 136b49ff

qyearsley authored Oct 31, 2016

Note: This CL originally just removed a deprecated use of Remove use of DoGetTrySlaves, suggested in http://crrev.com/2442153002, then was expanded to remove DoGetTrySlaves, GetPreferredTrySlaves and GetTrySlavesExecuter since these are all deprecated and unused.

BUG=660453

Review-Url: https://codereview.chromium.org/2453823002

136b49ff

28 Oct, 2016 3 commits

Log error message if os.rename fails · b7c80888

katthomas authored Oct 28, 2016

R=agable@google.com
BUG=659178

Review-Url: https://codereview.chromium.org/2448983004

b7c80888

git cl try: Simplify _get_bucket_map. · dd49f94c

qyearsley authored Oct 28, 2016

Assuming that assuming bots are always just builder names, and they're never specified along with tests in git cl --bot options, then some logic used for git cl try can be removed.

Review-Url: https://codereview.chromium.org/2448193006

dd49f94c

Remove apply_gerrit_ref from bot_update recipe API · d918da64
borenet authored Oct 28, 2016
```
BUG=skia:5588

Review-Url: https://codereview.chromium.org/2453663004
```
d918da64

27 Oct, 2016 1 commit

Roll recipe dependencies (trivial). · 03832ffc

recipe-roller authored Oct 27, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/799034e5ee1634cf2d88b0a666e0d8ca934cd895 Remove --bootstrap-script parameter from recipes.py. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2460683003

03832ffc

26 Oct, 2016 3 commits

Revert of Call status before reset in gclient sync. (patchset #2 id:20001 of... · b655dbda

justincohen authored Oct 26, 2016

Revert of Call status before reset in gclient sync. (patchset #2 id:20001 of https://codereview.chromium.org/2447813003/ )

Reason for revert:
https://codereview.chromium.org/2444403003/ makes this pretty redundant.  Reverting this.

Original issue's description:
> Call status before reset in gclient sync.
>
> Calling status before reset will ensure files that have no been changed do not
> get deleted by reset --hard.
>
> BUG=642711
>
> Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/d74a7b4c14512d95cb46204bb7a70ba5666b5eb7

TBR=sdefresne@chromium.org,maruel@chromium.org,dpranke@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=642711

Review-Url: https://codereview.chromium.org/2453083002

b655dbda

git cl try: support multiple bots from different masters without specifying master. · 123a468d

qyearsley authored Oct 26, 2016

It might be good to make this change after the refactoring CL http://crrev.com/2442153002.

BUG=640740

Review-Url: https://codereview.chromium.org/2439293002

123a468d

git cl try: Remove --name option, stop sending "reason" property. · 5eb0519b

qyearsley authored Oct 26, 2016

When triggering the build, there's a field called "reason",
which is currently populated by default with the user's
branch name.

I have a feeling that this is optional and could be completely
omitted.

Andrii notes that if users want to send a "reason" string,
they could send invoke git cl try with the argument -p reason="<reason>".

PSA on infra-dev:
https://groups.google.com/a/chromium.org/d/msg/infra-announce/PXkM1WinTYY/w2IvN5B4AwAJ

BUG=659552

Review-Url: https://codereview.chromium.org/2428383010

5eb0519b