- 24 May, 2017 2 commits
-
-
Dan Jacques authored
Several boilerplate batch files include a provision to prepend "depot_tools" to PATH prior to running those tools. This undermines the utility of PATH overrides, since these tools specifically force their "depot_tools" sub-paths to be used regardless of environment. The origin of this behavior is likely limited to a specific fix for a specific problem, but was then perpetuated by the copy/paste of boilerplate bootstrap code as more bootstraps were added. This is important in upcoming configurations, where core tools such as Python and Git will be overridden via PATH on the bots. Cygwin users who depended on this behavior should just add "depot_tools" to their PATH in the appropriate location (i.e. in their .bashrc). BUG=chromium:714293, chromium:724902 TEST=None Change-Id: Ie948a430847d20326d2411e9296cacd02f83a537 Reviewed-on: https://chromium-review.googlesource.com/510290 Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
-
Wei-Yin Chen (陳威尹) authored
If the repo is a btrfs subvolume, take a snapshot instead of using "cp --reflink". Taking a snapshot is much faster, and uses less disk space for metadata. Bug: 721585 Change-Id: I97753dc30d46ff56d84d65f8d815c19d09cf104b Reviewed-on: https://chromium-review.googlesource.com/513586Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
-
- 23 May, 2017 13 commits
-
-
Aaron Gable authored
The private mode is a better fit for how we want private (e.g. security-critical) changes to be reviewed. Draft was simply a placeholder until private was ready for use, which it now is. Bug: 721880, 722627 Change-Id: Ib7b76c555437f4ddc7ab2b0e7ce5a9f9ee8be825 Reviewed-on: https://chromium-review.googlesource.com/513243 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by: Andrew Bonventre <andybons@chromium.org>
-
Wei-Yin Chen (陳威尹) authored
When the repo is copied in copy-on-write mode, print informative messages afterwards to help users. Also, skip "git clean" step in copy-on-write mode. Bug: 721585, 723856 Change-Id: I3235398c960d59a4cf44cfe7dffc79ed008a5190 Reviewed-on: https://chromium-review.googlesource.com/512262Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
-
Paweł Hajdan, Jr authored
- allow None in deps_os values (for chromeos buildspecs) - allow string formatting (%) in expressions (for dart) - allow empty lists/dicts (for build slaves) - allow target_os (for internal android) Bug: 570091, 722206, 725422 Change-Id: I7f3d822a1c4aac16fddd96ef2f9f365e05b2d0e8 Reviewed-on: https://chromium-review.googlesource.com/512724Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
Paweł Hajdan, Jr authored
This relands the safe portion of outage-causing https://chromium-review.googlesource.com/c/509451/ Landing this simple CL will allow pre-emptively adding escape hatch to critical places (such as update_scripts) to make relanding validation safer. Bug: 570091 Change-Id: I4d963bd9b140b7b6bca35d4d5e41768bc1a3d7e0 Reviewed-on: https://chromium-review.googlesource.com/512744 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
-
Paweł Hajdan, Jr authored
Original CL: https://chromium-review.googlesource.com/509693 This feature appears unused, and removing it will simplify the codebase. Bug: 661382 Change-Id: I0d83b537b57d0b9ca65c7101d13e0ad6c1642a29 Reviewed-on: https://chromium-review.googlesource.com/512842Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
Paweł Hajdan, Jr authored
Original CL: https://chromium-review.googlesource.com/509614 This feature seems to be unused, and removing it will simplify handling hooks a little bit. Bug: 661382 Change-Id: I7f02b34fc399c78bef76420df19a93105ab098ac Reviewed-on: https://chromium-review.googlesource.com/512644Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
Andrii Shyshkalov authored
This reverts commit 568e5919. Reason for revert: maybe caused outage Original change's description: > gclient validate: allow None in deps_os values > > Bug: 722206 > Change-Id: I15024670e481c166ca34a2ec8dac93c739684121 > Reviewed-on: https://chromium-review.googlesource.com/509537 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> > TBR=phajdan.jr@chromium.org,dpranke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug: 722206 Change-Id: Ia0f3825d204e65575020d108873dee82da47a1e6 Reviewed-on: https://chromium-review.googlesource.com/512345Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
This reverts commit 3e6d7c1c. Reason for revert: maybe caused outage. Original change's description: > gclient: remove support for $matching_files in hooks > > This feature seems to be unused, and removing it will > simplify handling hooks a little bit. > > Bug: 661382 > Change-Id: I89f28dedb7f59cd475b176cfb1f023094520d6b7 > Reviewed-on: https://chromium-review.googlesource.com/509614 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> > TBR=phajdan.jr@chromium.org,dpranke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug: 661382 Change-Id: I47fe26e7381682b5b428a3775bf27a551c57d5e6 Reviewed-on: https://chromium-review.googlesource.com/512344Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
This reverts commit bf72b593. Reason for revert: maybe caused outage. Original change's description: > gclient: remove support for From() > > This feature appears unused, and removing it will simplify the codebase. > > Bug: 661382 > Change-Id: I545befb2c592eea53c54552018ce2d3dda7670f5 > Reviewed-on: https://chromium-review.googlesource.com/509693 > Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > TBR=phajdan.jr@chromium.org,dpranke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug: 661382 Change-Id: I4db9554a0a3a64a3a69908560b6da2a9963518f2 Reviewed-on: https://chromium-review.googlesource.com/512343Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
This reverts commit 8db72efd. Reason for revert: maybe caused outage. Original change's description: > gclient: enable syntax validation by default > > Please pass --disable-syntax-validation as an escape hatch. > > Bug: 570091 > Change-Id: Iceadc0d2fc54ca68e775c3bc7590f4329ddb4951 > Reviewed-on: https://chromium-review.googlesource.com/509451 > Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > TBR=phajdan.jr@chromium.org,dpranke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug: 570091 Change-Id: I5b91653839f09a29c4c633fba91b23260ba96761 Reviewed-on: https://chromium-review.googlesource.com/512342Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Paweł Hajdan, Jr authored
Please pass --disable-syntax-validation as an escape hatch. Bug: 570091 Change-Id: Iceadc0d2fc54ca68e775c3bc7590f4329ddb4951 Reviewed-on: https://chromium-review.googlesource.com/509451 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
-
Paweł Hajdan, Jr authored
This feature appears unused, and removing it will simplify the codebase. Bug: 661382 Change-Id: I545befb2c592eea53c54552018ce2d3dda7670f5 Reviewed-on: https://chromium-review.googlesource.com/509693 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
-
Paweł Hajdan, Jr authored
This feature seems to be unused, and removing it will simplify handling hooks a little bit. Bug: 661382 Change-Id: I89f28dedb7f59cd475b176cfb1f023094520d6b7 Reviewed-on: https://chromium-review.googlesource.com/509614Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 22 May, 2017 5 commits
-
-
Paweł Hajdan, Jr authored
Bug: 722206 Change-Id: I15024670e481c166ca34a2ec8dac93c739684121 Reviewed-on: https://chromium-review.googlesource.com/509537Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
Aaron Gable authored
To encourage folks to upload to Gerrit. Bug: 685321 Change-Id: I849ed53f95a2205959237fe825ffe41e349ff8c7 Reviewed-on: https://chromium-review.googlesource.com/510963Reviewed-by: Andrew Bonventre <andybons@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
Aaron Gable authored
This information is redundant when using Gerrit, and is well known to anyone still using Rietveld. Change-Id: I03119a84edb67fd20fbe5e2a8e0f0975e69558ed Reviewed-on: https://chromium-review.googlesource.com/510923Reviewed-by: Andrew Bonventre <andybons@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
Dan Jacques authored
Currently, the "cipd" recipe module allows a package to be created by adding directories to a PackageDefinition via "add_dir". However, there is no current way to add the entirety of a root directory to a package. The PackageDefinition will generate a relative path of "''", which CIPD will reject as empty. Make it so that if the user supplies the root directory as the directory to add to the package, it properly includes it as ".". BUG=None TEST=local - Ran recipe with this modification, seems to work R=iannucci@chromium.org, nodir@chromium.org, vadimsh@chromium.org Change-Id: Ib5c72038cf153776808f084db835c60f61fd9044 Reviewed-on: https://chromium-review.googlesource.com/510309Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Daniel Jacques <dnj@chromium.org>
-
Aaron Gable authored
We usually only retry on server errors. But most 404s that clients will recieve are due to replication lag, not due to querying an issue that truly doesn't exist. This CL lets gerrit_util (which is used primarily by git-cl) to retry on 404s to help fight errors due to replication lag. R=tandrii@chromium.org Bug: 717197 Change-Id: I26dbbf6c4895a13f7d57e4be3c23450111c949bc Reviewed-on: https://chromium-review.googlesource.com/510000Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
- 19 May, 2017 2 commits
-
-
Aaron Gable authored
This gives PRESUBMIT equal support for all the gerrit-style footers that we're migrating to. R=iannucci@chromium.org, tandrii@chromium.org Bug: 710327,710803 Change-Id: I64b8f39ef923d90ebda7dd191b83d1a7cc87c776 Reviewed-on: https://chromium-review.googlesource.com/506551Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
Dan Jacques authored
All known repositories have been switched to "recipe_engine/url". BUG=None TEST=None R=iannucci@chromium.org Change-Id: Ibed376b916f59b5d7142aa2ffd210919079a0862 Reviewed-on: https://chromium-review.googlesource.com/508163Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Daniel Jacques <dnj@chromium.org>
-
- 18 May, 2017 4 commits
-
-
Paweł Hajdan, Jr authored
This is based on https://codereview.chromium.org/2474543002/ Bug: 661382 Change-Id: I191ec16e0ce69a782979ae7d59b108747429ab78 Reviewed-on: https://chromium-review.googlesource.com/505067 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Michael Moss <mmoss@chromium.org>
-
Aaron Gable authored
We want PRESUBMIT to be able to equally support BUG= tags (old style) and Git-Footer: footers (new style). This change refactors the way that the presubmit api gives access to those properties so that it is easier to add support for equivalent footers. It also limits the scope of tags/footers that it exposes, as code search shows no PRESUBMIT files that take advantage of any of the more esoteric ones. Bug: 710327, 710803 Change-Id: I86f1d6cb2e1f0aff9653ef3fb455e0a6f47acf5d Reviewed-on: https://chromium-review.googlesource.com/506450 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/2f2d5c663eddcd8b6924a8775aaf88f3600d2ac8 [step_runner] expand try/catch to cover all step preparation functionality (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I0dc03d4b11e122fce29bff570542b84e4f1bc798 Reviewed-on: https://chromium-review.googlesource.com/508073Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
Paweł Hajdan, Jr authored
This was regressed in https://chromium-review.googlesource.com/475950 Downstream regression test added in https://chromium-review.googlesource.com/c/508697/ Bug: 723572 Change-Id: I44dbaf9e4996388b898359141db879bd0a1023d9 Reviewed-on: https://chromium-review.googlesource.com/508790 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Daniel Jacques <dnj@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
-
- 17 May, 2017 5 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/cae7fab7b53f5c739176e95a116401592ff2b9e2 [step_runner] fix error text (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ie9bc31c2a3940236d1b60b51d4054e7cf30482ca Reviewed-on: https://chromium-review.googlesource.com/508309Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/a819ab06fa3974b0fdee796aa4dd883274f4df2f [step_runner] do not immediately bail when START_DIR is gone. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ie1802d4c2bf37b9b25eb966703e1d89b68139ce1 Reviewed-on: https://chromium-review.googlesource.com/508128Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
Dan Jacques authored
Retries are no longer necessary, since the Git wrapper will retry all transient Git operations. BUG=None TEST=None R=hinoka@chromium.org, iannucci@chromium.org Change-Id: I18f066004992c98e54665833360944cc7d6550cc Reviewed-on: https://chromium-review.googlesource.com/506375 Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Ryan Tseng <hinoka@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/3b8a0585e3c7390a7c1c339c6b70d042de8f913c [engine] make all ad-hoc steps properly colored (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I37b117ee6de9306b12df756cb2e9d0004c3c39e1 Reviewed-on: https://chromium-review.googlesource.com/507107Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/632d231c826e13b02ade64d77ed2a41e25aa6fb3 [step_runner] Add a Placeholder Exception step when rendering placeholders raises a StepFailure. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: If78183b73f434ba6e5618288bfa78ec0b3168cb8 Reviewed-on: https://chromium-review.googlesource.com/505559Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
- 16 May, 2017 9 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/c2d0f5d807793894df762930bc5d2729297658bf [bundle] do not include the main repo in the overrides. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Id1ca873cecce14bdf067588d4a8d756864209f59 Reviewed-on: https://chromium-review.googlesource.com/505444Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
Aaron Gable authored
Many WATCHLIST and codereview.settings files contain large public email lists, which defeats the purpose of private reviews. R=tandrii@chromium.org Bug: 721880 Change-Id: Ibb3f314f735b783e628f8cc1fc22c74e0df59f1c Reviewed-on: https://chromium-review.googlesource.com/506489Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
Wei-Yin Chen (陳威尹) authored
On filesystems supporting copy-on-write, like Btrfs and ZFS, use "cp --reflink" to achieve faster speed and lower disk space usage. Option --reflink and --no-reflink can override the automatic detection. When reflink is supported, toolchains, support libraries, and artifacts would also be preserved. This means you can do incremental builds right after creating a new workdir. For Linux Chromium checkout, one additional workdir only takes 0.8~1 GB disk space in Btrfs, including data and metadata, depending on how many artifacts are there inside the out*/ directories. Change-Id: I8b913efba9e5afaeea2adc1c10a561f63cb50282 Bug: 721585 Reviewed-on: https://chromium-review.googlesource.com/499567 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
-
Wei-Yin Chen (陳威尹) authored
This makes it easier to add options to this script. There should be no functional changes except for slightly different text output. Change-Id: I4d68a8c4aa0c159eae9435fe962e53f6f09d2d47 Reviewed-on: https://chromium-review.googlesource.com/499527 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
-
Andrii Shyshkalov authored
R=agable@chromium.org,sergeyberezin@chromium.org,iannucci@chromium.org BUG=722853 Change-Id: I9bd8c259a87cc65e320e99d9c5e18838b970d543 Reviewed-on: https://chromium-review.googlesource.com/505495Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/3343170e687e1cfa402e70c6e90019f9f88f913f [package.py] prevent overriding undeclared repo dependency. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ifb8cdb6411ae501b8c967fe780571eb6a875a9ae Reviewed-on: https://chromium-review.googlesource.com/505440Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
Michael Achenbach authored
This reverts commit 2c199e1e. Reason for revert: This makes calls to gclient that have the only intention of updating gclient fail, like: https://cs.chromium.org/chromium/src/v8/tools/try_perf.py?l=93 Reverting for now to give time to clean up such scripts before reland. Original change's description: > gclient: return non-zero exit code on unknown command > > Bug: none > Change-Id: I447f66765679b7b66b5748af1cf1f501610603bf > Reviewed-on: https://chromium-review.googlesource.com/504408 > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> > Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> > TBR=iannucci@chromium.org,phajdan.jr@chromium.org,dpranke@chromium.org,tandrii@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug: none Change-Id: I9496f7192dfde1e38c186a94ac985190b76b2438 Reviewed-on: https://chromium-review.googlesource.com/506563Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/1a90c2644e03337ecfd91dd1e76a7c2713b42808 [platform] improve testing assertions. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ic9dc336b8df3651d928628d07f22a3f675efa21d Reviewed-on: https://chromium-review.googlesource.com/505556Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/ea1ac7522268ac435550c701790fd1276f3e6a05 [post_process] make the check function return True if the expression is (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: If7a208614fb52b33108907bd274ce1fa9b44a833 Reviewed-on: https://chromium-review.googlesource.com/505871Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-