Skip to content

C
Chromium_Depot_tools
Switch branch/tag
  1. 15 Aug, 2018 5 commits
  3. 14 Aug, 2018 4 commits
  5. 10 Aug, 2018 2 commits
  7. 09 Aug, 2018 4 commits
  9. 08 Aug, 2018 4 commits
  11. 07 Aug, 2018 1 commit
  13. 06 Aug, 2018 1 commit
  15. 03 Aug, 2018 1 commit
  17. 02 Aug, 2018 3 commits
  19. 31 Jul, 2018 1 commit
    • Edward Lemur's avatar
      metrics: Separate metrics collection and print notice logic. · 6f812e13
      Edward Lemur authored 
      As it is right now, when a function is collecting metrics it prints
the notice and calls sys.exit() to ensure the notice is the last thing
that is printed.

git-cl split has to call git-cl upload multiple times, but once it has
been called once, it exits, so only the first cl is uploaded.

This separates metrics collection from notice printing, so that the
function that is collecting metrics behaves like a function that isn't.
It also makes sure we don't collect metrics for multiple functions at
the same time.

Bug: 868280
Change-Id: Ic58ebe7d19e09ed85fa8b0af76dcbf608ee4c9bc
Reviewed-on: https://chromium-review.googlesource.com/1153503Reviewed-by: 's avatarAaron Gable <agable@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
      6f812e13
  21. 30 Jul, 2018 2 commits
  23. 27 Jul, 2018 3 commits
  25. 26 Jul, 2018 6 commits
  27. 25 Jul, 2018 1 commit
  29. 24 Jul, 2018 2 commits
    • recipe-roller's avatar
      Roll recipe dependencies (trivial). · 01ce0591
      recipe-roller authored 
      This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/c201ea2c059e30b35d3b6514cb5febef659c4806 Add basic led module (martiniss@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7591b7e7694a8265386084a01185642b551c05e1
Reviewed-on: https://chromium-review.googlesource.com/1148963
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: 's avatarRecipe Roller <recipe-roller@chromium.org>
      01ce0591
    • Edward Lemur's avatar
      Reland "Reland "gclient_scm: Use cherry-picking instead of rebasing."" · ca7d8815
      Edward Lemur authored 
      Abort any cherry-picks before applying the patch, so that if the bots are in a
bad state, we don't fail.

Original change's description:
> Reland "gclient_scm: Use cherry-picking instead of rebasing."
>
> The failures were caused by:
>  1 - When one change (call it #2) has been uploaded on top of another (#1),
>      and (#1) has already landed, git cherry-pick complains that the range
>      '<merge-base>..<change #2>' contains empty commits, since the contents
>      of (#1) are already present in the tree.
>  2 - We did not abort the cherry-picking when 'git cherry-pick' failed,
>      so a failure made all further CLs in that bot fail.
>
> This CL fixes it and prevents further regressions.
>
> Original change's description:
> > gclient_scm: Use cherry-picking instead of rebasing.
> >
> > Currently gclient might include extra commits when applying patches.
> > For example, in this case we checkout |patch| and rebase it on top of |base|,
> > thus including an |extra commit| that we shouldn't.
> >
> > o master
> > |
> > . o patch
> > |/
> > o extra commit
> > |
> > o base (what gclient synced src at)
> >
> > This change uses the merge-base between |patch| and |master| to cherry-pick only
> > the changes belonging to the patch.
> >
> > Bug: 850812
> > Change-Id: I138192f96bc62b1bb19b0e1ad952c8f8c67631c4
> > Reviewed-on: https://chromium-review.googlesource.com/1137052
> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> > Reviewed-by: Aaron Gable <agable@chromium.org>
>
> Bug: 850812
> Change-Id: I83f38d0a258df3f5cd89e277f0d648badff29a22
> Reviewed-on: https://chromium-review.googlesource.com/1139554
> Reviewed-by: Aaron Gable <agable@chromium.org>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

Bug: 850812
Change-Id: Ic65bda67c792bd7af5ec013a62d9615d1498eb3a
Reviewed-on: https://chromium-review.googlesource.com/1142805Reviewed-by: 's avatarAaron Gable <agable@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
      ca7d8815