Commits · 14db1dfd88b987c9119f59f75f1f27b8e7c49602 · Linshizhi / Chromium_Depot_tools

22 Mar, 2017 1 commit

Revert "define builder_cache base path" · 14db1dfd

Sergey Berezin authored Mar 22, 2017

This reverts commit e718958c.

Reason for revert: Suspected to have caused an outage http://o/370111
It seems to have shifted the current dir to a new place, created another checkout and some bots with small disk space ran out of disk.

Original change's description:
> define builder_cache base path
> 
> chromium_tests recipe module currently checks if builder_cache base path
> is defined. If it is not, it let's the caller to decide where to put
> the cache. All the callers choose start_dir.
> https://cs.chromium.org/search/?q=get_checkout_dir&type=cs
> 
> In LUCI we want to use [CACHE]/builder as builder cache. To do that we
> want to update chromium_tests recipe module to use [CACHE]/builder if
> builder_cache is not defined.
> 
> Define builder_cache in buildbot to point to start dir, so that in LUCI
> it is not defined and thus [CACHE]/builder is used.
> 
> R=iannucci@chromium.org
> BUG=660481
> 
> Change-Id: I9018da5c43a5396add6a26ad2c12b1755fbe6307
> Reviewed-on: https://chromium-review.googlesource.com/457439
> Reviewed-by: Ryan Tseng <hinoka@chromium.org>
> Commit-Queue: Nodir Turakulov <nodir@chromium.org>
> 

TBR=iannucci@chromium.org,hinoka@chromium.org,estaab@chromium.org,nodir@chromium.org,chromium-reviews@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=660481

Change-Id: Ia239ebe12a5bea1987c2ee23e543460efe753c81
Reviewed-on: https://chromium-review.googlesource.com/457778Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>

14db1dfd

21 Mar, 2017 4 commits

Roll recipe dependencies (trivial). · b87fa094

recipe-roller authored Mar 21, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/157bae7bdfe2608d4bff84eaa90db0fdae71e26b Add structured JSON result output to new 'test' command (phajdan.jr@chromium.org)

TBR=iannucci@chromium.org

Change-Id: If68f7c3b4a1aa1e8fc30338a093949524d1c05fb
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/457201
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

b87fa094

define builder_cache base path · e718958c

Nodir Turakulov authored Mar 20, 2017

chromium_tests recipe module currently checks if builder_cache base path
is defined. If it is not, it let's the caller to decide where to put
the cache. All the callers choose start_dir.
https://cs.chromium.org/search/?q=get_checkout_dir&type=cs

In LUCI we want to use [CACHE]/builder as builder cache. To do that we
want to update chromium_tests recipe module to use [CACHE]/builder if
builder_cache is not defined.

Define builder_cache in buildbot to point to start dir, so that in LUCI
it is not defined and thus [CACHE]/builder is used.

R=iannucci@chromium.org
BUG=660481

Change-Id: I9018da5c43a5396add6a26ad2c12b1755fbe6307
Reviewed-on: https://chromium-review.googlesource.com/457439Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

e718958c

Roll recipe dependencies (trivial). · c07db621

recipe-roller authored Mar 21, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/6488afec4a1b4ac51a8601e308c42cd6a176c190 [recipes.cfg] upgrade recipes.cfg to JSON. (iannucci@chromium.org)

TBR=iannucci@chromium.org

Change-Id: Ia3a9c57d3e995fcfd56d1a58fb69a60bb1952a24
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/456830
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

c07db621

Roll recipe dependencies (trivial). · e08398fd

recipe-roller authored Mar 21, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/fb61dcf4145be9d98f85d02af72a498f09782800 [autoroll] cache commit_metadata operations. (iannucci@chromium.org)

TBR=iannucci@chromium.org

Change-Id: Id069b0d22d90f5248f9d2537c522e72828be57e6
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/456806
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

e08398fd

20 Mar, 2017 5 commits

Roll recipe dependencies (trivial). · 328f60d1

recipe-roller authored Mar 20, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/81de92519dd374d9b193362034fae8861476bc5f [autoroll] make autoroller propagate changes to recipes.py. (iannucci@chromium.org)
  https://crrev.com/0ee0446195595e5df02fc2dc82e4988b601b113e Carefully clean more unused recipe expectation directories in new 'test' command (phajdan.jr@chromium.org)
  https://crrev.com/803d6ead998b4bbca601fb3a984e76ddc063806d Fix autoroll command. (iannucci@chromium.org)

TBR=iannucci@chromium.org

Change-Id: I82dd353affefd2fef61af3ed0c6ceb2d74d601a8
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/456386
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

328f60d1

Run new recipes 'test' command · 742adbd7

Paweł Hajdan, Jr authored Mar 20, 2017

BUG=chromium:699120

Change-Id: Ie498bec2e2e38cbde8fac6409b13d2032b2e1a1b
Reviewed-on: https://chromium-review.googlesource.com/457318Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

742adbd7

Roll recipe dependencies (trivial). · aebadcc3

recipe-roller authored Mar 20, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/aa0a2d61cd31decf9a5c048b677ba38eb209a1c6 Correctly handle tricky characters in test names in new 'test' command (phajdan.jr@chromium.org)

TBR=iannucci@chromium.org

Change-Id: I35067e2d605ea7b64c4422b184f10f7b541b82d8
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/456804
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

aebadcc3

git cl comment: require explicit --codereview with -i|--issue flag. · 0d6b46e3

Andrii Shyshkalov authored Mar 17, 2017

R=agable@chromium.org,machenbach@chromium.org
BUG=698236

Change-Id: If79f938e457f176c47badd75f78ed4ecb764ec2d
Reviewed-on: https://chromium-review.googlesource.com/456700
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

0d6b46e3

Roll recipe dependencies (trivial). · 0bbe6fa0

recipe-roller authored Mar 20, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/e300f3a3b8193b84b88599faa30c0301e155c906 Handle unused recipe expectations in new 'test' command (phajdan.jr@chromium.org)

TBR=iannucci@chromium.org

Change-Id: I7ef26ceef1bd243a88a02a42b0092a8f02ea679d
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/456363
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

0bbe6fa0

19 Mar, 2017 1 commit

Fix smoke test to not hard-code python executable location. · e86f6de8

Robert Iannucci authored Dec 02, 2016

BUG=670678

Change-Id: If3104a6d666e84d7150ba805672dac3e34a1f9a1
Reviewed-on: https://chromium-review.googlesource.com/416269
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

e86f6de8

17 Mar, 2017 6 commits

Roll recipe dependencies (trivial). · ecf3dbe4

recipe-roller authored Mar 17, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/78f105cbebb6e8dc99d64638d400868851cb0c40 Add --train support to the new 'test' command (phajdan.jr@chromium.org)

TBR=iannucci@chromium.org

Change-Id: Iea696baa5091710c314309e063d7bd008953dcca
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/457078
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

ecf3dbe4

git cl comment: implement fetching comments for Gerrit. · 5a0cf204

Andrii Shyshkalov authored Mar 17, 2017

R=agable@chromium.org,machenbach@chromium.org
BUG=698236

Change-Id: I36dcd2f10d0518a9f04a766e09c1ab00f2ce4d3b
Reviewed-on: https://chromium-review.googlesource.com/456699
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>

5a0cf204

git cl comment: refactor fetching comments for Rietveld and add tests. · d8aa49f3

Andrii Shyshkalov authored Mar 17, 2017

R=agable@chromium.org,machenbach@chromium.org
BUG=698236

Change-Id: I04e264130952e3e270540fae8381db544cf40e7c
Reviewed-on: https://chromium-review.googlesource.com/456697
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>

d8aa49f3

git cl description: don't bother if description diff is trailing whitespace. · 680253d3

Andrii Shyshkalov authored Mar 15, 2017

BUG=700239
R=iannucci@chromium.org

Change-Id: Ica4567288c1cd83f72cce5d10c523270b69c36d4
Reviewed-on: https://chromium-review.googlesource.com/455739Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

680253d3

git cl comment: implement adding comment for Gerrit. · 625986db

Andrii Shyshkalov authored Mar 15, 2017

BUG=698236

Change-Id: Ia1a36af71c348be991d77083092c5043c2642c19
Reviewed-on: https://chromium-review.googlesource.com/455877Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

625986db

Pass env via context rather than api.step kwargs · aa534e50

Paweł Hajdan, Jr authored Mar 17, 2017

See https://groups.google.com/a/chromium.org/d/msg/infra-dev/p8Iq9v9Y4k0/w__b1zTWAQAJ
for more context.

BUG=685746

Change-Id: If0bdcbd354b2535de22a7be78dad86e15c9f2cea
Reviewed-on: https://chromium-review.googlesource.com/456217
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

aa534e50

16 Mar, 2017 6 commits

Roll recipe dependencies (trivial). · 12fb9ede

recipe-roller authored Mar 16, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/d5a670b19aba7fb9a7f6430d39dab1d3414b578a Make a copy of env in the recipe context (phajdan.jr@chromium.org)

TBR=iannucci@chromium.org

Change-Id: Ieab8f3536096944dac96b1f0424fa8d75b014403
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/456378
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

12fb9ede

git cl creds-check: add reporting. · 0a0b067e

Andrii Shyshkalov authored Mar 16, 2017

BUG=689543

Change-Id: I2c5dd9e1ef4a23ba805c8c057ad44c87cfb65a5b
Reviewed-on: https://chromium-review.googlesource.com/455782
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>

0a0b067e

git cl creds-check: add methods analysing .gitcookies. · 9780050b

Andrii Shyshkalov authored Mar 16, 2017

These methods are used to produce report in the next CL.

BUG=689543

Change-Id: I71b2705ac8b046103b4982d47f7ec97f8ef7818b
Reviewed-on: https://chromium-review.googlesource.com/455838
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>

9780050b

Support JSON output in my_activity.py · e5deedfc

Nicolas Dossou-gbete authored Mar 15, 2017

That JSON output format shows some additional fields such as bug number
for CLs, label and component for issues.

Also does minor changes like replacing the old code.google.com
references and using short urls when possible.

BUG=None

Change-Id: I988d292dc57b72a2f2c6f12096266df8a09a4dd8
Reviewed-on: https://chromium-review.googlesource.com/422203Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>

e5deedfc

Update recipes.py to f605e5c0bc2e748170ca851383cb552c7225316b · 370ca1bd

Robert Iannucci authored Mar 16, 2017

This will enable it to be compatible with both the textpb and
upcoming jsonpb form of recipes.cfg.

BUG=699379

Change-Id: Iafa3d959190648eca4fa864aaa79430759e568fe
Reviewed-on: https://chromium-review.googlesource.com/455585Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

370ca1bd

Roll recipe dependencies (trivial). · 63b042dc

recipe-roller authored Mar 16, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/f605e5c0bc2e748170ca851383cb552c7225316b [doc/recipes.py] allow both json and text proto forms of recipes.cfg. (iannucci@chromium.org)

TBR=iannucci@chromium.org

Change-Id: I3ab97f1a88e615562040ff3e4dce1d9aef60ac78
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/456020
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

63b042dc

15 Mar, 2017 10 commits

git_cache.py: Don't bootstrap from Google storage for unrecognized repos. · 3beabd0a

Ryan Tseng authored Mar 15, 2017

Also - Turn on GC for the unrecognized repos.

BUG=skia:6241
TEST=local
  git_cache.py populate with chromium and non-chromium repo.

Change-Id: I100d3665e317b29c5b3f69b49c165ce88cd019d6
Reviewed-on: https://chromium-review.googlesource.com/455979
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

3beabd0a

git-cl patch: set metadata before (failing to) apply patch · d343c635

Aaron Gable authored Mar 15, 2017

If the commit or cherry-pick command fails, git automatically drops
the user into a state where they can try to manually fix it. That's
great. But with the old call order, it would also leave the metadata
unset. This sets the issue and patchset number before doing the
potentially-failing heavy lifting, so that the branch will be in a
consistent state after the user finishes fixing up the failed command.

BUG=701130

Change-Id: I792b9fb9e61ba62626c19aa1837d21f8cd8f594e
Reviewed-on: https://chromium-review.googlesource.com/456039Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

d343c635

Roll recipe dependencies (trivial). · 837cb3ae

recipe-roller authored Mar 15, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/dc075187dabcbce22eb8449410ddaf25740614b9 step: return copy of objects from context (phajdan.jr@chromium.org)

TBR=iannucci@chromium.org

Change-Id: Ifb4db7a6bd2cf1d047480348645e92614adce58d
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/455440
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

837cb3ae

Roll recipe dependencies (trivial). · 33ed18bc

recipe-roller authored Mar 15, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/c34687df04be337cbf2fdce8e3438e647584f9a0 [doc] add entries for known items. (iannucci@chromium.org)

TBR=iannucci@chromium.org

Change-Id: I4c636e868a606b93b680adb6d68ac099e8312638
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/455997
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

33ed18bc

Roll recipe dependencies (trivial). · 31f0605a

recipe-roller authored Mar 15, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/8f704e2ae965ba1aea901c6ee15bf28319fecd83 [doc] Rewrite doc command to produce structured proto directly from python ast. (iannucci@chromium.org)

TBR=iannucci@chromium.org

Change-Id: Idefcac96d647ce0a0cb6465c4be58da0d6b6310c
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/455383
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

31f0605a

Workaround Python Issue 26083 in upload.py · edfd7cd8

Aaron Gable authored Mar 15, 2017

This issue is fixed in Python 2.7.12, but we don't guarantee
that we use that version everywhere. The root issue is that,
on certain platforms (e.g. Mac), the exception indicating that
the underlying command (e.g. 'hg') was not found is too large,
and loading the pickle representing the exception fails.

This CL catches this specific exception and treats it identically
to the OS properly raising a 'command not found' code.

BUG=699173

Change-Id: I0483ab0d1d0b6a3dfcfd26f2d9644817b5b5284f
Reviewed-on: https://chromium-review.googlesource.com/455537Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

edfd7cd8

git cl creds-check: add pretty printing of existing creds. · 34924cd4

Andrii Shyshkalov authored Mar 15, 2017

BUG=689543

Change-Id: I085f3e086059ecf3b57a8e0cd0d716adc54f8644
Reviewed-on: https://chromium-review.googlesource.com/454816
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>

34924cd4

git-cl: Make 'failed to add as cc' message less scary · b7cb65a5

Aaron Gable authored Mar 14, 2017

BUG=665263

Change-Id: If72f3e5369ea0df170916c353be5188167c7aecb
Reviewed-on: https://chromium-review.googlesource.com/454977Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

b7cb65a5

git cl creds-check: refactor gitcookies methods into a class. · 517948b6

Andrii Shyshkalov authored Mar 15, 2017

There will be many other methods that will need to share state.

BUG=689543
R=machenbach@chromium.org

Change-Id: I4ce6fe173ff7c92e57737417c65125156606a664
Reviewed-on: https://chromium-review.googlesource.com/455780
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>

517948b6

Add `git cl creds-check` to clean Git/Gerrit creds interactively. · 353637c5

Andrii Shyshkalov authored Mar 14, 2017

BUG=689543

Change-Id: I0ba24c46f36c505fae03aaeab3b277e80bca8f8b
Reviewed-on: https://chromium-review.googlesource.com/454696Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

353637c5

14 Mar, 2017 7 commits

Manually roll recipes. · 8e89fa3d

Robert Iannucci authored Mar 14, 2017

recipe_engine:
https://crrev.com/222e52d54fd4816863099034b25b6f74e0e1a06a [package.proto] upgrade to proto3. (iannucci@chromium.org)
https://crrev.com/70340d7caa58896cbcffcccbc5573dd3b488fc5d [doc/recipes.py] proto3 omits empty fields. (iannucci@chromium.org)
https://crrev.com/286c6f5ec8db26ee88eae1bd30855a9f3d0cf426 [doc/recipes.py] protobuf is a dict of lists. (iannucci@chromium.org)
https://crrev.com/78c57c5d69a38ef3db86d9763d539383f98714e6 [doc/recipes.py] Make recipes.py 80-cols. (iannucci@chromium.org)

BUG=

Change-Id: I4c5c9e94e9c64d14ccf0048f1aa392148b5f01c8
Reviewed-on: https://chromium-review.googlesource.com/454888
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Daniel Jacques <dnj@chromium.org>

8e89fa3d

Bump cipd client version. · d3f950b9

Vadim Shtayura authored Mar 13, 2017

New version skips unnecessary hash check for files that are already
in the cache.

R=iannucci@chromium.org
BUG=

Change-Id: Icdbd1d171fa77cf7e353c84e82ded8eafd88c88d
Reviewed-on: https://chromium-review.googlesource.com/454241Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

d3f950b9

Roll recipe dependencies (nontrivial). · 6aac92db

recipe-roller authored Mar 14, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must CQ the change manually.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/9fdd6d725d8d04125d43ce2be4f5e4b123f705be [json] improve output to get leak_to and better logging. (iannucci@chromium.org)

R=iannucci@chromium.org

Change-Id: Icf48ce2f5211e98b48d794a172be107562cf3b25
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/455056
Commit-Queue: <recipe-roller@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

6aac92db

git cl: refactor common user interactions. · abc26ac0

Andrii Shyshkalov authored Mar 14, 2017

R=machenbach@chromium.org
BUG=

Change-Id: Id3e3fe6223a875d997ac5569137db270818a08f4
Reviewed-on: https://chromium-review.googlesource.com/453439
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>

abc26ac0

Roll recipe dependencies (nontrivial). · ce4ebd07

recipe-roller authored Mar 14, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must CQ the change manually.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/05a33f9dcf2289bbaf233fcae1e2fb508d95f528 Record infra_step in recipe expectations (phajdan.jr@chromium.org)

R=phajdan.jr@chromium.org

Change-Id: Ic1202d82b7bb4376976c1b4989cbbd7d26d7c531
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/454341
Commit-Queue: <recipe-roller@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

ce4ebd07

Roll recipe dependencies (trivial). · ef3e07d9

recipe-roller authored Mar 14, 2017

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/2606a110184a3effca282bc1dbed36ee790872bb [doc] add methods to emit proto from Config objects (iannucci@chromium.org)

TBR=iannucci@chromium.org

Change-Id: Ia661948b7a41100beecbf6965c2df5393197c5e3
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Reviewed-on: https://chromium-review.googlesource.com/454339
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org>

ef3e07d9

[recipe_modules/cipd] Refactor creation methods. · 85b6d185

Robert Iannucci authored Mar 14, 2017

This clarifies what the 'create' method actually expects,
and adds a nicer approach for recipes that want to synthesize
their own package definition files.

BUG=

Change-Id: Iee5d5c02260bf71d4775ddfc1d4d1ae43937b693
Reviewed-on: https://chromium-review.googlesource.com/440385
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

85b6d185