BUG=337921
TEST=local

Review URL: https://codereview.chromium.org/155413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@248821 0039d316-1c4b-4281-b951-d872f2087c98

R=iannucci@chromium.org
BUG=323300

Review URL: https://codereview.chromium.org/144823003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@248786 0039d316-1c4b-4281-b951-d872f2087c98

Use the source root (src/ in Chromium) rather than the checkout root as
the path from which to locate the clang-format binaries.

webrtc uses the Chromium build/tools infrastructure but doesn't have
src/ as a source root path. This change allows us to continue to use
'git cl format' in a standalone webrtc checkout (which would be nice.)

BUG=240309
TESTED='git cl format' works on a trivial test change in both a
Chromium and webrtc checkout.

Review URL: https://codereview.chromium.org/135653014

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@248651 0039d316-1c4b-4281-b951-d872f2087c98

And for now, defaults to Express.

Main changes:
- Valid hash becomes a set of hashes one for Pro, one for Express
- Include WDK to get an old copy of ATL as that doesn't come
  with Express

BUG=323300
R=maruel@chromium.org

Review URL: https://codereview.chromium.org/148453008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@248622 0039d316-1c4b-4281-b951-d872f2087c98

(It's a bit unfortunate that we're duplicating the default -regex list in
clang-format-diff.py here :-/ But the .js and .proto stuff is probably not
quite ready yet anyhow, so I'm only adding .mm for now.)

TEST=Edit a .mm file, commit, run `git cl format`, `git diff` shows formatted
output.
TBR=iannucci@chromium.org

Review URL: https://codereview.chromium.org/152303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@248424 0039d316-1c4b-4281-b951-d872f2087c98

BUG=240309
TBR=iannucci@chromium.org

Review URL: https://codereview.chromium.org/139693006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@248420 0039d316-1c4b-4281-b951-d872f2087c98

urllib.urlopen() has issues with proxies similar to the ones reported in bug
134165 that are not present in urllib2.urlopen() -- namely, it does not
perform HTTP tunneling with proxy servers when fetching HTTPS URLs.

TEST=Pass --url=https://someurl to trychange.py behind a corporate proxy
R=maruel@chromium.org,iannucci@chromium.org,dpranke@chromium.org
BUG=

Review URL: https://codereview.chromium.org/133933007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@247914 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/143903006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@247723 0039d316-1c4b-4281-b951-d872f2087c98

TBR=iannucci@chromium.org
R=iannucci@google.com

Review URL: https://codereview.chromium.org/148523009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@247469 0039d316-1c4b-4281-b951-d872f2087c98

VS2013 isos are mirrored to gs://chrome-wintoolchain/ (which is googler-
only accessible). This is used to isolate bots from external dependency
as detected by CHROME_HEADLESS=1 in the environment.

TBR=iannucci@chromium.org
R=hinoka@chromium.org
BUG=324987

Review URL: https://codereview.chromium.org/148613003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@247398 0039d316-1c4b-4281-b951-d872f2087c98

It looked like the bypass_prodaccess flag wasn't passed in all the way to
where it needed to be, causing it to be set to True by default at some point,
which caused the prodaccess path to never happen.  This change takes the flag
and brings it all of the way.

BUG=337972

Review URL: https://codereview.chromium.org/147443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@247049 0039d316-1c4b-4281-b951-d872f2087c98

Merge ALL the things!

BUG=none

Review URL: https://codereview.chromium.org/61823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@246575 0039d316-1c4b-4281-b951-d872f2087c98

Tens of crickets suddenly cried out, and were suddenly silenced.

R=cjhopman@chromium.org, cmp@chromium.org, enne@chromium.org, cjhopman, cmp, enne, szager

Review URL: https://codereview.chromium.org/137373004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@246193 0039d316-1c4b-4281-b951-d872f2087c98

For simplicity, the canned presubmit check just calls git cl format
directly with a new option --dry-run which does not change the files on
disk.

Because some users may not have git or clang-format might somehow have
errors, this canned check is a warning.  Additionally, if git cl format
fails with an error then the presubmit check will silently report
success to avoid spamming misconfigured users during upload.

BUG=none

Review URL: https://codereview.chromium.org/141493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@246066 0039d316-1c4b-4281-b951-d872f2087c98

This is necessary so that Cygwin users have a python directory in depot_tools/,
which will soon be used by gyp_chromium.

BUG=335180

Review URL: https://codereview.chromium.org/141523009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@245704 0039d316-1c4b-4281-b951-d872f2087c98

BUG=240309
TEST='git cl format' and 'git cl format --full' indent by 4 when run inside of third_party/WebKit
TBR=iannucci@chromium.org

Review URL: https://codereview.chromium.org/136333010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@245694 0039d316-1c4b-4281-b951-d872f2087c98

A very common pattern for the users of this script is to have binaries in
three different folders, eg:
some/folder/win/bin.exe
some/folder/mac/bin
some/folder/linux/bin

Instead of using --platform to specify three different paths, we can recognize
this usage and pass in --auto_platform, and then --directory some/folder/ as the
target.

When enumerating files, it will match each individual file to see if they have
(win|mac|linux) as a parent folder name, and filter out non-matching platforms.

BUG=
TEST= src/third_party/clang_format/bin$ download_from_google_storage --auto_platform --no_auth -b chromium-clang-fomat -dr .
0> Downloading ./linux/clang-format...

Review URL: https://codereview.chromium.org/126893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@245643 0039d316-1c4b-4281-b951-d872f2087c98

Revert of If the destination directory doesn't contain the desired repo, delete it (https://codereview.chromium.org/61623008/)

Reason for revert:
This breaks `gclient sync` for me. Before this patch:
________ found .git directory; skipping src

After this patch:
Error: 1> Can't update/checkout /Volumes/MacintoshHD2/src/chrome-git/src if an unversioned directory is present. Delete the directory and try again.


Original issue's description:
> If the destination directory doesn't contain the desired repo, delete it
> 
> Basic functionality - this may not be in quite the right place.
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=245404

TBR=iannucci@chromium.org,ilevy@chromium.org,cmp@chromium.org,maruel@chromium.org,morrita@chromium.org,borenet@google.com
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/141633005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@245530 0039d316-1c4b-4281-b951-d872f2087c98

As a slight improvement for making changes on Windows, at least run
the pylint steps. The tests do not currently work with a variety of
failures, but at least running pylint would have caught the regressions
encountered here https://codereview.chromium.org/134313007/#msg19.

R=maruel@chromium.org
BUG=334953

Review URL: https://codereview.chromium.org/137243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@245420 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334114

Review URL: https://codereview.chromium.org/136863007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@245414 0039d316-1c4b-4281-b951-d872f2087c98

Basic functionality - this may not be in quite the right place.

Review URL: https://codereview.chromium.org/61623008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@245404 0039d316-1c4b-4281-b951-d872f2087c98

By default, if loasd is not running, loas_check retries twice, waiting 5 seconds between retries. This is in case loasd is restarting due to reinstallation. Unfortunately, if the user has never run prodaccess, this check takes an extra 10 seconds. So, just disable the retries.

BUG=

Review URL: https://codereview.chromium.org/137853024

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@245399 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Fetch Windows tools on Cygwin and use that Python for some scripts (https://codereview.chromium.org/140843004/)

Reason for revert:
This broke auto-updating depot_tools on Cygwin due to use of exec

Original issue's description:
> Fetch Windows tools on Cygwin and use that Python for some scripts
> 
> Tested by running gclient sync a couple of times from a Cygwin shell.
> 
> R=dpranke@chromium.org
> CC=scottmg@chromium.org,thakis@chromium.org,maruel@chromium.org
> BUG=335180
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=245315

TBR=dpranke@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=335180

Review URL: https://codereview.chromium.org/132883007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@245330 0039d316-1c4b-4281-b951-d872f2087c98

It stays resident, so try to tidy up, otherwise removing the old
directory will fail.

TBR=maruel@chromium.org
BUG=323300

Review URL: https://codereview.chromium.org/140883005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@245324 0039d316-1c4b-4281-b951-d872f2087c98

Tested by running gclient sync a couple of times from a Cygwin shell.

R=dpranke@chromium.org
CC=scottmg@chromium.org,thakis@chromium.org,maruel@chromium.org
BUG=335180

Review URL: https://codereview.chromium.org/140843004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@245315 0039d316-1c4b-4281-b951-d872f2087c98

R=maruel@chromium.org, jochen@chromium.org
BUG=321187

Review URL: https://codereview.chromium.org/137613003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@245311 0039d316-1c4b-4281-b951-d872f2087c98

R=phadjan@chromium.org
BUG=

Review URL: https://codereview.chromium.org/132803004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@245272 0039d316-1c4b-4281-b951-d872f2087c98

To try it out, do 
. $DEPOT_TOOLS/gclient_completion.sh

Review URL: https://codereview.chromium.org/100463007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@245134 0039d316-1c4b-4281-b951-d872f2087c98

as part of the Chromium checkout.

This follows the approach used by gn.

Changes include:
 - in-the-PATH clang-format trampoline scripts
 - clang_format.py, which finds clang-format binaries inside of Chrome
 - Hook 'git cl format' to the new binaries and scripts
 - Rearrange some code, for reuse between clang_format.py and gn.py

BUG=240309
TEST=presubmits (one failure on mac, but it fails on a clean checkout too)

Review URL: https://codereview.chromium.org/134313007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@245074 0039d316-1c4b-4281-b951-d872f2087c98

No functionality change.

TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/136793018

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@245073 0039d316-1c4b-4281-b951-d872f2087c98

Per comments in linked bug, this is simply moved from chromium. The
only new thing is hooking it into update_depot_tools.bat, and
updating a few paths in the scripts.

This is currently opt-in via "set DEPOT_TOOLS_WIN_TOOLCHAIN=1" but
that will be removed once it's ready for deployment.

R=iannucci@chromium.org, maruel@chromium.org
BUG=323300

Review URL: https://codereview.chromium.org/135933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@244983 0039d316-1c4b-4281-b951-d872f2087c98

This change will allow projects other than chromium to specify 'BUG_PREFIX: project_name:' in their codereview.settings file.
Currently, the change is created with 'BUG=', entering a project's bug number there will point it to chromium's issue tracker. Adding a project specific prefix will make the links point to the project's issue tracker without the developer having to know about the magic prefix.

BUG=skia:1983

Review URL: https://codereview.chromium.org/132233006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@244801 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=iannucci@chromium.org,maruel@chromium.org

Review URL: https://codereview.chromium.org/130803004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@244793 0039d316-1c4b-4281-b951-d872f2087c98

Write a small HowTo to help confused people by confusing checks.

R=iannucci@chromium.org
BUG=

Review URL: https://codereview.chromium.org/137653003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@244717 0039d316-1c4b-4281-b951-d872f2087c98

With the addition of this method, rietveld.py can be used to create cli-based tools to review Chromium code.

BUG=none

Review URL: https://codereview.chromium.org/127083003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@244529 0039d316-1c4b-4281-b951-d872f2087c98

When download_from_google_storage --config is run, it should be implied that
the user just wants to download, not upload.  This change passes the '-r' flag
into gsutil config, which requests a read-only scoped token rather than write
token.  This is saved in ~/.boto.depot_tools so that it doesn't conflict
with a ~/.boto file crated later that may have write permissions.


BUG=

Review URL: https://codereview.chromium.org/135153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@244276 0039d316-1c4b-4281-b951-d872f2087c98

Passing the email address used to connect to Rietveld on the command
line is useful for testing purposes, in particular with a test server.

BUG=331123

Review URL: https://codereview.chromium.org/122583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@244017 0039d316-1c4b-4281-b951-d872f2087c98

It takes more than 10 seconds to lint some CLs. Silently
ignore the expected timeout.

R=maruel@chromium.org,iannucci@chromium.org
BUG=290402
TEST=none

Review URL: https://codereview.chromium.org/130493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@243968 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=local
R=agable@chromium.org

Review URL: https://codereview.chromium.org/128403007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@243697 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332101
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/126143004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@243436 0039d316-1c4b-4281-b951-d872f2087c98