- 22 Dec, 2009 2 commits
-
-
maruel@chromium.org authored
Do a review comment I forgot to apply in a previous change. TEST=none Review URL: http://codereview.chromium.org/508012 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35124 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Fix standalone trychange usage on both svn and git. Remove implicit dependency on git-cl. TEST=unit test Review URL: http://codereview.chromium.org/507061 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35121 0039d316-1c4b-4281-b951-d872f2087c98
-
- 20 Dec, 2009 2 commits
-
-
maruel@chromium.org authored
TEST=unit tests Review URL: http://codereview.chromium.org/503068 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35072 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Remove upload dependency. This is towards making trychange.py work mostly standalone for the webkit try server. TEST=unit tests and tested both gcl try and git-try. Review URL: http://codereview.chromium.org/501143 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35071 0039d316-1c4b-4281-b951-d872f2087c98
-
- 19 Dec, 2009 2 commits
-
-
maruel@chromium.org authored
This is to reduce trychange.py dependency on gcl.py Review URL: http://codereview.chromium.org/502085 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35055 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
TEST=unit tests Review URL: http://codereview.chromium.org/502078 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35052 0039d316-1c4b-4281-b951-d872f2087c98
-
- 18 Dec, 2009 5 commits
-
-
laforge@chromium.org authored
Fix the author search for branches (only an issue on reverts), looking at trunk w/ the revision won't tell you the correct author. Review URL: http://codereview.chromium.org/505053 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35009 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Review URL: http://codereview.chromium.org/502075 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34984 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Review URL: http://codereview.chromium.org/501106 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34950 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Review URL: http://codereview.chromium.org/502066 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34949 0039d316-1c4b-4281-b951-d872f2087c98
-
laforge@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34897 0039d316-1c4b-4281-b951-d872f2087c98
-
- 17 Dec, 2009 2 commits
-
-
laforge@chromium.org authored
Review URL: http://codereview.chromium.org/505042 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34895 0039d316-1c4b-4281-b951-d872f2087c98
-
laforge@chromium.org authored
Review URL: http://codereview.chromium.org/501081 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34894 0039d316-1c4b-4281-b951-d872f2087c98
-
- 15 Dec, 2009 1 commit
-
-
msb@chromium.org authored
Doing something like basename when concatenating base_url with relative url. Added use_relative_urls2 to enable switching between old implementation and new implementation. Once the old implementation is deprecated we can remove the use_relative_urls2. Review URL: http://codereview.chromium.org/500015 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34563 0039d316-1c4b-4281-b951-d872f2087c98
-
- 14 Dec, 2009 2 commits
-
-
jrg@chromium.org authored
Review URL: http://codereview.chromium.org/504002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34500 0039d316-1c4b-4281-b951-d872f2087c98
-
msb@chromium.org authored
When a rebase generates a conflict, report an error and exit immediately. If in an existing conflict (no branch), report an error and exit immediately. Review URL: http://codereview.chromium.org/496003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34459 0039d316-1c4b-4281-b951-d872f2087c98
-
- 12 Dec, 2009 1 commit
-
-
msb@chromium.org authored
Review URL: http://codereview.chromium.org/486045 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34415 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 Dec, 2009 3 commits
-
-
msb@chromium.org authored
Review URL: http://codereview.chromium.org/495003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34392 0039d316-1c4b-4281-b951-d872f2087c98
-
msb@chromium.org authored
Review URL: http://codereview.chromium.org/486036 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34386 0039d316-1c4b-4281-b951-d872f2087c98
-
msb@chromium.org authored
Review URL: http://codereview.chromium.org/490021 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34377 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Dec, 2009 1 commit
-
-
maruel@chromium.org authored
Review URL: http://codereview.chromium.org/474002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34166 0039d316-1c4b-4281-b951-d872f2087c98
-
- 08 Dec, 2009 3 commits
-
-
maruel@chromium.org authored
Review URL: http://codereview.chromium.org/465128 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34087 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
It is much cleaner and works for cases where the directory is not writeable. Also fix an unrelated unit test. Review URL: http://codereview.chromium.org/464068 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34080 0039d316-1c4b-4281-b951-d872f2087c98
-
chase@chromium.org authored
BUG=none TEST=git cl upload sets watchlist extracc on rietveld issues Review URL: http://codereview.chromium.org/460125 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34078 0039d316-1c4b-4281-b951-d872f2087c98
-
- 03 Dec, 2009 6 commits
-
-
jrg@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@33716 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Add a warning message in case the check ever fail. Review URL: http://codereview.chromium.org/460044 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@33700 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Review URL: http://codereview.chromium.org/462022 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@33686 0039d316-1c4b-4281-b951-d872f2087c98
-
mnaganov@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/458017 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@33683 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Client-side implementation. TODO: Need to automatically disable it for unit tests. Review URL: http://codereview.chromium.org/444009 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@33681 0039d316-1c4b-4281-b951-d872f2087c98
-
dpranke@google.com authored
the behavior before I started messing with it. It turns out it's not worth the hassle to try and "clean this up"; we depend on the current convoluted semantics, which is to crawl up the tree from the current dir looking for codereview.settings files, but to only ever look for PRESUBMIT.py in the root of the repo. Trying to unify the logic seems to be too painful. BUG=none R=maruel@chromium.org TEST=none Review URL: http://codereview.chromium.org/387067 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@33648 0039d316-1c4b-4281-b951-d872f2087c98
-
- 02 Dec, 2009 1 commit
-
-
maruel@chromium.org authored
It is necessary for webkit build slaves. Review URL: http://codereview.chromium.org/460023 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@33601 0039d316-1c4b-4281-b951-d872f2087c98
-
- 01 Dec, 2009 1 commit
-
-
estade@chromium.org authored
Review URL: http://codereview.chromium.org/456008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@33390 0039d316-1c4b-4281-b951-d872f2087c98
-
- 25 Nov, 2009 2 commits
-
-
msb@chromium.org authored
gclient sync will potentially fail if the upstream git tree has been rebased. This CL fixes this by using rebase --onto to only rebase our local changes. Review URL: http://codereview.chromium.org/432017 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@33011 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Review URL: http://codereview.chromium.org/436036 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@33005 0039d316-1c4b-4281-b951-d872f2087c98
-
- 24 Nov, 2009 3 commits
-
-
chase@chromium.org authored
On a new Linux box, during git cl dcommit I observed the error: fatal: invalid diff option/value: -r This was caused by the git cl presubmit hooks running: git diff --name-status -r refs/remotes/origin/trunk.. /path/to/src By passing a relative path (given by git rev-parse --show-cdup) instead of an absolute path for /path/to/src, git diff --name-status does not print an error and returns the expected list of changed files. Also fix some broken scm and gclient_scm unit tests. BUG=none TEST=git presubmit hooks work from main working directory Review URL: http://codereview.chromium.org/438012 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32999 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Review URL: http://codereview.chromium.org/437042 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32969 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Subversion's client just bails out too early too often. Review URL: http://codereview.chromium.org/437015 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32967 0039d316-1c4b-4281-b951-d872f2087c98
-
- 22 Nov, 2009 1 commit
-
-
chase@chromium.org authored
Save the CL locally prior to attempting to submit to Rietveld. The CL is saved locally with a dirty-bit before the upload is attempted. If successful, the CL is saved locally again with a clean-bit. On loading a dirty CL for editing, we only load the CL description from Rietveld if the local CL is clean (there are no pending changes to upload). Clean CLs continue to retrieve updated descriptions directly from Rietveld. BUG=none TEST=gcl change <name> saves CL description local prior to uploading. gcl change <name> after a failed Rietveld upload uses local CL description instead of using the associated issue's description from Rietveld. Changes in this state are reset to the 'clean' state after the Rietveld update completes. Review URL: http://codereview.chromium.org/428001 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32791 0039d316-1c4b-4281-b951-d872f2087c98
-
- 21 Nov, 2009 2 commits
-
-
maruel@chromium.org authored
TBR=nsylvain Review URL: http://codereview.chromium.org/430004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32748 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
TEST=not much BUG=none Review URL: http://codereview.chromium.org/399070 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32720 0039d316-1c4b-4281-b951-d872f2087c98
-