Commits · 0e405d1ac6adc90fcb7082270363d9e11758e28c · Linshizhi / Chromium_Depot_tools

17 May, 2019 3 commits

Roll recipe dependencies (trivial). · 0e405d1a

recipe-roller authored May 17, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/e7498a59f81c8fad2caf7e3d7c8ca072ec0e2494 Stringify recipe_name when executing test case. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic8792a722ae9a077dbda8012b11234ee4369ee9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1617430Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

0e405d1a

Roll recipe dependencies (trivial). · caa04a27

recipe-roller authored May 17, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/a5456c47f654f8cab699314f687a1f40aa99a3d2 Fix flaky test. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id4ee9723b1fbacb87c3831f981bb1a918c980b86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1617426Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

caa04a27

git-cl: Only display a detailed message when git-cl fails. · 5737f025

Edward Lemur authored May 17, 2019

git-cl will print the path to the collected traces and git info,
but will only display the detailed message when git-cl fails.

Bug: 961663, 955206
Change-Id: I0a4d470aba24d696bdd5e02e069833f47cf56c02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1615665
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

5737f025

15 May, 2019 6 commits

Reland "bot_update: Pass target-ref to gclient." · 99fe0713

Edward Lemur authored May 15, 2019

This is a reland of f61af569

crrev.com/c/1592577 should fix the issues with the original change.

Original change's description:
> bot_update: Pass target-ref to gclient.
>
> Bug: 956807
> Recipe-Nontrivial-Roll: infra
> Recipe-Nontrivial-Roll: skia
> Recipe-Nontrivial-Roll: build_limited_scripts_slave
> Recipe-Nontrivial-Roll: build
> Change-Id: I4d786d989446b8c1e3f39ef78c3c99cfe70808c0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1588502
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

Bug: 956807
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: skia
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: build
Change-Id: I16c22cb6aeb8e9dc1f55d77b1f12987720da3480
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1613341
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

99fe0713

Roll recipe dependencies (trivial). · abe8aefc

recipe-roller authored May 15, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/9d31f1727653888912994380e7b9c35ad9ea8380 buildbucket: Add critical to BB fieldmask (seanabraham@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Icb8e862574f95b225f3d37adafc38ef93779101a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1613928Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

abe8aefc

Roll recipe dependencies (trivial). · 1f5e810a

recipe-roller authored May 15, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/76f4351baff3376ef9920ba1a270bb502918d365 Extract diff and list subcommands from main test implementation. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia3aafef84c062142518aba6bf5b8f15ad0b2d8aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1613669Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

1f5e810a

Roll mac_toolchain to pick up -verbose. · a16f28fc

John Budorick authored May 15, 2019

Bug: 962920
Change-Id: Ib52b4fb571381352b63a83ac4c4392ba20677892
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1612291
Auto-Submit: John Budorick <jbudorick@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

a16f28fc

Delete the mojo config from the gclient recipe module. · 2d3b9260

Joey Scarr authored May 15, 2019

The repo it references is obsolete and I've been requested to delete it.

Bug: 963195
Change-Id: I4e765465950f85d4bdcb604804959ff29a00f062
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1611591Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

2d3b9260

Roll recipe dependencies (trivial). · b77f2db9

recipe-roller authored May 15, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/f4424b87ca831dbc1fb2b72af3dc94ed2666861b Change test simulation substituter to work with oddball python distributions. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia55886d9cd8ef8beefadcc42bb7bd61667eac912
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1612283Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

b77f2db9

14 May, 2019 12 commits

git-cl: Reword the message when surfacing traces to the user. · 75391d46

Edward Lemur authored May 14, 2019

In crbug.com/955206 they pointed out that:
- It's not clear when to upload the issue
- It's not clear where to report it, or where to look for existing issues.
- It's not made clear that the traces can contain information the user might not want to share.

I've reworded the message to address those concerns

Bug: 955206
Change-Id: Ia1426007d389328eac52babeee1ec3782c2b104e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1606608
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

75391d46

Roll recipe dependencies (trivial). · 74ca6920

recipe-roller authored May 14, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/cc6f5c718d9336bc98b85a820d04bdefd6dfe2b8 Improve cmd0 resolution to account for absolute base paths. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I74679ada4d06a2493c58b8c1adba5f98a8073d96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1612434Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

74ca6920

Roll recipe dependencies (trivial). · 2d37ec48

recipe-roller authored May 14, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/c262e24ab6137157a6c834fc38a127a886ba959a Extract debug command from the test subcommand. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9f2db0793179ec7ed6430ea03aa2272d3a39c800
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1612080Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

2d37ec48

Roll recipe dependencies (trivial). · e684a505

recipe-roller authored May 14, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/55fabf49b398f40fe4561f37ca5bac0eb9352e7e Move simulator stream engine to its own file. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8e11a1869ceb3a782720a14f6b4675df094fb309
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1612079Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

e684a505

Roll recipe dependencies (trivial). · 3d86f06b

recipe-roller authored May 14, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/41c54934d664b4034e5a42655a42e866f6ba8485 swarming: fix aliasing in dimensions, env_vars and env_prefixes (maruel@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I660ea4885e3f0cd20de18f9cb0d1b449bdab2a57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1612078Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

3d86f06b

Roll recipe dependencies (trivial). · 1988507c

recipe-roller authored May 14, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/b2103d4eb1f8a9380ec37299db6d0898bd014d12 Remove subprocess42 everywhere except the actual recipe step runner. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I609a73495e71a9eef7d6d1b08a3abb8ab4521d19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1611092Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

1988507c

Roll recipe dependencies (trivial). · 9f1377b7

recipe-roller authored May 14, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/2e9624d2c517e450eb2d896171d9a058d9829989 [swarming] Start exposing new containment flags (maruel@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I514e386dddb8087c9ad97c03922915dbf2e3d998
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1611089Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

9f1377b7

Roll recipe dependencies (trivial). · 468d0cc4

recipe-roller authored May 14, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/107d545f22f4f6923e46655032afb050c1945bd6 Roll swarming client (maruel@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie1e0b8463e79c650215e6fcd552835fe4397bc14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1611087Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

468d0cc4

Update colorama to 0.4.1 · 25eb8e46

Raul Tambre authored May 14, 2019

Fixes colorama unintentionally overriding multiple sys.stdout wrappers of our own.
And provides a fix for a SyntaxWarning on Python 3.8:
C:\Google\depot_tools\third_party\colorama\ansitowin32.py:43: SyntaxWarning: invalid escape sequence \[
ANSI_RE = re.compile('\033\[((?:\d|;)*)([a-zA-Z])')

Tests are updated to account for the annotation wrapper no longer being overriden.
A fix by agable for the annotation wrapper working with carriage returns is also included (https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1592612).

Bug: 958138, 958321
Change-Id: I2fe1def85c66cfe5229a1c25c2f677e498593eea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1591513Reviewed-by: Aaron Gable <agable@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Raul Tambre <raul@tambre.ee>
Auto-Submit: Raul Tambre <raul@tambre.ee>

25eb8e46

Roll recipe dependencies (trivial). · 8a964932

recipe-roller authored May 14, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/0aae08882d042675016c1f44da43457958fe8054 Treat any cmd0 containing path sep as relative. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id7fe88eec793e24dbf8ae296bc1a73732291b117
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1611213Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

8a964932

Make presubmit scripts not inherit the executor script's context · 09e64b49

Raul Tambre authored May 14, 2019

This caused compatibility issues, because the executor script (presubmit_support.py) asks the parser for Python 3-style print functions and inherits this to the presubmit scripts it runs, of which some still use the old style statements.

Bug: 961783
Change-Id: I545d778991a53f484bce6c7e29089e0484dc19ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1605917
Auto-Submit: Raul Tambre <raul@tambre.ee>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>

09e64b49

scm: Replace invalid UTF-8 in Git output · 6a9b00e4

Raul Tambre authored May 14, 2019

This may occur when git diff is ran with binary changes in the diff.
Example: https://chromium-review.googlesource.com/c/chromium/src/+/1606595

Bug: 942522
Change-Id: I44caef559de44076ef394caa5abc3967db2bb0b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1607840
Auto-Submit: Raul Tambre <raul@tambre.ee>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

6a9b00e4

13 May, 2019 7 commits

Roll recipe dependencies (trivial). · 06f5b226

recipe-roller authored May 13, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/13fa883dbdc89e258d7ef300035e4bba67bffc9f Replace paths in simulations sorted by -len. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id4b6307c79dc50c9ad52bbb72f444bae5cb0fe62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1610871Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

06f5b226

Roll recipe dependencies (nontrivial). · 70276606

recipe-roller authored May 13, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/125d102e429465dc3468b4b235f9e3a5df4b252c Reland: Refactor recipe engine step execution. (iannucci@chromium.org)


R=recipe-roller@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7736e6b20f8a7ec9d5cf9eeb21456a1d0b37f189
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1609964
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

70276606

Roll recipe dependencies (nontrivial). · 66eeedc2

recipe-roller authored May 13, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/9b3ed1d5e912b8e9195060c3401da9b5370f2fce Revert "Refactor recipe engine step execution." (iannucci@chromium.org)


R=recipe-roller@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I628d01d7a259024f677ca8fb5de7317ae9aa591f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1609960
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

66eeedc2

Roll recipe dependencies (nontrivial). · 417f2332

recipe-roller authored May 13, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/440a45cae6b329192f60313e41714bd78e886c8d Refactor recipe engine step execution. (iannucci@chromium.org)


R=recipe-roller@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6e85bbfdf2eb61a433a505f81db6b805b9231402
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1610858
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

417f2332

Roll recipe dependencies (trivial). · 7a3d1fb7

recipe-roller authored May 13, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/f34152acbe36ba6b4dc513885271cfca8838a634 Fix invalid Python file encoding "utf8" (raul@tambre.ee)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Idb7c5a135e66bb134da01d4924b94364e8fafaae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1609860Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

7a3d1fb7

Fix invalid Python file encoding "utf8" · a04028c2

Raul Tambre authored May 13, 2019

Since Python 3 it must be "utf-8", which is the official name.
This is backwards compatible with Python 2.

Bug: 962277
Change-Id: I21115a322944532f1870862c8c048f8455c1109f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1608562
Auto-Submit: Raul Tambre <raul@tambre.ee>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

a04028c2

Roll recipe dependencies (trivial). · 42db0b42

recipe-roller authored May 13, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/20932a9267873300fb27651bd9572bfbb284930c [buildbucket] Do not crash on empty input (nodir@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifb0015245bd156829ec58198ef92ef8ae2cf3397
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1609041Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

42db0b42

10 May, 2019 4 commits

gclient_scm: Decode Git output centrally for better Python 3 support · cd862e37

Raul Tambre authored May 10, 2019

This avoids the need to do the decoding everywhere separately.
Also a small fix for filter() no longer returning a list on Py3.

The scripts still work with Python 2.
There are no intended behaviour changes.

Bug: 942522
Change-Id: Id0f5153011b2ef1b64394359087864cd9434e45e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1595685
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Auto-Submit: Raul Tambre <raul@tambre.ee>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

cd862e37

do not hardcode the path to bash by using the #!/usr/bin/env bash shebang · 059f26bc

Robert Nagy authored May 10, 2019

on non-linux systems bash is not the default shell (by default) and
lives in a completely different path

Change-Id: I6580c776dda1b60b3d5c5f5f1ce4d6694ac45fe9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1605902Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

059f26bc

[bootstrap/win] Upgrade Python to 2.7.13. · 980d615e

Takuto Ikuta authored May 10, 2019

This is followup of
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/571171/

Bug: 741001
TEST: > gclient version # to update python
TEST: > .\python.bat # start python 2.7.13 correctly
Change-Id: I07e596d3006104ccb1c5fe0fde097a3c29f8a5a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1605541
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

980d615e

[lucicfg] Bump lucicfg version v1.7.2 -> v1.7.4. · 006b2955

Andrii Shyshkalov authored May 10, 2019

Knows about CQ allow_owner_if_submittable.
No API changes.

R=vadimsh

Bug: 959098
Change-Id: Icfb3e201df4916b2e8d8923d87c474af1ae85b9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1604465Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Auto-Submit: Andrii Shyshkalov <tandrii@chromium.org>

006b2955

09 May, 2019 6 commits

Roll recipe dependencies (trivial). · 4145bd87

recipe-roller authored May 09, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/842aee7058c3e87013ef8d59aef4c39fcceef507 Fix masked ImportErrors for config.py and test_api.py. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7e5584b6024a4e765d3f044ff9c2ae4613ed08ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1604124Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

4145bd87

Roll recipe dependencies (trivial). · 66ab0d69

recipe-roller authored May 09, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/90c7e6503a4950cb84a57b909bac36dd9eec595f Display scheduler input request as a log to avoid flooding the build page (sergiyb@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I804f3c4d1063078463d204837caa1b74f53936f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1603902Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

66ab0d69

Reland "git-cl: Keep git push traces" · 1b52d87a

Edward Lemur authored May 09, 2019

This is a reland of dc8e23d3

Original change's description:
> git-cl: Keep git push traces
> 
> Keep the last N git push traces.
> Name them after the time when they were collected, and add a
> README file to each one to provide some context to developers.
> 
> Bug: 955206
> Change-Id: Ib5fcf2f78fb65f6ddd80a93619c14e1ef70c5564
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1595108
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>

Bug: 955206
Change-Id: Ie63a3ebfe3024d48ad7e0c8492a2939e635371aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1600246Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

1b52d87a

Roll recipe dependencies (trivial). · 2e483122

recipe-roller authored May 09, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/5a39fa23e6c9a2dcb570f8442da6fb0cd3874a92 Remove deprecated test recipe. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I305a6d1f62be7d6d8f879c1bd06767dde3125edd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1603402Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

2e483122

Roll recipe dependencies (trivial). · 8a2a5a8d

recipe-roller authored May 09, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/f9955f78cb9fa09207e05d3d0bd93164708baacc Fix accidental regression caused by PathClient fix. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I072a89d4f0651fe521fab1627d1b7b6c1904b814
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1603025Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

8a2a5a8d

Roll recipe dependencies (trivial). · 370d193c

recipe-roller authored May 09, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/3f1ace721c34a30de9e89f8721d4d42995a2c0f0 Update documentation in recipe_test_api. (gbeaty@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7e80f4b6e1c39897605d784984510400cdce54f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1602035Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

370d193c

08 May, 2019 2 commits

Roll recipe dependencies (trivial). · 59031c4e

recipe-roller authored May 08, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/a552175dc3f1dd19da04013be850c511f111f58f Update implementation_details.md with upcoming refactor. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I05aee62d190437d31a4951cae25e15cc9a6e6566
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1601722Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

59031c4e

Roll recipe dependencies (trivial). · 43d3bb88

recipe-roller authored May 08, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/6c5f5ab7c20a45535d0c7e4ebb7527ff1d05ee53 Backport little recipe changes from the big refactor. (iannucci@chromium.org)
  https://crrev.com/89de9b614d19f40ca3659686ca4a9718cc0cbc83 Enable subsequences and/or regexes checking in a Steps's command. (gbeaty@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I537d08fc4cc43376fc68111d807c20ac98fa84a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1601719Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

43d3bb88