Commits · 091b7db64c188eb497cb2092321c11564edaf1ea · Linshizhi / Chromium_Depot_tools

16 Jun, 2016 4 commits

Expose fnmatch in presubmit's input_api. · 091b7db6
dcheng authored Jun 16, 2016
```
BUG=611905

Review-Url: https://codereview.chromium.org/2070493002
```
091b7db6

Roll recipe dependencies (trivial). · adf9f0db

recipe-roller authored Jun 16, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/a6baded1c8c7a15dd1e4020289fd19d985f58c25 add basic bootstrap for coverage (martiniss@google.com)

R=martiniss@google.com,iannucci@chromium.org,phajdan.jr@chromium.org
BUG=618709

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2075483002

adf9f0db

drover win: Use --stdin so update-index doesn't fail on long cmdline · 02056563

scottmg authored Jun 16, 2016

git update-index would fail on long command lines when setting up
a resolve. Instead of passing all the files names on the command line,
pass them through --stdin and a file handle.

BUG=598808

Review-Url: https://codereview.chromium.org/2067653002

02056563

Fix presubmit checkout test after git 2.9.0 · f3c688bf

scottmg authored Jun 16, 2016

Quoting https://github.com/blog/2188-git-2-9-has-been-released

"""Rename detection is now enabled by default for diffs..."

which broke this test.

R=tandrii@chromium.org, iannucci@chromium.org
BUG=619959

Review-Url: https://codereview.chromium.org/2073553003

f3c688bf

10 Jun, 2016 5 commits

Update message for Gerrit git cl --no-squash users. · 26f3e4ee
tandrii authored Jun 10, 2016
```
R=andybons@chromium.org
BUG=611892

Review-Url: https://codereview.chromium.org/2055233002
```
26f3e4ee
Mock stdout to avoid pollutting test runner stdout. · 1c67da67
tandrii authored Jun 10, 2016
```
TBR=kmarshall@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2055003003
```
1c67da67

Roll recipe dependencies (trivial). · ea46b886

recipe-roller authored Jun 10, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/d6fea3edecb31f2f87e8551f7ca4cdaafef731f8 convert recipe_engine/fetch to use requests HTTP library (phajdan.jr@chromium.org)

R=phajdan.jr@chromium.org
BUG=none

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2059713002

ea46b886

Roll recipe dependencies (trivial). · 97e8e559

recipe-roller authored Jun 10, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/da26a351b7034d37e55acd468fa90c8ee3a1ada0 Fix --timestamps help (nodir@chromium.org)

R=nodir@chromium.org,martiniss@chromium.org
BUG=613584

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2059593002

97e8e559

Roll recipe dependencies (trivial). · d139d55f

recipe-roller authored Jun 10, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/02bd5642786bd00b6060404bf8c459e6cc146c4c Emit CURRENT_TIMESTAMP annotation (nodir@chromium.org)

R=iannucci@chromium.org,nodir@chromium.org,martiniss@chromium.org
BUG=613584

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2056113002

d139d55f

09 Jun, 2016 5 commits

git cl upload: commit subject is default patchset title · 7aafc3f4

nodir authored Jun 09, 2016

git cl upload asks the user to provide a patchset title.
If the user makes a commit per patchset, the subject of the commit may
be exactly what patchset title should be.

R=dnj@chromium.org, vadimsh@chromium.org
BUG=582419

Review-Url: https://codereview.chromium.org/1868313002

7aafc3f4

Use different exit code when desired dep roll is a no-op · 7036c4f0
smut authored Jun 09, 2016
```
BUG=609899

Review-Url: https://codereview.chromium.org/2047013005
```
7036c4f0

Reland: git_cache.py: Clobber git repos if the config is corrupt · dcd84048

hinoka authored Jun 09, 2016

Reland of: https://codereview.chromium.org/2049463003/

See https://build.chromium.org/p/tryserver.chromium.win/builders/win10_chromium_x64_rel_ng_exp/builds/1801/steps/bot_update/logs/stdio
[Mirror] https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.win%2Fwin10_chromium_x64_rel_ng_exp%2F1801%2F%2B%2Frecipes%2Fsteps%2Fbot_update%2F0%2Fstdout

Sometimes repos become corrupt and bot_update fails spectacularly.  This usually happens due to the process being interrupted during a fetch. Git
cache should be able to recover from this by clobbering.

BUG=

Review-Url: https://codereview.chromium.org/2045243004

dcd84048

Roll recipe dependencies (trivial). · faa493b2

recipe-roller authored Jun 09, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/9bd80bed8e2c252d85333afeb15e4ae6446390c5 fix package help (martiniss@chromium.org)

R=martiniss@chromium.org
BUG=

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2057753003

faa493b2

Roll recipe dependencies (trivial). · 7bb9cf7c

recipe-roller authored Jun 09, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/e4cd3d7622993438df62de4b827d8900ee0b74e5 remote_run: resolve revision for consistent results from gitiles (phajdan.jr@chromium.org)

R=phajdan.jr@chromium.org
BUG=chromium:459840

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2050613004

7bb9cf7c

08 Jun, 2016 3 commits

Add resource locking in gclient · 885e5b1e

hinoka authored Jun 08, 2016

There are entries in the DEPS file where two folders uses the same
git URL (ie. freetype2).  This doesn't work well with git caches because
each task will run on it's own and might try to clobber on top of each other.

This adds another field in a WorkItem which is a list of resources.  When the
work queue is flushed, it has to make sure that none of a newly added workitem
has any resource conflicts.

BUG=618124

Review-Url: https://codereview.chromium.org/2049583003

885e5b1e

Update the VS toolchain hash computation caching. · e9013dbe

sebmarchand authored Jun 08, 2016

R=hans@chromium.org, scottmg@chromium.org
BUG=495204

Review-Url: https://codereview.chromium.org/2052533002

e9013dbe

Roll recipe dependencies (trivial). · f10bcf32

recipe-roller authored Jun 08, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/4a775357939492af14f32fb92ac85c30f97c5d2f Delete duplicate test (nodir@chromium.org)

R=iannucci@chromium.org,nodir@chromium.org,martiniss@chromium.org
BUG=

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2047393002

f10bcf32

07 Jun, 2016 6 commits

Revert of git_cache.py: Clobber git repos if the config is corrupt (patchset... · 0f4ee819

sergeyberezin authored Jun 07, 2016

Revert of git_cache.py: Clobber git repos if the config is corrupt (patchset #4 id:60001 of https://codereview.chromium.org/2031773002/ )

Reason for revert:
Suspected to break builds: http://crbug.com/618124

Original issue's description:
> git_cache.py: Clobber git repos if the config is corrupt
>
> See https://build.chromium.org/p/tryserver.chromium.win/builders/win10_chromium_x64_rel_ng_exp/builds/1801/steps/bot_update/logs/stdio
> [Mirror] https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.win%2Fwin10_chromium_x64_rel_ng_exp%2F1801%2F%2B%2Frecipes%2Fsteps%2Fbot_update%2F0%2Fstdout
>
> Sometimes repos become corrupt and bot_update fails spectacularly.  This usually happens due to the process being interrupted during a fetch. Git
> cache should be able to recover from this by clobbering.
>
> BUG=
>
> Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/b48b126ffd2d43e8fa7897c8174e2688e113af4d

TBR=estaab@chromium.org,phajdan.jr@chromium.org,hinoka@google.com,hinoka@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2049463003

0f4ee819

git_cache.py: Clobber git repos if the config is corrupt · b48b126f

hinoka authored Jun 07, 2016

See https://build.chromium.org/p/tryserver.chromium.win/builders/win10_chromium_x64_rel_ng_exp/builds/1801/steps/bot_update/logs/stdio
[Mirror] https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.win%2Fwin10_chromium_x64_rel_ng_exp%2F1801%2F%2B%2Frecipes%2Fsteps%2Fbot_update%2F0%2Fstdout

Sometimes repos become corrupt and bot_update fails spectacularly.  This usually happens due to the process being interrupted during a fetch. Git
cache should be able to recover from this by clobbering.

BUG=

Review-Url: https://codereview.chromium.org/2031773002

b48b126f

[depot_tools] Add gendered pronoun presubmit check. · 0b67044c
seanmccullough authored Jun 07, 2016
```
Review-Url: https://codereview.chromium.org/2046003002
```
0b67044c
Gerrit git cl upload: warn and offer to remove Gerrit commit-msg hook. · 16e0b4e2
tandrii authored Jun 07, 2016
```
R=andybons@chromium.org,sergiyb@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2045973002
```
16e0b4e2
git cl try: clarify where the default set of bots is coming from. · b93dd2b2
tandrii authored Jun 07, 2016
```
R=sergiyb@chromium.org,dsinclair@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2044663003
```
b93dd2b2

Add "archive" command to git_cl.py. · 3bff56bb

kmarshall authored Jun 07, 2016

This command archives branches whose Rietveldt status is closed by
creating new Git tags for each of the branches' heads, and then
deleting the branch. It automatically cleans up the clutter that
accumulates over time in a long-lived Git checkout.

For example, the branch "foo-bar" associated with the
closed issue 1568403002 will be archived to the tag
"git-cl-archived-1568403002-foo-bar".

BUG=616404
R=martiniss@chromium.org,tandrii@chromium.org

Review-Url: https://codereview.chromium.org/1991563005

3bff56bb

06 Jun, 2016 4 commits

Small change to test the new git CQ · 208c0539

agable authored Jun 06, 2016

R=sergeyberezin@chromium.org
BUG=600446

Review-Url: https://codereview.chromium.org/2046763002

208c0539

Edit codereview.settings and cq.cfg for Git · 8c321122

Aaron Gable authored Jun 06, 2016

R=sergeyberezin@chromium.org
TBR=tandrii@chromium.org
BUG=600446

Review URL: https://codereview.chromium.org/2041123002 .

8c321122

Make "vs_toolchain.py update" work on case-sensitive file systems · b380ad83

hans@chromium.org authored Jun 06, 2016

Filenames must have their case preserved so the files can be opened,
but they need to be lowercased when hashed and sorted, to match the
expected hash.

In other words, this patch moves the lower-casing from GetFileList
(except to sort the list) to where filenames are fed into the hash.

BUG=495204

Review-Url: https://codereview.chromium.org/2039563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300696 0039d316-1c4b-4281-b951-d872f2087c98

b380ad83

depot_tools: expose paths to presubmit_support.py and upload_to_google_storage.py · 166ac05c

phajdan.jr@chromium.org authored Jun 06, 2016

They're needed by infra recipes (https://codereview.chromium.org/2045493002).

BUG=617565

Review-Url: https://codereview.chromium.org/2045473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300695 0039d316-1c4b-4281-b951-d872f2087c98

166ac05c

03 Jun, 2016 5 commits

Revert of Gerrit git cl: temporary disable cc option on upload. (patchset #1... · 074c2afe

tandrii@chromium.org authored Jun 03, 2016

Revert of Gerrit git cl: temporary disable cc option on upload. (patchset #1 id:1 of https://codereview.chromium.org/1895863002/ )

Reason for revert:
We've whitelisted cc-ed emails in Gerrit, and so let's try setting cc= again.

Original issue's description:
> Gerrit git cl: temporary disable cc option on upload.
> 
> Gerrit doesn't allow arbitrary non-member emails for now,
> thus removign this feature until either Gerrit allows it,
> or we have a per-repo opt-in way.
> 
> TBR=andybons@chromium.org
> BUG=604377
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299988

TBR=andybons@chromium.org,sergiyb@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=604377

Review-Url: https://codereview.chromium.org/2034143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300694 0039d316-1c4b-4281-b951-d872f2087c98

074c2afe

Roll recipe dependencies (trivial). · d389f5c5

recipe-roller@chromium.org authored Jun 03, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/a2f99b57a04aea317bc02bb10ab570e1dc337218 recipe engine: implement basic fetch from gitiles for remote_run (phajdan.jr@chromium.org)

R=phajdan.jr@chromium.org
BUG=chromium:459840

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2036203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300693 0039d316-1c4b-4281-b951-d872f2087c98

d389f5c5

git cl description: avoid appending BUG= after Change-Id. · 601e1d17

tandrii@chromium.org authored Jun 03, 2016

R=yyanagisawa@chromium.org,sergiyb@chromium.org
BUG=614587

Review-Url: https://codereview.chromium.org/2038673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300692 0039d316-1c4b-4281-b951-d872f2087c98

601e1d17

Refactor git_footers for later use in git cl. · f2aa52b5

tandrii@chromium.org authored Jun 03, 2016

Motivation: git_cl should start understanding Gerrit's git footers,
to avoid appending BUG= after Change-Id: Ixxx line.

R=sergiyb@chromium.org
BUG=614587

Review-Url: https://codereview.chromium.org/2028303006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300691 0039d316-1c4b-4281-b951-d872f2087c98

f2aa52b5

git cl desc: add test that shows BUG= breaking Change-Id footer. · d605a51c

tandrii@chromium.org authored Jun 03, 2016

BUG=614587
R=yyanagisawa@chromium.org,andybons@chromium.org

Review-Url: https://codereview.chromium.org/2033783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300690 0039d316-1c4b-4281-b951-d872f2087c98

d605a51c

02 Jun, 2016 1 commit

Add a configuration to fetch "ios_internal" project. · 9f3b3f06

sdefresne@chromium.org authored Jun 02, 2016

This allow using "fetch ios_internal" to setup a repository for Chrome
on iOS (this still requires being a Google employee as this fetch a
private downstream repository).

The repository URL was already public as it is in every public bug that
is linked from a downstream CL, e.g. http://crbug.com/459705#c115.

BUG=None

Review-Url: https://codereview.chromium.org/2028413004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300689 0039d316-1c4b-4281-b951-d872f2087c98

9f3b3f06

01 Jun, 2016 3 commits

Add 'catapult' to gclient config to enable trybots. · c2a88544

dpranke@chromium.org authored Jun 01, 2016

With this change, we can run chromium tryjobs for changes to catapult.

R=tandrii@chromium.org, nednguyen@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2030623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300688 0039d316-1c4b-4281-b951-d872f2087c98

c2a88544

git cl issue 0 should really clear issue. · 9b7fd71c

tandrii@chromium.org authored Jun 01, 2016

It used to clear just issue number and patchset, but that's not
all state that associates a given branch with codereview site.

R=andybons@chromium.org
BUG=609295

Review-Url: https://codereview.chromium.org/2032433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300683 0039d316-1c4b-4281-b951-d872f2087c98

9b7fd71c

Roll recipe dependencies (trivial). · 3b558a01

recipe-roller@chromium.org authored Jun 01, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/1e96cf67820c1e8c81719df758895a8258ae8ac8 cleanup: remove RepoUpdate class (phajdan.jr@chromium.org)

R=phajdan.jr@chromium.org
BUG=none

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2026263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300682 0039d316-1c4b-4281-b951-d872f2087c98

3b558a01

31 May, 2016 4 commits

Fix & refactor git cl patch. · c2786d93

tandrii@chromium.org authored May 31, 2016

* Fixes a bug when issue was incorrectly over-written
  in another branch. Add a test case.
* Refactor for better flow.
* Update outdated errors on wrong arguments.

BUG=616105
R=andybons@chromium.org,sergiyb@chromium.org

Review-Url: https://codereview.chromium.org/2022183003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300681 0039d316-1c4b-4281-b951-d872f2087c98

c2786d93

Roll recipe dependencies (trivial). · 904727e4

recipe-roller@chromium.org authored May 31, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/9262aad64311ff326e911dcfafd257bf4d082436 doc: General improvements. (martiniss@chromium.org)

R=martiniss@chromium.org
BUG=

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2020263003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300680 0039d316-1c4b-4281-b951-d872f2087c98

904727e4

Roll recipe dependencies (trivial). · 60807258

recipe-roller@chromium.org authored May 31, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/afdd33be7384ba93833d598c45d9c9daff9f165a splitlines instead of split() (martiniss@chromium.org)

R=martiniss@chromium.org
BUG=

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2022023003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300679 0039d316-1c4b-4281-b951-d872f2087c98

60807258

Roll recipe dependencies (trivial). · d5ef390f

recipe-roller@chromium.org authored May 31, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/2f6d406d090b102b15e5e3ac6704a70054d381aa recipes.py: Print failure reason, if given. (martiniss@chromium.org)

R=martiniss@chromium.org
BUG=

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2025013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300678 0039d316-1c4b-4281-b951-d872f2087c98

d5ef390f