R=hinoka@chromium.org
BUG=472386

Review-Url: https://codereview.chromium.org/2280213002

R=agable@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2319903002

Revert of Require recipe tryjob in CQ (patchset #1 id:1 of https://codereview.chromium.org/2157503003/ )

Reason for revert:
Downstream tester messed up now, see https://crbug.com/644609

Original issue's description:
> Require recipe tryjob in CQ
>
> BUG=628801
>
> Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/ac74456f1e697f38598cda9b1c1acedb80702c7a

TBR=phajdan.jr@chromium.org,estaab@chromium.org,iannucci@chromium.org
NOTRY=true
(no try because the tester itself is broken)
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=628801, 644609

Review-Url: https://codereview.chromium.org/2322763002

BUG=612417

Review-Url: https://codereview.chromium.org/2317213002

R=martiniss@chromium.org
BUG=640251

Review-Url: https://codereview.chromium.org/2318843002

R=hinoka@chromium.org, martiniss@chromium.org, tandrii@chromium.org
BUG=643885

Review-Url: https://codereview.chromium.org/2310113003

This makes it so that regardless of what force is set to in the recipe, if you
invoke bot_update.ensure_checkout, it will actually run.

Removal of the force option (and related options) to come shortly.

R=estaab@chromium.org, hinoka@chromium.org, martiniss@chromium.org, tandrii@chromium.org
BUG=643885

Review-Url: https://codereview.chromium.org/2311673002

This CL just contains spelling changes, a minor rewording, and addition of backticks for commands.

Review-Url: https://codereview.chromium.org/2296393003

BUG=

Review-Url: https://codereview.chromium.org/2304393002

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/b79776cf2fbb4822372bbc03ee9a44318c23af8c Add more information to the README.md (martiniss@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2308003003

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/11cda51b49aeaa3d56af70eb138ea28eabdd16bd Implement simple step whitelisting in recipe_engine. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=459361

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2308883002

Currently, if one edits one's local CL description (e.g., `git commit
--amend`), there is no path for that update to get pushed to Rietveld.
This adds a "+" sentinel to the "-n" flag for `git cl description` that
tells it to load description content from the local commit.

The description should match what would be generated by "git cl upload".

BUG=None
TEST=local

Review-Url: https://codereview.chromium.org/2307463002

R=machenbach@chromium.org,andybons@chromium.org
BUG=602906
TEST=manual run of Angle recipe locally

Review-Url: https://codereview.chromium.org/2299693003

For use in scripts that check try job results, this is
currently practically the same as making requests to
https://codereview.chromium.org/api/<cl-number>/<patchset-number>.

However, I think that this might be more future-proof, since
it fetches try job information from Buildbucket, and I expect
to still work after migration from Rietveld to Gerrit.

BUG=640354

Review-Url: https://codereview.chromium.org/2274743003

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/6ac56ce6c1693f924a5e1efaef28c792c3ce1052 Warn if no valid SSL python libraries installed (martiniss@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2299233002

Can't just let the GC collect the pool on Windows.

R=tandrii@chromium.org
BUG=618726

Review-Url: https://codereview.chromium.org/2296723006

BUG=602906
R=tandrii@chromium.org

Recipe-Tryjob-Bypass-Reason: tandrii@ takes responsibility.
Review-Url: https://codereview.chromium.org/2298883002

Additions:
  * Remove PYTHONUNBUFFERED for svn tests

This obviates https://codereview.chromium.org/2298863002/.

recipe_engine:
  https://crrev.com/09345f9dcf4d2744f66d64766fd349ddf04f04ce Cancel PYTHONUNBUFFERED when unbuffered is explicitly set to False (iannucci@chromium.org)

TBR=martiniss@chromium.org, phajdan.jr@chromium.org
BUG=635641

Review-Url: https://codereview.chromium.org/2298893002

Revert of It's time to bring subprocess42 to depot_tools. (patchset #1 id:1 of https://codereview.chromium.org/2291223003/ )

Reason for revert:
Speculative revert because it might be breaking presubmit in depot_tools.

Original issue's description:
> It's time to bring subprocess42 to depot_tools.
>
> The immediate need is to properly kill git fetch and its sub-spawned
> process from gclient.
>
> R=maruel@chromium.org, hinoka@chromium.org
> BUG=635641
>
> Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/6d3c290164360907fe08784093e36314069e689f

TBR=hinoka@chromium.org,maruel@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=635641

Review-Url: https://codereview.chromium.org/2295043003

The immediate need is to properly kill git fetch and its sub-spawned
process from gclient.

R=maruel@chromium.org, hinoka@chromium.org
BUG=635641

Review URL: https://codereview.chromium.org/2291223003 .

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/a93ebc8b69c18bce873f4df1979b6534f3c13e68 Organize environment whitelist, add PYTHONUNBUFFERED. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=635641

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2290293004

Also spits out whatever output was produced by git fetch for debugging.

BUG=635641
R=machenbach@chromium.org,hinoka@chromium.org

Review-Url: https://codereview.chromium.org/2293013002

Reason for revert:
Still in use. Breaks the v8 auto-rollers.

https://cs.chromium.org/search/?q=roll-dep-svn&sq=package:chromium&type=cs

Original issue's description:
> Delete roll-dep-svn
>
> R=dnj@chromium.org
> BUG=475320
>
> Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/96ebc1d0e100021990312072e6eda6b8a0a81ee5

TBR=dnj@chromium.org,agable@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=475320

Review-Url: https://codereview.chromium.org/2297513002

R=martiniss@google.com
BUG=640251
Recipe-Tryjob-Bypass-Reason: can't mock expectation changes downstream

Review-Url: https://codereview.chromium.org/2285213004

The URL helper functions were only used by this file,
the svn custom_deps urls aren't referenced in any DEPS
files I can find anymore, and the oilpan and buildspec
configs aren't used by any recipes.

R=hinoka@chromium.org
BUG=640251

Review-Url: https://codereview.chromium.org/2291583003

Review-Url: https://codereview.chromium.org/2285393002

R=dnj@chromium.org
BUG=475320

Review-Url: https://codereview.chromium.org/2282223002

BUG=641384
R=phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2293523002

BUG=635421, 629679
R=tandrii@chromium.org

Review URL: https://codereview.chromium.org/2286333002 .

R=andybons@chromium.org
BUG=641127

Review-Url: https://codereview.chromium.org/2280563003

BUG=640251,472386

Review-Url: https://codereview.chromium.org/2286793003

BUG=

Review-Url: https://codereview.chromium.org/2283043002

BUG=635421, 629679

Review-Url: https://codereview.chromium.org/2280973002

This provides env variable GCLIENT_KILL_GIT_FETCH_AFTER
that kills git fetch if it produces no output for that
many seconds.

Note that this is not final patch, but an experiment.
See http://crbug.com/635641#c24 for the deployment plan.

BUG=635641
R=hinoka@chromium.org

Review-Url: https://codereview.chromium.org/2241843002

Also contains some other changes (to the example, and to safesync url)
in order for test coverage to remain complete. Will be followed shortly
by a wholesale removal of svn support from the gclient module.

R=iannucci@chromium.org
BUG=640251

Review-Url: https://codereview.chromium.org/2270083004

R=tandrii@chromium.org
BUG=638750

Review-Url: https://codereview.chromium.org/2271873003

These tools are relatively standalone, and only ever worked for SVN.
Removing these is a good start to removing other SVN support code.

R=maruel@chromium.org
BUG=475321

Review-Url: https://codereview.chromium.org/2269413002

This should only change spelling in:
 - messages that are printed
 - comments
 - docstrings

Review-Url: https://codereview.chromium.org/2277513002

I know this is an unimportant change, and that across Chromium,
"try job" and "tryjob", and "try bot" and "trybot" are basically
interchangeable, still I think it's nice to have the spelling
consistent within one module.

I prefer the version with a space just because that's what's used
in the documentation:
https://www.chromium.org/developers/testing/try-server-usage

Review-Url: https://codereview.chromium.org/2269283002

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/b9c3996241af9c5b0d60c0e7670897ecc3894e46 Fix recipes.py remote on Windows (phajdan.jr@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=chromium:639891,chromium:584079

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2271803003