Revert of Gerrit git cl: temporary disable cc option on upload. (patchset #1 id:1 of https://codereview.chromium.org/1895863002/ )

Reason for revert:
We've whitelisted cc-ed emails in Gerrit, and so let's try setting cc= again.

Original issue's description:
> Gerrit git cl: temporary disable cc option on upload.
> 
> Gerrit doesn't allow arbitrary non-member emails for now,
> thus removign this feature until either Gerrit allows it,
> or we have a per-repo opt-in way.
> 
> TBR=andybons@chromium.org
> BUG=604377
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299988

TBR=andybons@chromium.org,sergiyb@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=604377

Review-Url: https://codereview.chromium.org/2034143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300694 0039d316-1c4b-4281-b951-d872f2087c98

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/a2f99b57a04aea317bc02bb10ab570e1dc337218 recipe engine: implement basic fetch from gitiles for remote_run (phajdan.jr@chromium.org)

R=phajdan.jr@chromium.org
BUG=chromium:459840

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2036203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300693 0039d316-1c4b-4281-b951-d872f2087c98

R=yyanagisawa@chromium.org,sergiyb@chromium.org
BUG=614587

Review-Url: https://codereview.chromium.org/2038673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300692 0039d316-1c4b-4281-b951-d872f2087c98

Motivation: git_cl should start understanding Gerrit's git footers,
to avoid appending BUG= after Change-Id: Ixxx line.

R=sergiyb@chromium.org
BUG=614587

Review-Url: https://codereview.chromium.org/2028303006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300691 0039d316-1c4b-4281-b951-d872f2087c98

BUG=614587
R=yyanagisawa@chromium.org,andybons@chromium.org

Review-Url: https://codereview.chromium.org/2033783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300690 0039d316-1c4b-4281-b951-d872f2087c98

This allow using "fetch ios_internal" to setup a repository for Chrome
on iOS (this still requires being a Google employee as this fetch a
private downstream repository).

The repository URL was already public as it is in every public bug that
is linked from a downstream CL, e.g. http://crbug.com/459705#c115.

BUG=None

Review-Url: https://codereview.chromium.org/2028413004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300689 0039d316-1c4b-4281-b951-d872f2087c98

With this change, we can run chromium tryjobs for changes to catapult.

R=tandrii@chromium.org, nednguyen@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2030623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300688 0039d316-1c4b-4281-b951-d872f2087c98

It used to clear just issue number and patchset, but that's not
all state that associates a given branch with codereview site.

R=andybons@chromium.org
BUG=609295

Review-Url: https://codereview.chromium.org/2032433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300683 0039d316-1c4b-4281-b951-d872f2087c98

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/1e96cf67820c1e8c81719df758895a8258ae8ac8 cleanup: remove RepoUpdate class (phajdan.jr@chromium.org)

R=phajdan.jr@chromium.org
BUG=none

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2026263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300682 0039d316-1c4b-4281-b951-d872f2087c98

* Fixes a bug when issue was incorrectly over-written
  in another branch. Add a test case.
* Refactor for better flow.
* Update outdated errors on wrong arguments.

BUG=616105
R=andybons@chromium.org,sergiyb@chromium.org

Review-Url: https://codereview.chromium.org/2022183003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300681 0039d316-1c4b-4281-b951-d872f2087c98

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/9262aad64311ff326e911dcfafd257bf4d082436 doc: General improvements. (martiniss@chromium.org)

R=martiniss@chromium.org
BUG=

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2020263003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300680 0039d316-1c4b-4281-b951-d872f2087c98

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/afdd33be7384ba93833d598c45d9c9daff9f165a splitlines instead of split() (martiniss@chromium.org)

R=martiniss@chromium.org
BUG=

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2022023003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300679 0039d316-1c4b-4281-b951-d872f2087c98

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/2f6d406d090b102b15e5e3ac6704a70054d381aa recipes.py: Print failure reason, if given. (martiniss@chromium.org)

R=martiniss@chromium.org
BUG=

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2025013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300678 0039d316-1c4b-4281-b951-d872f2087c98

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/47cfb999ef50c26fcf01063541a9ed3f4bf360ab Change recipes license to apache 2. (estaab@chromium.org)

R=estaab@chromium.org
BUG=

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2027693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300677 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review-Url: https://codereview.chromium.org/2020173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300676 0039d316-1c4b-4281-b951-d872f2087c98

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/b76dc167624445da05e8450fa96c04e139c69989 Add estaab to recipes-py OWNERS. (estaab@chromium.org)

R=estaab@chromium.org
BUG=

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2022953003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300675 0039d316-1c4b-4281-b951-d872f2087c98

Otherwise, the program continues, and an exception is printed.
The message is still there, but easy to miss.

R=andybons@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2004303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300674 0039d316-1c4b-4281-b951-d872f2087c98

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300132

Review-Url: https://codereview.chromium.org/1893563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300673 0039d316-1c4b-4281-b951-d872f2087c98

The change in https://codereview.chromium.org/1982243002
didn't take into account that the script runs on the actual
bot OS, so Windows will have backslashes as dir separators.

BUG=438952

Review-Url: https://codereview.chromium.org/2021783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300672 0039d316-1c4b-4281-b951-d872f2087c98

BUG=591814
TEST=gclient sync prints the correct report locally
when config is wrong.

Review-Url: https://codereview.chromium.org/2018803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300671 0039d316-1c4b-4281-b951-d872f2087c98

Cherry-pick https://codereview.chromium.org/2000403004/ to depot_tools's
bot_update.py

R=hinoka@chromium.org
BUG=613641

Review-Url: https://codereview.chromium.org/2022453003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300670 0039d316-1c4b-4281-b951-d872f2087c98

R=sheyang@chromium.org
BUG=600028

Review URL: https://codereview.chromium.org/2015423002 .

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300669 0039d316-1c4b-4281-b951-d872f2087c98

Manual land of https://chromiumcodereview.appspot.com/2009173002/ due to CQ
lineending issues.

AUTHOR=techtonik@gmail.com
R=phajdan.jr@chromium.org, techtonik@gmail.com, dpranke@chromium.org
BUG=

Review URL: https://codereview.chromium.org/2015673002 .

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300668 0039d316-1c4b-4281-b951-d872f2087c98

The old hammer entry points and use of scons for chromium is long gone.
Dropping it.

BUG=None
TEST=None
R=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2016053004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300667 0039d316-1c4b-4281-b951-d872f2087c98

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/6d74949d4e37b74c6cccb254b2a57cbc22cabfc3 recipe engine: add YAML file for a CIPD package (phajdan.jr@chromium.org)

R=phajdan.jr@chromium.org
BUG=chromium:459840

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2022443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300666 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium:459840

Review-Url: https://codereview.chromium.org/2017843003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300665 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nodir@chromium.org
BUG=600028

Review URL: https://codereview.chromium.org/2010573004 .

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300664 0039d316-1c4b-4281-b951-d872f2087c98

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/68ad74bd9cb97cf110b5d6457ffac8c2861ad1b6 recipe engine: add remote_run command (phajdan.jr@chromium.org)

R=phajdan.jr@chromium.org
BUG=chromium:459840

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2008173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300663 0039d316-1c4b-4281-b951-d872f2087c98

Previously, git cl upload would send email every time.
This CL changes that to send email only if -s or --send-mail is given.

R=andybons@chromium.org
BUG=612728

Review-Url: https://codereview.chromium.org/2007873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300662 0039d316-1c4b-4281-b951-d872f2087c98

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/57ddcf7e783c42d00574fa17caf0324c1c48e0a2 Set SEM_FAILCRITICALERRORS as well. (iannucci@chromium.org)

R=dpranke@chromium.org,iannucci@chromium.org,martiniss@chromium.org,tansell@chromium.org
BUG=522396

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2007673005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300661 0039d316-1c4b-4281-b951-d872f2087c98

R=iannucci@chromium.org
BUG=600446

Review URL: https://codereview.chromium.org/2000913002 .

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300660 0039d316-1c4b-4281-b951-d872f2087c98

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/f85bf76a1d01a131f2d8d52da9c5494de7e37c57 Assert backing file is not None (martiniss@chromium.org)

R=martiniss@chromium.org
BUG=

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2000373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300659 0039d316-1c4b-4281-b951-d872f2087c98

Lets you get CL tags for a given CL.

BUG=591172

Review-Url: https://codereview.chromium.org/1915833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300658 0039d316-1c4b-4281-b951-d872f2087c98

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/0617526e048a61e76599cc8588bf79ebae6369b6 Update links to build_limited (agable@chromium.org)

R=agable@chromium.org,sergiyb@chromium.org,iannucci@chromium.org
BUG=600447

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/1998123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300657 0039d316-1c4b-4281-b951-d872f2087c98

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/671f0dd829393735af5b1bd369ea41823bbd8edf recipe engine: remove previous roll implementation in favor of autoroll (phajdan.jr@chromium.org)

R=phajdan.jr@chromium.org
BUG=583303

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/1995883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300644 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sergiyb@chromium.org
BUG=612414

Review-Url: https://codereview.chromium.org/1980323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300621 0039d316-1c4b-4281-b951-d872f2087c98

The --extra_patchlevel flag was added in
https://codereview.chromium.org/1988583002/

In order to make it possible for WebRTC patches to apply in
src/third_party/webrtc of a Chromium checkout, one directory
level needs to be trimmed.

BUG=438952, 611808

Review-Url: https://codereview.chromium.org/1982243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300618 0039d316-1c4b-4281-b951-d872f2087c98

'git apply' works on Git indexes, so it's not possible
to apply a patch to src/third_party/webrtc with cwd=src/third_party.
Instead, set the cwd to the correct dir and add an extra patch
level using the new flag in https://codereview.chromium.org/1988583002/

This essentially reverts https://codereview.chromium.org/1977373002/
+ sets the project path correctly to src/third_party/webrtc.

BUG=438952

Review-Url: https://codereview.chromium.org/1984993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300616 0039d316-1c4b-4281-b951-d872f2087c98

This will make it possible to cut away additional
levels of directories when applying patches from repos
that have a different directory hierarchy than Chromium.

BUG=438952
TESTED=Executed successfully in a local checkout using
(cwd was the dir above src/):
~/depot_tools/apply_issue.py --root_dir src/third_party/webrtc --issue 1978193002 --server https://codereview.webrtc.org --force --ignore_deps -v -v --no-auth --patchset 20001 --extra_patchlevel=1

Review-Url: https://codereview.chromium.org/1988583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300615 0039d316-1c4b-4281-b951-d872f2087c98

R=benhenry@google.com, agable@chromium.org, benhenry@chromium.org
BUG=609891

Review URL: https://codereview.chromium.org/1981143002 .

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300608 0039d316-1c4b-4281-b951-d872f2087c98