- 09 Jun, 2014 2 commits
-
-
szager@chromium.org authored
Usage: roll-dep third_party/WebKit 12345 That will update DEPS with the new revision, and leave the DEPS file dirty. It's the up to the user to 'git add; git commit; git cl upload'. This script won't handle arbitrary python syntax, but it will handle variable references like Var("webkit_revision") correctly. R=mmoss@chromium.org, iannucci@chromium.org BUG=341098 Review URL: https://codereview.chromium.org/318153003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@275875 0039d316-1c4b-4281-b951-d872f2087c98
-
hinoka@chromium.org authored
BUG=261741,380958 Review URL: https://codereview.chromium.org/325903005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@275872 0039d316-1c4b-4281-b951-d872f2087c98
-
- 05 Jun, 2014 4 commits
-
-
hinoka@chromium.org authored
boto is required. BUG=261741 TBR=iannucci Review URL: https://codereview.chromium.org/315343002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@275244 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
BUG=131061 Review URL: https://codereview.chromium.org/319673003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@275235 0039d316-1c4b-4281-b951-d872f2087c98
-
hinoka@chromium.org authored
Last patch (https://codereview.chromium.org/313933005/) forgot to take into account using a boto file (setting boto to os.devnull means connect unauthenticated, setting it to None will allow it to do the default behavior) This patch will always use a boto file, which should be fine. BUG=261741 Review URL: https://codereview.chromium.org/314203002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@275230 0039d316-1c4b-4281-b951-d872f2087c98
-
hinoka@chromium.org authored
BUG=261741 Review URL: https://codereview.chromium.org/313933005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@274969 0039d316-1c4b-4281-b951-d872f2087c98
-
- 04 Jun, 2014 1 commit
-
-
avakulenko@google.com authored
The only difference compared to upstream[1] is the shebang line from depot_tools. [1] https://code.google.com/p/google-styleguide/source/browse/trunk/cpplint/cpplint.py?spec=svn131&r=133 BUG=None Review URL: https://codereview.chromium.org/317053002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@274946 0039d316-1c4b-4281-b951-d872f2087c98
-
- 03 Jun, 2014 1 commit
-
-
pgervais@chromium.org authored
'Add a description' is not enough to know what the test is about. Added some more info. BUG= Review URL: https://codereview.chromium.org/313523002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@274393 0039d316-1c4b-4281-b951-d872f2087c98
-
- 02 Jun, 2014 3 commits
-
-
iannucci@chromium.org authored
The previous rollout pushed the xp version of chromium git v4 to windows7. This rollout pushes the correct windows 7 version. R=mmoss@chromium.org, szager@chromium.org BUG= Review URL: https://codereview.chromium.org/311713002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@274363 0039d316-1c4b-4281-b951-d872f2087c98
-
mmoss@chromium.org authored
This will avoid errors where _Clone is called for a new DEP, but where the DEP refers to a branch commit, thus causing the clone to fail because it can't checkout that commit (such as happens currently with 'fetch v8'). Review URL: https://codereview.chromium.org/307223006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@274347 0039d316-1c4b-4281-b951-d872f2087c98
-
r.c.ladan@gmail.com authored
Invoke the bash shell via /usr/bin/env so that these scripts run on operating systems without /bin/bash too. TEST=run "git cl owners" on FreeBSD BUG= Review URL: https://codereview.chromium.org/197213008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@274320 0039d316-1c4b-4281-b951-d872f2087c98
-
- 30 May, 2014 3 commits
-
-
thestig@chromium.org authored
Review URL: https://codereview.chromium.org/293153004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@273852 0039d316-1c4b-4281-b951-d872f2087c98
-
pgervais@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/268543013 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@273851 0039d316-1c4b-4281-b951-d872f2087c98
-
romain.pokrzywka@gmail.com authored
This allows having a git repo cloned on a specific branch or commit, similar to what's possible for svn solutions by specifying a url like svnrepo/branches/foo Having the possibility to check the code out on a specific branch makes the initial code checkout workflow simpler, and allows specifying all the relevant info directly in the fetch recipe, instead of having to deal with branches manually afterwards (which is the whole purpose of recipes in the first place) So with this change, I'm able to do the following in my custom fetch recipe: solution = { 'name' : 'src', 'url' : 'git@github.snei.sony.com:SNEI/chromium.git@refs/heads/custombranch', <following lines skipped> Review URL: https://codereview.chromium.org/289863012 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@273675 0039d316-1c4b-4281-b951-d872f2087c98
-
- 29 May, 2014 1 commit
-
-
szager@chromium.org authored
This makes it possible to effectively re-route the stdout by re-assigning sys.stdout. BUG= Review URL: https://codereview.chromium.org/303223005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@273595 0039d316-1c4b-4281-b951-d872f2087c98
-
- 27 May, 2014 1 commit
-
-
szager@chromium.org authored
BUG=376546 R=mmoss@chromium.org,agable@chromium.org Review URL: https://codereview.chromium.org/293113005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@273002 0039d316-1c4b-4281-b951-d872f2087c98
-
- 23 May, 2014 1 commit
-
-
szager@chromium.org authored
This is need, e.g., to suppress logging message for 'exists'. TBR=agable@chromium.org,hinoka@chromium.org BUG= Review URL: https://codereview.chromium.org/299163002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@272450 0039d316-1c4b-4281-b951-d872f2087c98
-
- 22 May, 2014 2 commits
-
-
nodir@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@272343 0039d316-1c4b-4281-b951-d872f2087c98
-
iannucci@chromium.org authored
R=agable@chromium.org, mmoss@chromium.org, szager@chromium.org BUG=366925 Review URL: https://codereview.chromium.org/288863004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@272033 0039d316-1c4b-4281-b951-d872f2087c98
-
- 20 May, 2014 1 commit
-
-
szager@chromium.org authored
Currently, only top-level solutions may be pinned via --revision. With this, we can: gclient sync --revision src/third_party/WebKit@deadbeef BUG= Review URL: https://codereview.chromium.org/290443003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@271571 0039d316-1c4b-4281-b951-d872f2087c98
-
- 16 May, 2014 2 commits
-
-
iannucci@chromium.org authored
This should let the base marker transparently work with plain-old-git tools which was the idea in the first place. Specifically `git branch -u` without a corresponding rebase. R=agable@chromium.org BUG=373977 Review URL: https://codereview.chromium.org/288323002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@271112 0039d316-1c4b-4281-b951-d872f2087c98
-
bauerb@chromium.org authored
BUG=374121 Review URL: https://codereview.chromium.org/284113005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@270972 0039d316-1c4b-4281-b951-d872f2087c98
-
- 15 May, 2014 4 commits
-
-
https://codereview.chromium.org/271703010/sheyang@chromium.org authored
Reason for revert: CQ rejects all chromium projects because of this change. Original issue's description: > use canonical base URL for projects > > BUG=372645 > R=iannucci@chromium.org, sergeyberezin@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270460 TBR=iannucci@chromium.org,sergeyberezin@chromium.org NOTREECHECKS=true NOTRY=true BUG=372645 Review URL: https://codereview.chromium.org/287063002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@270803 0039d316-1c4b-4281-b951-d872f2087c98
-
iannucci@chromium.org authored
R=agable@chromium.org BUG= Review URL: https://codereview.chromium.org/288123003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@270572 0039d316-1c4b-4281-b951-d872f2087c98
-
agable@chromium.org authored
This method is necessary to allow good code organization (i.e., unittests live adjacent to the source files they test) in the new infra.git repository. R=maruel@chromium.org Review URL: https://codereview.chromium.org/281013002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@270564 0039d316-1c4b-4281-b951-d872f2087c98
-
hinoka@chromium.org authored
BUG=261741 Review URL: https://codereview.chromium.org/278043005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@270542 0039d316-1c4b-4281-b951-d872f2087c98
-
- 14 May, 2014 2 commits
-
-
nodir@chromium.org authored
Should use e.message instead of e.reason, where e is an Exception git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@270473 0039d316-1c4b-4281-b951-d872f2087c98
-
sheyang@google.com authored
BUG=372645 R=iannucci@chromium.org, sergeyberezin@chromium.org Review URL: https://codereview.chromium.org/271703010 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@270460 0039d316-1c4b-4281-b951-d872f2087c98
-
- 13 May, 2014 3 commits
-
-
szager@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/278103002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@270205 0039d316-1c4b-4281-b951-d872f2087c98
-
borenet@google.com authored
This occurs for svn checkouts when the DEPS change from: third_party/skia/gyp third_party/skia/include third_party/skia/src to: third_party/skia First, gclient deletes/moves third_party/skia to make room for the new checkout. When finished, it notices that the three subdirectories under skia are now "unversioned" according to .gclient_entries, even though they are part of Skia repo. On the bots, this causes them to be deleted. There is a check to determine whether the thought-to-be unversioned directories are actually subdirectories of another checkout, but it doesn't work in the svn case because the check assumes that, if they are subdirectories of another checkout, it must be an svn checkout. scm.GetCheckoutRoot() returns None because it can't find an svn checkout containing those subdirectories. None is not in gclient_entries, so the directories get deleted. BUG= Review URL: https://codereview.chromium.org/275103009 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@270133 0039d316-1c4b-4281-b951-d872f2087c98
-
nodir@chromium.org authored
Some users interpreted Tryjob=+1 as "passed a try job", so renaming this one Assuming will never rename again. R=kmg@chromium.org BUG=369665 Review URL: https://codereview.chromium.org/275383003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@270011 0039d316-1c4b-4281-b951-d872f2087c98
-
- 12 May, 2014 1 commit
-
-
nodir@chromium.org authored
gerrit_util raises GerritAuthenticationError with a nice message suggesting to check the .netrc file. R=szager@chromium.org, vadimsh@chromium.org BUG=369512 Review URL: https://codereview.chromium.org/278203002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@269865 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 May, 2014 1 commit
-
-
iannucci@chromium.org authored
R=agable@chromium.org BUG= Review URL: https://codereview.chromium.org/277003002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@269661 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 May, 2014 5 commits
-
-
hinoka@chromium.org authored
The contract for apply_patch is that it applies a patch on top of something, and it either all applies cleanly or it fails. The something that is applied on can be as clean or dirty without having apply_patch judge. The particular failure condition was that we want to patch DEPS first (into the index), do some stuff, then apply another patch on top of that. Apply_patch was failing because it saw that there was a DEPS in the index already when it wasn't expecting one. A fix that could've also worked is to run git diff --staged before applying the patch, then subtract that list from found_files, but it still gets tricky then because what if you want to apply an independent patch on top of an already patched index? Because apply_patch shouldn't need to be in the business of keeping track of what the state of everything is like before and after a patch (That's up to the patch application), the better thing would be to remove the assert alltogether, and rely on "git apply" to complain if something doesn't apply. BUG=370503 TBR=iannucci Review URL: https://codereview.chromium.org/280023004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@269526 0039d316-1c4b-4281-b951-d872f2087c98
-
hinoka@chromium.org authored
For a bot_update Git world, we don't really want to commit patches. Instead we just want to leave them unstaged. BUG=370503 Review URL: https://codereview.chromium.org/280063003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@269489 0039d316-1c4b-4281-b951-d872f2087c98
-
hinoka@chromium.org authored
Revert of Have apply_patch.py/checkout.py stage git patches instead of committing them (https://codereview.chromium.org/273543002/) Reason for revert: Borked all the tryjobs due to missing --base_ref, needed to land with https://codereview.chromium.org/273543002/ Original issue's description: > Have apply_patch.py/checkout.py stage git patches instead of committing them > > For a bot_update Git world, we don't really want to commit patches. Instead > we just want to leave them unstaged. > > BUG=370503 > TEST=ran locally with and without flag > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=269468 TBR=maruel@chromium.org,agable@chromium.org,hinoka@google.com,iannucci@chromium.org NOTREECHECKS=true NOTRY=true BUG=370503 Review URL: https://codereview.chromium.org/271283003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@269482 0039d316-1c4b-4281-b951-d872f2087c98
-
hinoka@chromium.org authored
Reland of https://codereview.chromium.org/268373003/ with a fix (wraps the url with str()) https://codereview.chromium.org/268393002/ (bot_update root@revision support) is dependent on this BUG=370503 TEST= gclient sync --output-json ~/tmp/asdfasdf.json on both an SVN and Git checkout Review URL: https://codereview.chromium.org/277553002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@269469 0039d316-1c4b-4281-b951-d872f2087c98
-
hinoka@chromium.org authored
For a bot_update Git world, we don't really want to commit patches. Instead we just want to leave them unstaged. BUG=370503 TEST=ran locally with and without flag Review URL: https://codereview.chromium.org/273543002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@269468 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 May, 2014 1 commit
-
-
raphael.kubo.da.costa@intel.com authored
The only difference compared to upstream[1] is the shebang line from depot_tools r136603. [1] https://code.google.com/p/google-styleguide/source/browse/trunk/cpplint/cpplint.py?spec=svn131&r=119 R=maruel@chromium.org BUG= Review URL: https://codereview.chromium.org/269013009 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@269187 0039d316-1c4b-4281-b951-d872f2087c98
-
- 08 May, 2014 1 commit
-
-
iannucci@chromium.org authored
R=mmoss@chromium.org, szager@chromium.org BUG=371421 Review URL: https://codereview.chromium.org/271983002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@269088 0039d316-1c4b-4281-b951-d872f2087c98
-