Commits · 03ee2d619043c4bacf6b17c4d5cfb3cd607026be · Linshizhi / Chromium_Depot_tools

08 Dec, 2018 2 commits

[recipes] Manually roll recipes. · 03ee2d61

Robert Iannucci authored Dec 08, 2018

This commit changes the layout of recipe_engine a bit which breaks the
autoroller.

R=jchinlee@chromium.org, martiniss@chromium.org, tandrii@chromium.org

Bug: 913102
Change-Id: I207e6e5a13980e3819c2b4deb3c01c38c28ed876
Recipe-Manual-Change: infra
Recipe-Manual-Change: build
Recipe-Manual-Change: skia
Recipe-Manual-Change: skiabuildbot
Recipe-Manual-Change: build_limited_scripts_slave
Recipe-Manual-Change: release_scripts
Reviewed-on: https://chromium-review.googlesource.com/c/1368410
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>

03ee2d61

[metrics] Use unicode box-drawing chars and goo.gl link instead · f6a8ae76

Elliott Friedman authored Dec 08, 2018

┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
┃      METRICS COLLECTION IS TAKING PLACE           ┃
┃                                                   ┃
┃ To suppress this message opt in or out using:     ┃
┃ $ gclient metrics [--opt-in] [--opt-out]          ┃
┃ For more information please see metrics.README.md ┃
┃ in your depot_tools checkout or visit             ┃
┃ https://goo.gl/yNpRDV.                            ┃
┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛

R=ehmaldonado, mmoss, tandrii

Change-Id: Iab3a5a18aa57e603c8f253f3fcbbf7f96727e003
Reviewed-on: https://chromium-review.googlesource.com/c/1368409Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Elliott Friedman <friedman@chromium.org>

f6a8ae76

07 Dec, 2018 1 commit

Roll recipe dependencies (trivial). · 4be60eeb

recipe-roller authored Dec 07, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/7bf15aaea60841beb1973a1b0ec19f3be3ec53b2 [remote] Remove remote subcommand. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie1f3ce3988abe2292f2cb9b1c42c0ad2b4746c2c
Reviewed-on: https://chromium-review.googlesource.com/c/1368924Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

4be60eeb

06 Dec, 2018 2 commits

[ninjalog] disable log upload · f94f910e

Takuto Ikuta authored Dec 06, 2018

TBR=dpranke@chromium.org
Bug: 900161
Change-Id: I5e481f04f281fddb08724fd27630a3fb926c5d1b
Reviewed-on: https://chromium-review.googlesource.com/c/1365196Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

f94f910e

[cipd] Update CIPD client to v2.2.13. · 2e002287

Vadim Shtayura authored Dec 06, 2018

This picks up the following changes:
https://chromium.googlesource.com/infra/luci/luci-go/+log/233800ef6928..d052999e151b/cipd

R=iannucci@google.com, tandrii@google.com
BUG=911229

Change-Id: I3dbe7fc2db1cae876d0acdd3f8e4299e96af9d37
Reviewed-on: https://chromium-review.googlesource.com/c/1363879Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

2e002287

05 Dec, 2018 4 commits

subprocess2: cache the string-escape codec at load time. · 9875e180

John Budorick authored Dec 05, 2018

This is a speculative fix for subprocess being unable to find
string-escape later in execution; the theory being that something
(unclear what) is interfering w/ codecs' lookup logic and that calling
lookup earlier would allow string-escape to be cached before any such
interference. See crbug.com/912292#c2 for more.

Bug: 912292
Change-Id: I0abdd394253c9a4984db7c6c81d044087edc68fd
Reviewed-on: https://chromium-review.googlesource.com/c/1363753Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

9875e180

Revert "Fix semantics of git new-branch --upstream" · 19238fc3

Clemens Hammacher authored Dec 05, 2018

This reverts commit ba83229a.

Reason for revert: After mail discussion we came to the conclusion that the old behavior makes more sense.

Original change's description:
> Fix semantics of git new-branch --upstream
> 
> Currently, the "--upstream A" option for new-branch behaves totally
> different than "--upstream_current". While "--upstream A" checks out
> branch A and then creates a new branch which tracks A,
> "--upstream_current" creates a new branch for the current HEAD and sets
> the upstream to the previously checked out branch.
> 
> As the documentation does not mention that any of the options changes
> the currently-checked-out commit (HEAD), this CL changes the semantics
> of "git new-branch --upstream A B" to be identical to "git checkout -b B
> && git branch --set-upstream-to A".
> 
> It also slightly extends the documentation to mention that in any case
> the new branch is based on HEAD.
> 
> R=iannucci@chromium.org
> 
> Change-Id: Ic335d2caf27cb6afca1b8bc5a008424c0e880fca
> Reviewed-on: https://chromium-review.googlesource.com/c/1350748
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
> Auto-Submit: Clemens Hammacher <clemensh@chromium.org>

TBR=iannucci@chromium.org,tandrii@chromium.org,clemensh@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I7463935af172f0801c7da94d2de106a02fc4c42e
Reviewed-on: https://chromium-review.googlesource.com/c/1362972Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>

19238fc3

git-cl: Set Code-Review label as a git push argument. · 687ca907

Edward Lemur authored Dec 05, 2018

Bug: 877717
Change-Id: I6541a971068aae662b086eba84448bd0769f1a09
Reviewed-on: https://chromium-review.googlesource.com/c/1362405Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

687ca907

bot_update: Check that the cache contains needed refs. · 2413f5b0

Edward Lemur authored Dec 05, 2018

Check that the cache contains the needed refs, and not only the revisions,
before attempting to checkout.

Bug: 910547
Change-Id: Ia269132421994803866065e81fc21ecd7ac206ed
Reviewed-on: https://chromium-review.googlesource.com/c/1362393Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

2413f5b0

04 Dec, 2018 3 commits

Add bypass_warnings flag to Commit Format check · f28ef988

Ryan Tseng authored Dec 04, 2018

Right now, if clang-format is broken, a CL will still pass CQ.
This adds a flag so that it will fail CQ.

Bug: 911708
Change-Id: I2c71b7bc434fc611d51f688266be6a265b80f4da
Reviewed-on: https://chromium-review.googlesource.com/c/1361560Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>

f28ef988

Fix semantics of git new-branch --upstream · ba83229a

Clemens Hammacher authored Dec 04, 2018

Currently, the "--upstream A" option for new-branch behaves totally
different than "--upstream_current". While "--upstream A" checks out
branch A and then creates a new branch which tracks A,
"--upstream_current" creates a new branch for the current HEAD and sets
the upstream to the previously checked out branch.

As the documentation does not mention that any of the options changes
the currently-checked-out commit (HEAD), this CL changes the semantics
of "git new-branch --upstream A B" to be identical to "git checkout -b B
&& git branch --set-upstream-to A".

It also slightly extends the documentation to mention that in any case
the new branch is based on HEAD.

R=iannucci@chromium.org

Change-Id: Ic335d2caf27cb6afca1b8bc5a008424c0e880fca
Reviewed-on: https://chromium-review.googlesource.com/c/1350748Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Auto-Submit: Clemens Hammacher <clemensh@chromium.org>

ba83229a

delete unused api.gerrit.get_change_destination_branch. · ffb5052e

Andrii Shyshkalov authored Dec 04, 2018

Use api.tryserver.gerrit_change_target_ref instead.
Depends on https://crrev.com/c/1359892

Change-Id: If8ec0bb262035239a1ef77093808196561050c9b
Reviewed-on: https://chromium-review.googlesource.com/c/1359794
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>

ffb5052e

03 Dec, 2018 6 commits

Add support for retry command to buildbucket.py · 64a001ef

Sergiy Belozorov authored Dec 03, 2018

R=nodir@chromium.org

Bug: 911143
Change-Id: Ia506f51687a7e4636e16746483931298dfd22027
Reviewed-on: https://chromium-review.googlesource.com/c/1356520Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org>

64a001ef

More context when _load_codereview_impl asserts · d87b0966

Joe Mason authored Dec 03, 2018

Bug: 908466
Change-Id: I715633c64fff343d07dbcf50c261e686d77e8c44
Reviewed-on: https://chromium-review.googlesource.com/c/1351511Reviewed-by: Andy Perelson <ajp@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Joe Mason <joenotcharles@google.com>

d87b0966

Fix typo in man page for git new-branch · 7808a519

Clemens Hammacher authored Dec 03, 2018

The option is --upstream, not --uptstream.

R=sergiyb@chromium.org

Change-Id: I007dfecae9ba576d65bbb8b96c3f2296d2152a23
Reviewed-on: https://chromium-review.googlesource.com/c/1350747
Auto-Submit: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>

7808a519

[ninja] update ninja repository url · a21a7c53

Takuto Ikuta authored Dec 03, 2018

Change-Id: I60f484a709881f035dc90562658b0a598334451f
Reviewed-on: https://chromium-review.googlesource.com/c/1358031
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Fumitoshi Ukai <ukai@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>

a21a7c53

[ninja] collect build configs · 96fdf7cb

Takuto Ikuta authored Dec 03, 2018

This is to know what build configs are popular among chromium developer.

Bug: 900161
Change-Id: Id07722e70fc407b3f8668080d49033da6e1a7f34
Reviewed-on: https://chromium-review.googlesource.com/c/1358034
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Shinya Kawanaka <shinyak@chromium.org>
Reviewed-by: Fumitoshi Ukai <ukai@chromium.org>

96fdf7cb

introduce ninjalog_uploader to autoninja.bat · 0b287c5b

Takuto Ikuta authored Dec 03, 2018

This is windows version of
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1345255

Changed to use call to invoke python because python is bat file.

Bug: 900161
Change-Id: I0332306387614153be7ae6dbde05fb2bc93559b1
Reviewed-on: https://chromium-review.googlesource.com/c/1355641
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Reviewed-by: Fumitoshi Ukai <ukai@chromium.org>

0b287c5b

01 Dec, 2018 1 commit

git-cl: Remove unused settings. · 61ea3073

Edward Lemur authored Dec 01, 2018

Bug: 770408
Change-Id: Ic5029d6b12cdb6ea30704d90229ab7e365dc7273
Reviewed-on: https://chromium-review.googlesource.com/c/1354384
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

61ea3073

30 Nov, 2018 5 commits

Roll recipe dependencies (nontrivial). · b0ee5ee2

recipe-roller authored Nov 30, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/faa8db3ceb17f3bc13c4ead7e4603760a0532f99 Use reason instead of reason_message. (jchinlee@chromium.org)


R=tandrii@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3321c89b8fd9ace846de08149990cda5084ee78b
Reviewed-on: https://chromium-review.googlesource.com/c/1357323
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>

b0ee5ee2

presubmit: Remove EnsureCQIncludeTrybotsAreAdded · 020b5972

Edward Lemur authored Nov 30, 2018

Bug: 845642
Change-Id: I552b2da4abbac7ca7f6f3961d2b1c5002fb26f47
Reviewed-on: https://chromium-review.googlesource.com/c/1351509Reviewed-by: Andy Perelson <ajp@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

020b5972

Roll recipe dependencies (trivial). · 7ae5d7a9

recipe-roller authored Nov 30, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/2caa3255a823c92842e4725693d35d13783fb81e python: add infra_failing_step utility method. (jbudorick@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If77b80bfe76a2b5c77a3ab10501412adac6e586b
Reviewed-on: https://chromium-review.googlesource.com/c/1357259
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>

7ae5d7a9

Add mechanism for telling CQ to avoid retrying builds. · 016601cc

erikchen authored Nov 30, 2018

The function can be called by chromium_test to set a property 'do_not_retry'
which will be propagated into buildbucket output.

Change-Id: I32d8ea925b7cb98d9b25d24226686e116c17801c
Bug: 910193
Reviewed-on: https://chromium-review.googlesource.com/c/1351542
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>

016601cc

Roll recipe dependencies (nontrivial). · 457b44f3

recipe-roller authored Nov 30, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/793d8faa696f62fa2c774b8c854bbf4d64dff24e Separate InfraFailure behavior from StepFailure behavior. (jchinlee@chromium.org)


R=tandrii@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I396fcab3dbfcbf365d32483cf08f510805da303c
Reviewed-on: https://chromium-review.googlesource.com/c/1355801Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

457b44f3

29 Nov, 2018 2 commits

Roll recipe dependencies (trivial). · dd530811

recipe-roller authored Nov 29, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/d0deba23a671b236ec535a9a54aa78b6dcf142ab [Testing] Add comprehensive UI test recipe. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib52d510e2a48c86f6220781178e34c8bcb52c2bd
Reviewed-on: https://chromium-review.googlesource.com/c/1355779
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>

dd530811

introduce ninjalog_uploader to autoninja · 9af233a5

Takuto Ikuta authored Nov 29, 2018

This CL introduces ninjalog_uploader to autoninja for posix environment.
This is to collect build statistics from googler to find user side build performance bottleneck.

ninjalog_uploader_wrapper is used to notify user and manage small config of upload script.

Bug: 900161
Change-Id: I48ac8cd1d52f64e8fdafaec43636d2d79ef9040d
Reviewed-on: https://chromium-review.googlesource.com/c/1345255Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Shinya Kawanaka <shinyak@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

9af233a5

26 Nov, 2018 3 commits

Roll recipe dependencies (trivial). · 44d4b290

recipe-roller authored Nov 26, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/690ad21d32ae0a94512bc9ac4a6b8fcca96d67f8 Update my legal name (sergiyb@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2e6c43f4586b9b899e929147f5ddf4972c99c9d9
Reviewed-on: https://chromium-review.googlesource.com/c/1351513Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

44d4b290

Roll recipe dependencies (trivial). · d72a8dd5

recipe-roller authored Nov 26, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/caf2224c87491b931d6c4441b2119e0287a99347 [isolated] Expose an isolated server getter (joshuaseaton@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic43cd809209944dc9cea23d87c4cbfdc7006d30e
Reviewed-on: https://chromium-review.googlesource.com/c/1351510Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

d72a8dd5

roll-dep: Use gclient setdep/getdep. · faae42e1

Edward Lemur authored Nov 26, 2018

Use gclient setdep/getdep instead of evaluating the contents of the
DEPS file, so we don't have to deal with builtin_variables.

Bug: 906114
Change-Id: I2082d4a3feb84d15c251b7d99056fd4c6f925453
Reviewed-on: https://chromium-review.googlesource.com/c/1347450Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

faae42e1

23 Nov, 2018 1 commit

Fix git cl format --python when diff.noprefix flag is set · 6c18a1af

Aiden Benner authored Nov 23, 2018

Adding the diff.noprefix flag to .gitconfig broke python
formatting because git diffs were being parsed with regex
that relied on the default git diff prefixs.

This CL fix's this issue by always specifying prefix flags
for git diffs when formatting python.

Bug:846432
Change-Id: Ifde305da9574e6b46455a0237703b7364fac77e4
Reviewed-on: https://chromium-review.googlesource.com/c/1349809Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>

6c18a1af

22 Nov, 2018 1 commit

Roll recipe dependencies (trivial). · 25c4fce2

recipe-roller authored Nov 22, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/20068b80c82fb44c9e871f18ee82e1c032c000af [recipe_modules/archive] Update archive to zip entire root by default. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I64c75b109a0b890efdb32db54b398e1688ad6067
Reviewed-on: https://chromium-review.googlesource.com/c/1347451
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>

25c4fce2

21 Nov, 2018 6 commits

Roll recipe dependencies (trivial). · d6329ad3

recipe-roller authored Nov 21, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/4118c738aa691c9c2b69f8b69359a9ba4fece9d7 [buildbucket] Document gitiles_commit (nodir@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3f01fc3963baa3041328c3aa400dee3e6938f111
Reviewed-on: https://chromium-review.googlesource.com/c/1347449Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

d6329ad3

[vpython] Re-roll to pick up user differentiation of cached envs · d66dad7f

Robert Iannucci authored Nov 21, 2018

Now with correct error handling.

R=nodir@chromium.org, vadimsh@chromium.org

Bug: 869227
Change-Id: I961fd80209c9d9988e9d03016b7c0bd253c6cdfb
Reviewed-on: https://chromium-review.googlesource.com/c/1347249
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

d66dad7f

Don't fetch flash when fetching android_internal. (reland) · a85a4b01

John Budorick authored Nov 21, 2018

Bug: 856278
Change-Id: I949cefd102ecc80b161d082ec40b7e059f596781
Reviewed-on: https://chromium-review.googlesource.com/c/1345050Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

a85a4b01

git cl: remove Rietveld implementation entirely. · a185e2e3

Andrii Shyshkalov authored Nov 21, 2018

R=ajp, ehmaldonado

Change-Id: I59859048d64902669479e666c6c3d37c1fb1394c
Reviewed-on: https://chromium-review.googlesource.com/c/1344642
Auto-Submit: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

a185e2e3

git cl: remove Rietveld import and things it depends on. · 0a264d86

Andrii Shyshkalov authored Nov 21, 2018

On my machine, saves 0.16s of time while loading git cl:
from 0.32s to 0.16s.

R=ajp, ehmaldonado

Change-Id: I0febca43f11514da3e3f7be7e2c0184fb9e17409
Reviewed-on: https://chromium-review.googlesource.com/c/1344641Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

0a264d86

git cl: get rid of Rietveld's upload.py import. · dd5e09a1

Andrii Shyshkalov authored Nov 21, 2018

R=ajp, ehmaldonado

Change-Id: I9c9f5e0f8ef41c0f6a00faa67acf0cf516290f09
Reviewed-on: https://chromium-review.googlesource.com/c/1345272Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

dd5e09a1

20 Nov, 2018 3 commits

Revert "[vpython] Roll to pick up user differentiation of cached envs." · dc3adea9

Vadim Shtayura authored Nov 20, 2018

This reverts commit f4913068.

Reason for revert: panics, see b/119830955

Original change's description:
> [vpython] Roll to pick up user differentiation of cached envs.
> 
> R=vadimsh@chromium.org
> 
> Bug: 869227
> Change-Id: I7e529c7c4d63e35a66ef93623982afc7d254d72f
> Reviewed-on: https://chromium-review.googlesource.com/c/1344638
> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
> Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

TBR=iannucci@chromium.org,vadimsh@chromium.org

Change-Id: Ie77d559dc1787ec1b8a19076238b7018d39dd0b5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 869227
Reviewed-on: https://chromium-review.googlesource.com/c/1344639Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

dc3adea9

[vpython] Roll to pick up user differentiation of cached envs. · f4913068

Robert Iannucci authored Nov 20, 2018

R=vadimsh@chromium.org

Bug: 869227
Change-Id: I7e529c7c4d63e35a66ef93623982afc7d254d72f
Reviewed-on: https://chromium-review.googlesource.com/c/1344638
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

f4913068

Revert "Don't fetch flash when fetching android_internal." · 61e97781

John Budorick authored Nov 20, 2018

This reverts commit 3f40c42b.

Reason for revert: ast.literal_eval(False) doesn't work?

Original change's description:
> Don't fetch flash when fetching android_internal.
> 
> Bug: 856278
> Change-Id: I89eccc7581daedda69dee4f99d174e8cb49c6ba1
> Reviewed-on: https://chromium-review.googlesource.com/c/1342730
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Commit-Queue: John Budorick <jbudorick@chromium.org>

TBR=ehmaldonado@chromium.org,jbudorick@chromium.org

Change-Id: Iffb655701830984e47a2b8e7629f0ed87886a401
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 856278
Reviewed-on: https://chromium-review.googlesource.com/c/1344637Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

61e97781