Commits · 002f97b35a726ac34335376cc2c5637d31ae2f69 · Linshizhi / Chromium_Depot_tools

19 May, 2020 3 commits

Abort fetch, gclient, gsutil.py when update_depot_tools fails on Windows · 002f97b3

Edward Lesmes authored May 19, 2020

We should fail when we fail to update depot_tools instead of continuing
the execution silently. Otherwise, developers might get stuck on a bad
depot_tools revision without knowing.

Change-Id: I0431a24a28a77aca8c66352939a0252c458b3e9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2208616Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

002f97b3

Roll out new goma client binary VERSION=200 · 5a7be3da

Ye Kuang authored May 19, 2020

https://chromium.googlesource.com/infra/goma/client/+/ccc8255ac04a4f79a4649168c04ffdaa59af649b

Bug: b/156546740
Change-Id: If754346ec49c7314b13160ea682c630e0e5ccd21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2208512
Commit-Queue: Ye Kuang <yekuang@google.com>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@google.com>
Auto-Submit: Ye Kuang <yekuang@google.com>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>

5a7be3da

Roll recipe dependencies (trivial). · e67e41aa

recipe-roller authored May 19, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/c032fdbdb5e726dbb2842c212a6ec237126fda56 (lamontjones@chromium.org)
cq: correct property name.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I24d67cbe6b65d95f69eef08321102c9a9ec9c9a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2208209Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

e67e41aa

16 May, 2020 2 commits

Roll recipe dependencies (trivial). · c4fb1974

recipe-roller authored May 16, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/935b52680cfbf06efe126de0f68980a51472bfcd (yiwzhang@google.com)
    [engine] Support merge step in Stream Engine
  https://crrev.com/9612029d01ef2c99345f6b53dd15ece8bc75400e (yiwzhang@google.com)
    [luciexe] set default log level to info

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I43a2232ac8f1df0e29ece052f8e0edaa672bcb59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2204903Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

c4fb1974

Roll recipe dependencies (trivial). · 728fc627

recipe-roller authored May 16, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/2209e8c4c0d99b6682a1c747015ba95a962bb088 (iannucci@chromium.org)
Fix luciexe mode when stdout is populated from user space.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5e1c2a464ba1e69a4f5bafc35e0e9e89aedd938c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2204919Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

728fc627

15 May, 2020 1 commit

Roll recipe dependencies (trivial). · 5e0a4a6b

recipe-roller authored May 15, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/270b341c5f36f1cdfa73ab7f190f961a1c8f7565 (olivernewman@google.com)
    [swarming] Update swarming client version

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibc7e76407946ad6f3f9496fdd5c1b9827f640236
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2203271Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

5e0a4a6b

14 May, 2020 3 commits

depot_tools: bugfix for py3 syntax and bytes/str changes · beb877fe

Robert Brandt authored May 14, 2020

Also update copywrite header to conform to expectations.

BUG=chromium:1082354
TEST=locally, can upload commit with this fix

Change-Id: I5527cf9cc58fbab94f777b82008a422a3190f539
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2199884
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

beb877fe

Roll recipe dependencies (trivial). · 176bf641

recipe-roller authored May 14, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/093ad4d4c27bcecdb3b80d36b4615692cde14524 (iannucci@chromium.org)
    [luciexe] Synthesize deprecated properties to ease transition.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3a4349b13ab05d5c31b8439104acdf2e78c4c704
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2202664Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

176bf641

Add a pan-project presubmit check for commits in tree · 053213d0

Derek Morris authored May 14, 2020

It's possible to add commit objects to the tree, and this can cause
some confusion for git's tools - if this happens to overlap with an
actual folder or a gclient-imported repo, the tree will be dirty.

This change finds this issue by scanning the tree and looking for a
commit object there.

Bug: 869594
Change-Id: Ia1f1fb22ab8f7ac1eed7b32dedad5c1296b1d67b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1842637Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Derek Morris <demorri@microsoft.com>

053213d0

13 May, 2020 1 commit

Update cipd_manifest for Goma client 80180e1e · 30ef5cb4

Simon Que authored May 13, 2020

R=tikuta@chromium.org, ukai@chromium.org, yekuang@google.com, yyanagisawa@chromium.org

Bug: b/155444722
Change-Id: Idb8c4a08a8094a5ec923d4ba0157d1142d9271b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2198271Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Simon Que <sque@chromium.org>

30ef5cb4

12 May, 2020 3 commits

Delete dirty bot_update workspace · 8280ae5e

Josip Sokcevic authored May 12, 2020

File marker '.dirty_bot_checkout' indicates that bot_update checkout has
started. Such marker is removed on successful checkout.

If such marker is present before creation, it means previous run wasn't
successful and may have left workspace in a bad state. In that case,
delete working directory and continue with a clean checkout.

R=apolito@google.com, ehmaldonado@chromium.org

Bug: 1074260
Change-Id: Ic089eedc26f7c269d5342fae366899571d8f8d41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2186273
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>

8280ae5e

Roll recipe dependencies (trivial). · 1fbaf73a

recipe-roller authored May 12, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/0e48470a5ac2b31561146925f2d52ae3e120bc4e (iannucci@chromium.org)
    [luciexe] Map WARNING to SUCCESS to match previous behavior.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I57738fe5cc30b18efbf737206a773b58a8b00c9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2195556Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

1fbaf73a

WATCHLISTS: CC chops-source-team@ on all depot_tools changes. · f90afd3e

Edward Lesmes authored May 12, 2020

Change-Id: I60572a93178038335b5a6af0f03ad6500a72c862
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2194898Reviewed-by: Andy Perelson <ajp@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

f90afd3e

11 May, 2020 2 commits

Roll recipe dependencies (trivial). · 454f4ba4

recipe-roller authored May 11, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/55bc6100c43ae642a9107242d8e122e924d0e9cd (olivernewman@google.com)
    [swarming] Update swarming client version

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6119026a38399445d30c79fbc686e8ba7a468947
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2194881Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

454f4ba4

Roll recipe dependencies (trivial). · b833dd8a

recipe-roller authored May 11, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/e9bcb3b0c6c5d520cb48932b878212240a5b0bb1 (olivernewman@google.com)
    [test] Don't ignore --jobs argument

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1b3016fd88dcc1298f44748752f630aba299959a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2194255Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

b833dd8a

09 May, 2020 2 commits

Roll recipe dependencies (trivial). · aaf56699

recipe-roller authored May 09, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/70eb7a77b1f8a2482dc1bf6dd09c337485c13ca8 (yiwzhang@google.com)
    [luciexe] Always send one last build to lodgog before closing stream engine

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib4f5815aa9c66677cffb62506ad61f8854eec1dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2191464Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

aaf56699

Use cached variable for git cl completion · 8b35029c

Henrique Ferreiro authored May 09, 2020

__git_cl_all_commands is used to cache the result of
__git_cl_commands(), but the actual code wasn't using it and was calling
the function everytime instead.

Change-Id: Ia2ce32b7de2812349808ec9aceeacf5adf463700
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2190337Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>

8b35029c

08 May, 2020 3 commits

Print the SHA of files downloaded from GS · 64dab2db

Yuly Novikov authored May 08, 2020

Bug: angleproject:4621
Change-Id: I85aefeeffa05712a63a62e9acef8df27b1933e34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2190862
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

64dab2db

Prune branches that no longer exist on remote · 6afaa6ca

Josip Sokcevic authored May 08, 2020

If a local branch tracks removed remote tracking branch (e.g. foo) and
remote has a branch that starts with such name (e.g. foo/bar), git fetch
will fail. --prune flag removes any remote-tracking branches that no
longer exist.

R=apolito@google.com, ehmaldonado@chromium.org

Bug: 1079483
Change-Id: I9bc31bf961d52a86b6fa2342249971b99a003666
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2190341
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

6afaa6ca

Roll recipe dependencies (trivial). · ddcba7ca

recipe-roller authored May 08, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/c55f377bbc5b7d73ea7ac4d6504d6d6071a8fbf9 (tikuta@chromium.org)
isolated/swarming: use mocked client revision

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I449af80e4593f6157ded536affe673b96d31acd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2190159Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

ddcba7ca

07 May, 2020 4 commits

Roll recipe dependencies (trivial). · 9a735310

recipe-roller authored May 07, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/466a65323b5dc2923ead7a51c133eea02c412e5a (iannucci@chromium.org)
    [proto] Add output_stream for mocking stdout/stderr.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib26687fbb33277ef9c52e00fdf34d5e354484758
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2188928Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

9a735310

Roll lucicfg tool to @ f3a7e781 v1.14.0 · c1655adb

Andrii Shyshkalov authored May 07, 2020

Old revision: 365f7220

Change logs:
  infra/infra:
    https://chromium.googlesource.com/infra/infra/+log/365f7220..f3a7e781
  luci-go
    https://chromium.googlesource.com/infra/luci/luci-go/+log/5922f348..82343c26/lucicfg

Bug: 987411
Change-Id: Ie6bc9dd5b67bfd443321a882ba913291c8774301
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2188913Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>

c1655adb

Roll recipe dependencies (trivial). · f9eef45d

recipe-roller authored May 07, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/6472553ec788b41aed0d048f6be8ce3290fcbe60 (yekuang@google.com)
Roll isolated client version

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I60183e88744fa0802ad3209e5fce764f464684be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2186856Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

f9eef45d

Roll recipe dependencies (trivial). · f7df9c45

recipe-roller authored May 07, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/9e3caa0d134d1111bb7119648147e3451fe525d8 (yuanjunh@google.com)
Add the hide_build_in_gerrit function

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1e5119aeb68625d7934d10ecf584dbabbe96146f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2186851Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

f7df9c45

06 May, 2020 6 commits

Roll recipe dependencies (trivial). · bd73ca8f

recipe-roller authored May 06, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/305370ff915e7a4ee316fc3366f36833796310b5 (iannucci@chromium.org)
    [post_process_inputs] Improve Command matcher to allow multiple subsequences.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9ddd3223312c497eeffc7a5eaf3d6ec70e338802
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2185786Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

bd73ca8f

Roll recipe dependencies (trivial). · 3997b112

recipe-roller authored May 06, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/bebfc7949f03ac665c5df77fc1c0c69786630744 (garymm@google.com)
Expose raw swarming task result

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id4ea7798a4eecf66a361765640000806330f660d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2185952Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

3997b112

Roll recipe dependencies (trivial). · a93878c5

recipe-roller authored May 06, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/a980197a59085b739dae00a4abdb9af0fa6dc71f (yuanjunh@google.com)
Allow to add tags into its build during runtime

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I354099a99f931d40ee216689caacd48aff5d6b93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2184823Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

a93878c5

[led] Roll to ledv2 in depot_tools. · ebbc0692

Robert Iannucci authored May 06, 2020

This has stabilized on the bots and early field testers, so I think
this should be pretty safe for the remaining users.

R=ehmaldonado@chromium.org, tandrii@chromium.org, vadimsh@chromium.org

Bug: 1017818
Change-Id: Iae0a036646e1ef87087625dd4b1bd1fbbe9286c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2184744
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>

ebbc0692

Print clarifying message when no new owners needed · 9b4a0570

Bruce Dawson authored May 06, 2020

If a CL already has owners on the reviewer list that cover all of the
files - regardless of whether they have approved the change - git cl
owners just prints ** You selected these owners **, which can be
confusing. This change adds an explanation in the no-unowned-files case
and suggests using --ignore-current if more reviewers are wanted.

Bug: 1071967
Change-Id: If60455c5ec15006e09feed39633fa62e3ddf0a04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2183222Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>

9b4a0570

Warn when --show-all is used with no files listed · 97ed44ad

Bruce Dawson authored May 06, 2020

At least one contributor thought that --show-all would show all owners
for the current CL, so they used it with no files specified and got
confused by the lack of output. I was fooled to. The message printed
by "git cl help owners" makes it clear but it seems worth detecting the
no-files case and printing a helpful message, especially since most
(all?) of the other git cl owners commands apply to the current CL.

Bug: 1071967
Change-Id: I77bd2e30a3b3a6eb67cd40b93f5544b20facacb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2183219Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>

97ed44ad

05 May, 2020 8 commits

Revert "git-cl: turn GERRIT_SQUASH_UPLOADS into a warning" · 4de54135

Edward Lesmes authored May 05, 2020

This reverts commit 31a538a3.

Reason for revert:
Breaks ANGLE's workflow.

Original change's description:
> git-cl: turn GERRIT_SQUASH_UPLOADS into a warning
> 
> Now that repos have dropped this from their codereview.settings file,
> change this logic to issue a warning if it's ever seen again.
> 
> Drop checking local gerrit.override-squash-uploads config too since
> it's no longer relevant.
> 
> Bug: 993518
> Change-Id: Id91bbc94b0890ca21c51a274f6acc41f2ae19b78
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1756159
> Commit-Queue: Mike Frysinger <vapier@chromium.org>
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

TBR=vapier@chromium.org,ehmaldonado@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: Iaa8b3341b189f356082ae25a1557898e25820566
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 993518
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2182019Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

4de54135

Roll recipe dependencies (trivial). · 1cbfe0f1

recipe-roller authored May 05, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/a24b238dfe4332ff9e6a55285a1068625418d059 (nodir@chromium.org)
    [resultdb] Fix invocation inclusion

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I062180a9464f5a7243d542311edc72f5f1e9a0e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2182880Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

1cbfe0f1

git-cl: turn GERRIT_SQUASH_UPLOADS into a warning · 31a538a3

Mike Frysinger authored May 05, 2020

Now that repos have dropped this from their codereview.settings file,
change this logic to issue a warning if it's ever seen again.

Drop checking local gerrit.override-squash-uploads config too since
it's no longer relevant.

Bug: 993518
Change-Id: Id91bbc94b0890ca21c51a274f6acc41f2ae19b78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1756159
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

31a538a3

Roll recipe dependencies (trivial). · fbe690fd

recipe-roller authored May 05, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/f41f5b523c58c70c19678c2c8c5868159089bdfc (tandrii@chromium.org)
buildbucket: support 'self' tag key in api.build.bucket.tags().

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I24392147e134e1fd006ffd5b632d6b40f9724f30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2182929Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

fbe690fd

Roll recipe dependencies (trivial). · db639b70

recipe-roller authored May 05, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://crrev.com/82f957d2db220f7a3f1e9de1184df6806470a32a (tandrii@chromium.org)
buildbucket: remove old master tag hack.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib8a13dfe7ddec046e4b88cb1ae39f763a17d0125
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2181536Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

db639b70

Roll rdb · ae7f4c51

Nodir Turakulov authored May 05, 2020

Roll to the latest version.

R=ddoman@chromium.org

Change-Id: I4aced3043371d20e8e05cba78b17c785c313dfe9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2182264
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
Reviewed-by: Scott Lee <ddoman@chromium.org>

ae7f4c51

Roll recipe dependencies (trivial). · ced1cc9e

recipe-roller authored May 05, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/fcd5731c9b916b7c37865b154ca089b636fb697a (nodir@chromium.org)
    [resultdb] Simplify tests

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1267384dc7fac9fcef7ae4637519bc503b963312
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2181513Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

ced1cc9e

Roll recipe dependencies (trivial). · f828cf36

recipe-roller authored May 05, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/5334991eef8485e2a14914bc48e7fb7f726a8bd5 (nodir@chromium.org)
    [resultdb] Add resultdb.wrap function

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifb64c21de58007abf723a04c13eb2e5b8bbcdfe3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2181728Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

f828cf36

04 May, 2020 2 commits

Roll recipe dependencies (trivial). · 9e99f7c8

recipe-roller authored May 04, 2020

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/ebf006f6230e66be4733d74b31303e6102409944 (nodir@chromium.org)
    [resultdb] Use rdb-rpc to update inclusions

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic0856263d388c2c00ec6f0b410cd3801cc16802e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2181643Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

9e99f7c8

[resultdb] Add rdb and rdb.bat · 0f47d332

Nodir Turakulov authored May 04, 2020

This should have been a part of
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2176997

R=estaab@chromium.org

Change-Id: Ia362b562c9818ab759a793aeafd8fda221c86ac4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2177172Reviewed-by: Erik Staab <estaab@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Auto-Submit: Nodir Turakulov <nodir@chromium.org>

0f47d332