Commit fbee1650 authored by Andrii Shyshkalov's avatar Andrii Shyshkalov Committed by Commit Bot

git cl: remove temporary workaround of invisible unicode char in emails.

PolyGerrit used to surround emails with invisible unicode char, which
resulted in reviewers not being found by Gerrit. It has since been
fixed (handled in Google internal bug b/34702620).

R=sergiyb@chromium.org

Change-Id: I43ade0ef23d88611081744eff57129a69b5176c8
Reviewed-on: https://chromium-review.googlesource.com/472808Reviewed-by: 's avatarSergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
parent 9ce47f36
......@@ -2958,12 +2958,7 @@ class _GerritChangelistImpl(_ChangelistCodereviewBase):
reviewers = change_desc.get_reviewers()
if reviewers:
# TODO(tandrii): remove this horrible hack once (Poly)Gerrit fixes their
# side for real (b/34702620).
def clean_invisible_chars(email):
return email.decode('unicode_escape').encode('ascii', 'ignore')
refspec_opts.extend('r=' + clean_invisible_chars(email).strip()
for email in reviewers)
refspec_opts.extend('r=' + email.strip() for email in reviewers)
if options.private:
refspec_opts.append('draft')
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment