Commit e5adf612 authored by Aaron Gable's avatar Aaron Gable Committed by Commit Bot

Fix typo with --send-email [sic] flags

The actual flag is --send-mail. Also includes a fix
to publish these changes if a comment is included.

Bug: 740950
Change-Id: I38ca0a35c1364c8364eb0ef301137c04daede40b
Reviewed-on: https://chromium-review.googlesource.com/572033Reviewed-by: 's avatarAndrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
parent 0ed616a4
......@@ -3040,7 +3040,7 @@ class _GerritChangelistImpl(_ChangelistCodereviewBase):
refspec_opts.append('notify=NONE')
# TODO(tandrii): options.message should be posted as a comment
# if --send-email is set on non-initial upload as Rietveld used to do it.
# if --send-mail is set on non-initial upload as Rietveld used to do it.
if title:
if not re.match(r'^[\w ]+$', title):
......
......@@ -114,11 +114,12 @@ def UploadCl(refactor_branch, refactor_branch_upstream, directory, files,
[f.LocalPath() for f in files], author)
upload_args = ['-f', '--cq-dry-run', '-r', ','.join(reviewers)]
if not comment:
upload_args.append('--send-email')
upload_args.append('--send-mail')
print 'Uploading CL for ' + directory + '.'
cmd_upload(upload_args)
if comment:
changelist().AddComment(FormatDescriptionOrComment(comment, directory))
changelist().AddComment(FormatDescriptionOrComment(comment, directory),
publish=True)
def GetFilesSplitByOwners(owners_database, files):
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment