Commit e3a3fd45 authored by dcheng@chromium.org's avatar dcheng@chromium.org

Suppress readability/inheritance check for cpplint.py for now.

This check never triggered before, since cpplint.py was looking for
override not OVERRIDE. Since Chromium prefers override now, the
linter is now (correctly) warning. However, the old Chromium convention
(and the one implemented by the clang plugin) is to explicitly annotate
all overrides with both virtual and override. The clang plugin code has
been updated, but new binaries have not yet been built. Until clang
rolls, suppress the warning.

BUG=417463
TBR=stip@chromium.org

Review URL: https://codereview.chromium.org/627163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292319 0039d316-1c4b-4281-b951-d872f2087c98
parent bd0cace8
...@@ -109,9 +109,11 @@ def CheckChangeLintsClean(input_api, output_api, source_file_filter=None): ...@@ -109,9 +109,11 @@ def CheckChangeLintsClean(input_api, output_api, source_file_filter=None):
# - runtime/int : Can be fixed long term; volume of errors too high # - runtime/int : Can be fixed long term; volume of errors too high
# - runtime/virtual : Broken now, but can be fixed in the future? # - runtime/virtual : Broken now, but can be fixed in the future?
# - whitespace/braces : We have a lot of explicit scoping in chrome code. # - whitespace/braces : We have a lot of explicit scoping in chrome code.
# - readability/inheritance : Temporary, while the OVERRIDE and FINAL fixup
# is in progress.
cpplint._SetFilters('-build/include,-build/include_order,-build/namespace,' cpplint._SetFilters('-build/include,-build/include_order,-build/namespace,'
'-readability/casting,-runtime/int,-runtime/virtual,' '-readability/casting,-runtime/int,-runtime/virtual,'
'-whitespace/braces') '-whitespace/braces,-readability/inheritance')
# We currently are more strict with normal code than unit tests; 4 and 5 are # We currently are more strict with normal code than unit tests; 4 and 5 are
# the verbosity level that would normally be passed to cpplint.py through # the verbosity level that would normally be passed to cpplint.py through
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment