Added a default timeout to rietveld requests.

BUG=345117

Review URL: https://codereview.chromium.org/174313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@252452 0039d316-1c4b-4281-b951-d872f2087c98

rietveld.py

@@ -367,6 +367,9 @@ class Rietveld(object):
 
   def _send(self, request_path, **kwargs):
     """Sends a POST/GET to Rietveld.  Returns the response body."""
+    # rpc_server.Send() assumes timeout=None by default; make sure it's set
+    # to something reasonable.
+    kwargs.setdefault('timeout', 15)
     logging.debug('POSTing to %s, args %s.', request_path, kwargs)
     try:
       # Sadly, upload.py calls ErrorExit() which does a sys.exit(1) on HTTP

tests/rietveld_test.py

@@ -8,11 +8,13 @@
 import logging
 import os
 import sys
+import traceback
 import unittest
 
 sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
 
 from testing_support.patches_data import GIT, RAW
+from testing_support import auto_stub
 
 import patch
 import rietveld
@@ -421,6 +423,46 @@ class CachingRietveldTest(BaseFixture):
     self.assertEqual(expected, self.rietveld.get_patchset_properties(1, 2))
 
 
+class ProbeException(Exception):
+  """Deep-probe a value."""
+  value = None
+
+  def __init__(self, value):
+    super(ProbeException, self).__init__()
+    self.value = value
+
+
+def MockSend(request_path, payload=None,
+             content_type="application/octet-stream",
+             timeout=None,
+             extra_headers=None,
+             **kwargs):
+  """Mock upload.py's Send() to probe the timeout value"""
+  raise ProbeException(timeout)
+
+
+class DefaultTimeoutTest(auto_stub.TestCase):
+  TESTED_CLASS = rietveld.Rietveld
+
+  def setUp(self):
+    super(DefaultTimeoutTest, self).setUp()
+    self.rietveld = self.TESTED_CLASS('url', 'email', 'password')
+    self.mock(self.rietveld.rpc_server, 'Send', MockSend)
+
+  def test_timeout_get(self):
+    with self.assertRaises(ProbeException) as cm:
+      self.rietveld.get('/api/1234')
+
+    self.assertIsNotNone(cm.exception.value, 'Rietveld timeout was not set: %s'
+                         % traceback.format_exc())
+
+  def test_timeout_post(self):
+    with self.assertRaises(ProbeException) as cm:
+      self.rietveld.post('/api/1234', [('key', 'data')])
+
+    self.assertIsNotNone(cm.exception.value, 'Rietveld timeout was not set: %s'
+                         % traceback.format_exc())
+
 
 if __name__ == '__main__':
   logging.basicConfig(level=[