Commit d3f769a7 authored by Lei Zhang's avatar Lei Zhang Committed by Commit Bot

Change "ldap" to "username".

Change-Id: Ic993758ea901d039c5fdac978e516ba20f95005d
Reviewed-on: https://chromium-review.googlesource.com/830611Reviewed-by: 's avatarAndrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
parent 41d9d87e
......@@ -3883,8 +3883,8 @@ class _GitCookiesChecker(object):
@staticmethod
def _parse_identity(identity):
"""Parses identity "git-<ldap>.example.com" into <ldap> and domain."""
# Special case: users whose ldaps contain ".", which are generally not
"""Parses identity "git-<username>.domain" into <username> and domain."""
# Special case: usernames that contain ".", which are generally not
# distinguishable from sub-domains. But we do know typical domains:
if identity.endswith('.chromium.org'):
domain = 'chromium.org'
......
......@@ -560,7 +560,8 @@ class GitCookiesCheckerTest(TestCase):
# Specical case because we know there are no subdomains in chromium.org.
self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
('note.period', 'chromium.org'))
# Pathological: .period. can be either ldap OR domain, more likely domain.
# Pathological: ".period." can be either username OR domain, more likely
# domain.
self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
('note', 'period.example.com'))
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment