Revert of git cl try: don't skip presubmit builders, but set dry_run property....

Revert of git cl try: don't skip presubmit builders, but set dry_run property. (patchset #2 id:20001 of https://codereview.chromium.org/1926663002/ )

Reason for revert:
Now only presubmit is scheduled on dry run, example CL:
https://codereview.chromium.org/1804003002

Original issue's description:
> Reland of git cl try: don't skip presubmit builders, but set dry_run property.
> 
> With a fix: actually set dry_run for presubmit, and don't set it for other builders.
> 
> R=machenbach@chromium.org,sergiyb@chromium.org
> BUG=601128,594127,591030
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300295

TBR=sergiyb@chromium.org,tandrii@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=601128,594127,591030

Review-Url: https://codereview.chromium.org/1928373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300337 0039d316-1c4b-4281-b951-d872f2087c98
parent 6cfbbcf4
...@@ -337,8 +337,6 @@ def trigger_try_jobs(auth_config, changelist, options, masters, category): ...@@ -337,8 +337,6 @@ def trigger_try_jobs(auth_config, changelist, options, masters, category):
'rietveld': rietveld_url, 'rietveld': rietveld_url,
}, },
} }
if 'presubmit' in builder.lower():
parameters['properties']['dry_run'] = 'true'
if tests: if tests:
parameters['properties']['testfilter'] = tests parameters['properties']['testfilter'] = tests
if properties: if properties:
...@@ -4318,7 +4316,8 @@ def CMDtry(parser, args): ...@@ -4318,7 +4316,8 @@ def CMDtry(parser, args):
for master, builders in cq_masters.iteritems(): for master, builders in cq_masters.iteritems():
for builder in builders: for builder in builders:
# Skip presubmit builders, because these will fail without LGTM. # Skip presubmit builders, because these will fail without LGTM.
masters.setdefault(master, {})[builder] = ['defaulttests'] if 'presubmit' not in builder.lower():
masters.setdefault(master, {})[builder] = ['defaulttests']
if masters: if masters:
return masters return masters
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment