Make git recipe api add depot_tools to PATH

"git retry" assumes that depot_tools is in PATH; in some cases it isn't,
and there's currently no way to add it.

BUG=

Recipe-Tryjob-Bypass-Reason: Expectations known to change
Review-Url: https://codereview.chromium.org/2192163002

recipe_modules/git/api.py

@@ -208,11 +208,16 @@ class GitApi(recipe_api.RecipeApi):
         self.resource('git_setup.py'),
         git_setup_args)
 
+    # Some of the commands below require depot_tools to be in PATH.
+    path = self.m.path.pathsep.join([
+        str(self.package_repo_resource()), '%(PATH)s'])
+
     if use_git_cache:
       self('retry', 'cache', 'fetch', '-c', self.m.path['git_cache'],
            cwd=dir_path,
            name='fetch cache',
-           can_fail_build=can_fail_build)
+           can_fail_build=can_fail_build,
+           env={'PATH': path})
 
     # There are five kinds of refs we can be handed:
     # 0) None. In this case, we default to properties['branch'].
@@ -246,7 +251,7 @@ class GitApi(recipe_api.RecipeApi):
     if recursive:
       fetch_args.append('--recurse-submodules')
 
-    fetch_env = {}
+    fetch_env = {'PATH': path}
     fetch_stderr = None
     if curl_trace_file:
       fetch_env['GIT_CURL_VERBOSE'] = '1'

recipe_modules/git/example.expected/basic.json

@@ -21,6 +21,9 @@
       "--recurse-submodules"
     ],
     "cwd": "[SLAVE_BUILD]/src",
+    "env": {
+      "PATH": "RECIPE_PACKAGE_REPO[depot_tools]:%(PATH)s"
+    },
     "name": "git fetch"
   },
   {

recipe_modules/git/example.expected/basic_branch.json

@@ -21,6 +21,9 @@
       "--recurse-submodules"
     ],
     "cwd": "[SLAVE_BUILD]/src",
+    "env": {
+      "PATH": "RECIPE_PACKAGE_REPO[depot_tools]:%(PATH)s"
+    },
     "name": "git fetch"
   },
   {

recipe_modules/git/example.expected/basic_file_name.json

@@ -21,6 +21,9 @@
       "--recurse-submodules"
     ],
     "cwd": "[SLAVE_BUILD]/src",
+    "env": {
+      "PATH": "RECIPE_PACKAGE_REPO[depot_tools]:%(PATH)s"
+    },
     "name": "git fetch"
   },
   {

recipe_modules/git/example.expected/basic_hash.json

@@ -20,6 +20,9 @@
       "--recurse-submodules"
     ],
     "cwd": "[SLAVE_BUILD]/src",
+    "env": {
+      "PATH": "RECIPE_PACKAGE_REPO[depot_tools]:%(PATH)s"
+    },
     "name": "git fetch"
   },
   {

recipe_modules/git/example.expected/basic_ref.json

@@ -21,6 +21,9 @@
       "--recurse-submodules"
     ],
     "cwd": "[SLAVE_BUILD]/src",
+    "env": {
+      "PATH": "RECIPE_PACKAGE_REPO[depot_tools]:%(PATH)s"
+    },
     "name": "git fetch"
   },
   {

recipe_modules/git/example.expected/basic_submodule_update_force.json

@@ -21,6 +21,9 @@
       "--recurse-submodules"
     ],
     "cwd": "[SLAVE_BUILD]/src",
+    "env": {
+      "PATH": "RECIPE_PACKAGE_REPO[depot_tools]:%(PATH)s"
+    },
     "name": "git fetch"
   },
   {

recipe_modules/git/example.expected/can_fail_build.json

@@ -21,6 +21,9 @@
       "--recurse-submodules"
     ],
     "cwd": "[SLAVE_BUILD]/src",
+    "env": {
+      "PATH": "RECIPE_PACKAGE_REPO[depot_tools]:%(PATH)s"
+    },
     "name": "git fetch"
   },
   {

recipe_modules/git/example.expected/cannot_fail_build.json

@@ -21,6 +21,9 @@
       "--recurse-submodules"
     ],
     "cwd": "[SLAVE_BUILD]/src",
+    "env": {
+      "PATH": "RECIPE_PACKAGE_REPO[depot_tools]:%(PATH)s"
+    },
     "name": "git fetch"
   },
   {

recipe_modules/git/example.expected/cat-file_test.json

@@ -21,6 +21,9 @@
       "--recurse-submodules"
     ],
     "cwd": "[SLAVE_BUILD]/src",
+    "env": {
+      "PATH": "RECIPE_PACKAGE_REPO[depot_tools]:%(PATH)s"
+    },
     "name": "git fetch"
   },
   {

recipe_modules/git/example.expected/count-objects_delta.json

@@ -42,6 +42,9 @@
       "--recurse-submodules"
     ],
     "cwd": "[SLAVE_BUILD]/src",
+    "env": {
+      "PATH": "RECIPE_PACKAGE_REPO[depot_tools]:%(PATH)s"
+    },
     "name": "git fetch"
   },
   {

recipe_modules/git/example.expected/count-objects_failed.json

@@ -21,6 +21,9 @@
       "--recurse-submodules"
     ],
     "cwd": "[SLAVE_BUILD]/src",
+    "env": {
+      "PATH": "RECIPE_PACKAGE_REPO[depot_tools]:%(PATH)s"
+    },
     "name": "git fetch"
   },
   {

recipe_modules/git/example.expected/count-objects_with_bad_output.json

@@ -21,6 +21,9 @@
       "--recurse-submodules"
     ],
     "cwd": "[SLAVE_BUILD]/src",
+    "env": {
+      "PATH": "RECIPE_PACKAGE_REPO[depot_tools]:%(PATH)s"
+    },
     "name": "git fetch"
   },
   {

recipe_modules/git/example.expected/count-objects_with_bad_output_fails_build.json

@@ -21,6 +21,9 @@
       "--recurse-submodules"
     ],
     "cwd": "[SLAVE_BUILD]/src",
+    "env": {
+      "PATH": "RECIPE_PACKAGE_REPO[depot_tools]:%(PATH)s"
+    },
     "name": "git fetch"
   },
   {

recipe_modules/git/example.expected/curl_trace_file.json

@@ -22,7 +22,8 @@
     ],
     "cwd": "[SLAVE_BUILD]/src",
     "env": {
-      "GIT_CURL_VERBOSE": "1"
+      "GIT_CURL_VERBOSE": "1",
+      "PATH": "RECIPE_PACKAGE_REPO[depot_tools]:%(PATH)s"
     },
     "name": "git fetch",
     "stderr": "[SLAVE_BUILD]/curl_trace.log"

recipe_modules/git/example.expected/git-cache-checkout.json

@@ -21,6 +21,9 @@
       "[GIT_CACHE]"
     ],
     "cwd": "[SLAVE_BUILD]/src",
+    "env": {
+      "PATH": "RECIPE_PACKAGE_REPO[depot_tools]:%(PATH)s"
+    },
     "name": "fetch cache"
   },
   {
@@ -33,6 +36,9 @@
       "--recurse-submodules"
     ],
     "cwd": "[SLAVE_BUILD]/src",
+    "env": {
+      "PATH": "RECIPE_PACKAGE_REPO[depot_tools]:%(PATH)s"
+    },
     "name": "git fetch"
   },
   {

recipe_modules/git/example.expected/platform_win.json

@@ -31,6 +31,9 @@
       "--recurse-submodules"
     ],
     "cwd": "[SLAVE_BUILD]\\src",
+    "env": {
+      "PATH": "RECIPE_PACKAGE_REPO[depot_tools];%(PATH)s"
+    },
     "name": "git fetch"
   },
   {

recipe_modules/git/example.expected/rebase_failed.json

@@ -21,6 +21,9 @@
       "--recurse-submodules"
     ],
     "cwd": "[SLAVE_BUILD]/src",
+    "env": {
+      "PATH": "RECIPE_PACKAGE_REPO[depot_tools]:%(PATH)s"
+    },
     "name": "git fetch"
   },
   {

recipe_modules/git/example.expected/remote_not_origin.json

@@ -23,6 +23,9 @@
       "--recurse-submodules"
     ],
     "cwd": "[SLAVE_BUILD]/src",
+    "env": {
+      "PATH": "RECIPE_PACKAGE_REPO[depot_tools]:%(PATH)s"
+    },
     "name": "git fetch"
   },
   {

recipe_modules/git/example.expected/set_got_revision.json

@@ -21,6 +21,9 @@
       "--recurse-submodules"
     ],
     "cwd": "[SLAVE_BUILD]/src",
+    "env": {
+      "PATH": "RECIPE_PACKAGE_REPO[depot_tools]:%(PATH)s"
+    },
     "name": "git fetch"
   },
   {