gclient: Stop printing newline in front of "________ running hook"

The newline is probably here to protect against a hook that doesn't print
a trailing newline.  I've never seen a hook that did that, and if we found one,
we could make the logic look like "print a trailing newline if it's not there"
-- or just fix the hook.

The newline has been around since depot_tools was created
(https://codereview.chromium.org/92087, gclient.py), back then this was in
a general "run stuff" function, not in hooks-specific code.  Maybe it made
more sense back then.

This is part of a few changes to make `gclient runhooks` less noisy.

Bug: 772741
Change-Id: I285f76dc3f01c5acf5bbaa0be4db9f6edb9c0366
Reviewed-on: https://chromium-review.googlesource.com/706914Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>

gclient_utils.py

@@ -291,7 +291,7 @@ def CheckCallAndFilterAndHeader(args, always=False, header=None, **kwargs):
   """
   stdout = kwargs.setdefault('stdout', sys.stdout)
   if header is None:
-    header = "\n________ running '%s' in '%s'\n" % (
+    header = "________ running '%s' in '%s'\n" % (
                  ' '.join(args), kwargs.get('cwd', '.'))
 
   if always:

tests/gclient_scm_test.py

@@ -340,7 +340,7 @@ class ManagedGitWrapperTestCase(BaseGitWrapperTestCase):
     scm.status(options, self.args, file_list)
     self.assertEquals(file_list, [file_path])
     self.checkstdout(
-        ('\n________ running \'git diff --name-status '
+        ('________ running \'git diff --name-status '
          '069c602044c5388d2d15c3f875b057c852003458\' in \'%s\'\nM\ta\n') %
             join(self.root_dir, '.'))
 
@@ -360,7 +360,7 @@ class ManagedGitWrapperTestCase(BaseGitWrapperTestCase):
     expected_file_list = [join(self.base_path, x) for x in ['a', 'b']]
     self.assertEquals(sorted(file_list), expected_file_list)
     self.checkstdout(
-        ('\n________ running \'git diff --name-status '
+        ('________ running \'git diff --name-status '
          '069c602044c5388d2d15c3f875b057c852003458\' in \'%s\'\nM\ta\nM\tb\n') %
             join(self.root_dir, '.'))
 

tests/gclient_utils_test.py

@@ -36,7 +36,7 @@ class CheckCallAndFilterTestCase(GclientUtilBase):
   def _inner(self, args, test_string):
     cwd = 'bleh'
     gclient_utils.sys.stdout.write(
-        '\n________ running \'boo foo bar\' in \'bleh\'\n')
+        '________ running \'boo foo bar\' in \'bleh\'\n')
     for i in test_string:
       gclient_utils.sys.stdout.write(i)
     # pylint: disable=no-member
@@ -67,20 +67,11 @@ class CheckCallAndFilterTestCase(GclientUtilBase):
     args = ['boo', 'foo', 'bar']
     test_string = 'ahah\naccb\nallo\naddb\n'
     self._inner(args, test_string)
-    self.checkstdout('\n________ running \'boo foo bar\' in \'bleh\'\n'
-        'ahah\naccb\nallo\naddb\n\n'
+    self.checkstdout('________ running \'boo foo bar\' in \'bleh\'\n'
+        'ahah\naccb\nallo\naddb\n'
         '________ running \'boo foo bar\' in \'bleh\'\nahah\naccb\nallo\naddb'
         '\n')
 
-  def testNoLF(self):
-    # Exactly as testCheckCallAndFilterAndHeader without trailing \n
-    args = ['boo', 'foo', 'bar']
-    test_string = 'ahah\naccb\nallo\naddb'
-    self._inner(args, test_string)
-    self.checkstdout('\n________ running \'boo foo bar\' in \'bleh\'\n'
-        'ahah\naccb\nallo\naddb\n'
-        '________ running \'boo foo bar\' in \'bleh\'\nahah\naccb\nallo\naddb')
-
 
 class SplitUrlRevisionTestCase(GclientUtilBase):
   def testSSHUrl(self):