Commit 8daaf5c5 authored by Josip Sokcevic's avatar Josip Sokcevic Committed by LUCI CQ

Explicitly set python version for pylint 2.6

vpython doesn't parse shebang. If python version is not explicitly set
in vpython file, version 2 will be used. pylint 2.6 requires py3.

R=dpranke@google.com

Bug: 1242737
Change-Id: I21a3c4b26c24860b4c8fd07c6d5cc6d5149af2fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3120321
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: 's avatarDirk Pranke <dpranke@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
parent 9bccf29e
...@@ -973,7 +973,7 @@ def GetPylint(input_api, ...@@ -973,7 +973,7 @@ def GetPylint(input_api,
return [] return []
files.sort() files.sort()
input_api.logging.info('Running pylint on %d files', len(files)) input_api.logging.info('Running pylint %s on %d files', version, len(files))
input_api.logging.debug('Running pylint on: %s', files) input_api.logging.debug('Running pylint on: %s', files)
env = input_api.environ.copy() env = input_api.environ.copy()
env['PYTHONPATH'] = input_api.os_path.pathsep.join(extra_paths_list) env['PYTHONPATH'] = input_api.os_path.pathsep.join(extra_paths_list)
......
...@@ -9,6 +9,7 @@ ...@@ -9,6 +9,7 @@
# [VPYTHON:BEGIN] # [VPYTHON:BEGIN]
# # Third party dependencies. These are only listed because pylint itself needs # # Third party dependencies. These are only listed because pylint itself needs
# # them. Feel free to add/remove anything here. # # them. Feel free to add/remove anything here.
# python_version: "3"
# #
# wheel: < # wheel: <
# name: "infra/python/wheels/futures-py2_py3" # name: "infra/python/wheels/futures-py2_py3"
...@@ -32,7 +33,7 @@ ...@@ -32,7 +33,7 @@
# > # >
# wheel: < # wheel: <
# name: "infra/python/wheels/wrapt/${vpython_platform}" # name: "infra/python/wheels/wrapt/${vpython_platform}"
# version: "version:1.10.11" # version: "version:1.12.1"
# > # >
# wheel: < # wheel: <
# name: "infra/python/wheels/lazy-object-proxy/${vpython_platform}" # name: "infra/python/wheels/lazy-object-proxy/${vpython_platform}"
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment