Commit 8d195230 authored by maruel@chromium.org's avatar maruel@chromium.org

Add a note warning the users that presubmit hooks will be run.

Otherwise the scripts make it looks like they are hung when the presubmit checks
are slow.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3613007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@61506 0039d316-1c4b-4281-b951-d872f2087c98
parent 21dca0e7
...@@ -945,6 +945,7 @@ def DoPresubmitChecks(change, ...@@ -945,6 +945,7 @@ def DoPresubmitChecks(change,
Return: Return:
True if execution can continue, False if not. True if execution can continue, False if not.
""" """
print "Running presubmit hooks..."
start_time = time.time() start_time = time.time()
presubmit_files = ListRelevantPresubmitFiles(change.AbsoluteLocalPaths(True), presubmit_files = ListRelevantPresubmitFiles(change.AbsoluteLocalPaths(True),
change.RepositoryRoot()) change.RepositoryRoot())
......
...@@ -341,6 +341,7 @@ class PresubmitUnittest(PresubmitTestsBase): ...@@ -341,6 +341,7 @@ class PresubmitUnittest(PresubmitTestsBase):
self.failIf(presubmit.DoPresubmitChecks(change, False, True, output, input, self.failIf(presubmit.DoPresubmitChecks(change, False, True, output, input,
None, False)) None, False))
self.assertEqual(output.getvalue().count('!!'), 2) self.assertEqual(output.getvalue().count('!!'), 2)
self.checkstdout('Running presubmit hooks...\n')
def testDoPresubmitChecksPromptsAfterWarnings(self): def testDoPresubmitChecksPromptsAfterWarnings(self):
join = presubmit.os.path.join join = presubmit.os.path.join
...@@ -379,6 +380,7 @@ class PresubmitUnittest(PresubmitTestsBase): ...@@ -379,6 +380,7 @@ class PresubmitUnittest(PresubmitTestsBase):
self.failUnless(presubmit.DoPresubmitChecks(change, False, True, output, self.failUnless(presubmit.DoPresubmitChecks(change, False, True, output,
input, None, True)) input, None, True))
self.assertEquals(output.getvalue().count('??'), 2) self.assertEquals(output.getvalue().count('??'), 2)
self.checkstdout('Running presubmit hooks...\nRunning presubmit hooks...\n')
def testDoPresubmitChecksNoWarningPromptIfErrors(self): def testDoPresubmitChecksNoWarningPromptIfErrors(self):
join = presubmit.os.path.join join = presubmit.os.path.join
...@@ -413,6 +415,7 @@ class PresubmitUnittest(PresubmitTestsBase): ...@@ -413,6 +415,7 @@ class PresubmitUnittest(PresubmitTestsBase):
self.assertEqual(output.getvalue().count('??'), 2) self.assertEqual(output.getvalue().count('??'), 2)
self.assertEqual(output.getvalue().count('XX!!XX'), 2) self.assertEqual(output.getvalue().count('XX!!XX'), 2)
self.assertEqual(output.getvalue().count('(y/N)'), 0) self.assertEqual(output.getvalue().count('(y/N)'), 0)
self.checkstdout('Running presubmit hooks...\n')
def testDoDefaultPresubmitChecksAndFeedback(self): def testDoDefaultPresubmitChecksAndFeedback(self):
join = presubmit.os.path.join join = presubmit.os.path.join
...@@ -452,6 +455,7 @@ def CheckChangeOnCommit(input_api, output_api): ...@@ -452,6 +455,7 @@ def CheckChangeOnCommit(input_api, output_api):
'Was the presubmit check useful? Please send feedback & hate mail ' 'Was the presubmit check useful? Please send feedback & hate mail '
'to maruel@chromium.org!\n') 'to maruel@chromium.org!\n')
self.assertEquals(output.getvalue(), text) self.assertEquals(output.getvalue(), text)
self.checkstdout('Running presubmit hooks...\n')
def testDirectoryHandling(self): def testDirectoryHandling(self):
files = [ files = [
...@@ -523,6 +527,7 @@ def CheckChangeOnCommit(input_api, output_api): ...@@ -523,6 +527,7 @@ def CheckChangeOnCommit(input_api, output_api):
'Running default presubmit script.\n' 'Running default presubmit script.\n'
'** Presubmit Messages **\n' '** Presubmit Messages **\n'
'http://tracker.com/42\n\n')) 'http://tracker.com/42\n\n'))
self.checkstdout('Running presubmit hooks...\n')
def testGetTrySlavesExecuter(self): def testGetTrySlavesExecuter(self):
self.mox.ReplayAll() self.mox.ReplayAll()
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment