Commit 88d7869d authored by Edward Lemur's avatar Edward Lemur Committed by Commit Bot

Reland "depot_tools: Add httplib2 to .vpython"

This is a reland of e1410883

Use vpython to execute git_cl.py, gerrit_util.py and presubmit_support.py on recipes.

Original change's description:
> depot_tools: Add httplib2 to .vpython
>
> Check that things won't break before further changes are made.
>
> Bug: 1002153
> Change-Id: I41866f26334bf9ec2732bc0f25007234a95130e4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1854749
> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
> Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
> Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

Bug: 1002153
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: chromiumos
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: skia
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: release_scripts
Change-Id: Id94057eae8830dec197257df3ea35c0c4ff946b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1856650Reviewed-by: 's avatarAndrii Shyshkalov <tandrii@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
parent 2cbae8a8
python_version: "2.7" python_version: "2.7"
wheel: <
name: "infra/python/wheels/httplib2-py2_py3"
version: "version:0.10.3"
>
...@@ -9,6 +9,7 @@ from __future__ import print_function ...@@ -9,6 +9,7 @@ from __future__ import print_function
import collections import collections
import datetime import datetime
import functools import functools
import httplib2
import json import json
import logging import logging
import optparse import optparse
...@@ -20,7 +21,6 @@ import urlparse ...@@ -20,7 +21,6 @@ import urlparse
import subprocess2 import subprocess2
from third_party import httplib2
from third_party.oauth2client import client from third_party.oauth2client import client
......
...@@ -344,16 +344,16 @@ Module for interact with gerrit endpoints ...@@ -344,16 +344,16 @@ Module for interact with gerrit endpoints
Wrapper for easy calling of gerrit_utils steps. Wrapper for easy calling of gerrit_utils steps.
&mdash; **def [abandon\_change](/recipes/recipe_modules/gerrit/api.py#159)(self, host, change, message=None, name=None, step_test_data=None):** &mdash; **def [abandon\_change](/recipes/recipe_modules/gerrit/api.py#160)(self, host, change, message=None, name=None, step_test_data=None):**
&mdash; **def [create\_gerrit\_branch](/recipes/recipe_modules/gerrit/api.py#31)(self, host, project, branch, commit, \*\*kwargs):** &mdash; **def [create\_gerrit\_branch](/recipes/recipe_modules/gerrit/api.py#32)(self, host, project, branch, commit, \*\*kwargs):**
Create a new branch from given project and commit Create a new branch from given project and commit
Returns: Returns:
the ref of the branch created the ref of the branch created
&mdash; **def [get\_change\_description](/recipes/recipe_modules/gerrit/api.py#72)(self, host, change, patchset):** &mdash; **def [get\_change\_description](/recipes/recipe_modules/gerrit/api.py#73)(self, host, change, patchset):**
Get the description for a given CL and patchset. Get the description for a given CL and patchset.
...@@ -365,7 +365,7 @@ Args: ...@@ -365,7 +365,7 @@ Args:
Returns: Returns:
The description corresponding to given CL and patchset. The description corresponding to given CL and patchset.
&mdash; **def [get\_changes](/recipes/recipe_modules/gerrit/api.py#117)(self, host, query_params, start=None, limit=None, o_params=None, step_test_data=None, \*\*kwargs):** &mdash; **def [get\_changes](/recipes/recipe_modules/gerrit/api.py#118)(self, host, query_params, start=None, limit=None, o_params=None, step_test_data=None, \*\*kwargs):**
Query changes for the given host. Query changes for the given host.
...@@ -383,14 +383,14 @@ Returns: ...@@ -383,14 +383,14 @@ Returns:
A list of change dicts as documented here: A list of change dicts as documented here:
https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#list-changes https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#list-changes
&mdash; **def [get\_gerrit\_branch](/recipes/recipe_modules/gerrit/api.py#53)(self, host, project, branch, \*\*kwargs):** &mdash; **def [get\_gerrit\_branch](/recipes/recipe_modules/gerrit/api.py#54)(self, host, project, branch, \*\*kwargs):**
Get a branch from given project and commit Get a branch from given project and commit
Returns: Returns:
the revision of the branch the revision of the branch
&mdash; **def [get\_revision\_info](/recipes/recipe_modules/gerrit/api.py#87)(self, host, change, patchset):** &mdash; **def [get\_revision\_info](/recipes/recipe_modules/gerrit/api.py#88)(self, host, change, patchset):**
Returns the info for a given patchset of a given change. Returns the info for a given patchset of a given change.
......
[ [
{ {
"cmd": [ "cmd": [
"python", "vpython",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gerrit_client.py", "RECIPE_REPO[depot_tools]/gerrit_client.py",
"changes", "changes",
......
[ [
{ {
"cmd": [ "cmd": [
"python", "vpython",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gerrit_client.py", "RECIPE_REPO[depot_tools]/gerrit_client.py",
"changes", "changes",
......
[ [
{ {
"cmd": [ "cmd": [
"python", "vpython",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gerrit_client.py", "RECIPE_REPO[depot_tools]/gerrit_client.py",
"changes", "changes",
......
[ [
{ {
"cmd": [ "cmd": [
"python", "vpython",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gerrit_client.py", "RECIPE_REPO[depot_tools]/gerrit_client.py",
"changes", "changes",
......
[ [
{ {
"cmd": [ "cmd": [
"python", "vpython",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gerrit_client.py", "RECIPE_REPO[depot_tools]/gerrit_client.py",
"changes", "changes",
......
[ [
{ {
"cmd": [ "cmd": [
"python", "vpython",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gerrit_client.py", "RECIPE_REPO[depot_tools]/gerrit_client.py",
"changes", "changes",
......
[ [
{ {
"cmd": [ "cmd": [
"python", "vpython",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gerrit_client.py", "RECIPE_REPO[depot_tools]/gerrit_client.py",
"changes", "changes",
......
[ [
{ {
"cmd": [ "cmd": [
"python", "vpython",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gerrit_client.py", "RECIPE_REPO[depot_tools]/gerrit_client.py",
"changes", "changes",
......
[ [
{ {
"cmd": [ "cmd": [
"python", "vpython",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gerrit_client.py", "RECIPE_REPO[depot_tools]/gerrit_client.py",
"changes", "changes",
......
[ [
{ {
"cmd": [ "cmd": [
"python", "vpython",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gerrit_client.py", "RECIPE_REPO[depot_tools]/gerrit_client.py",
"changes", "changes",
......
[ [
{ {
"cmd": [ "cmd": [
"python", "vpython",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gerrit_client.py", "RECIPE_REPO[depot_tools]/gerrit_client.py",
"changes", "changes",
......
[ [
{ {
"cmd": [ "cmd": [
"python", "vpython",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gerrit_client.py", "RECIPE_REPO[depot_tools]/gerrit_client.py",
"changes", "changes",
......
...@@ -26,6 +26,7 @@ class GerritApi(recipe_api.RecipeApi): ...@@ -26,6 +26,7 @@ class GerritApi(recipe_api.RecipeApi):
self.repo_resource('gerrit_client.py'), self.repo_resource('gerrit_client.py'),
cmd, cmd,
infra_step=infra_step, infra_step=infra_step,
venv=True,
**kwargs) **kwargs)
def create_gerrit_branch(self, host, project, branch, commit, **kwargs): def create_gerrit_branch(self, host, project, branch, commit, **kwargs):
......
[ [
{ {
"cmd": [ "cmd": [
"python", "vpython",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gerrit_client.py", "RECIPE_REPO[depot_tools]/gerrit_client.py",
"branch", "branch",
...@@ -32,7 +32,7 @@ ...@@ -32,7 +32,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python", "vpython",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gerrit_client.py", "RECIPE_REPO[depot_tools]/gerrit_client.py",
"branchinfo", "branchinfo",
...@@ -60,7 +60,7 @@ ...@@ -60,7 +60,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python", "vpython",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gerrit_client.py", "RECIPE_REPO[depot_tools]/gerrit_client.py",
"changes", "changes",
...@@ -110,7 +110,7 @@ ...@@ -110,7 +110,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python", "vpython",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gerrit_client.py", "RECIPE_REPO[depot_tools]/gerrit_client.py",
"changes", "changes",
...@@ -137,7 +137,7 @@ ...@@ -137,7 +137,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python", "vpython",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gerrit_client.py", "RECIPE_REPO[depot_tools]/gerrit_client.py",
"changes", "changes",
...@@ -185,7 +185,7 @@ ...@@ -185,7 +185,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python", "vpython",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gerrit_client.py", "RECIPE_REPO[depot_tools]/gerrit_client.py",
"abandon", "abandon",
...@@ -229,7 +229,7 @@ ...@@ -229,7 +229,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python", "vpython",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gerrit_client.py", "RECIPE_REPO[depot_tools]/gerrit_client.py",
"changes", "changes",
......
...@@ -18,7 +18,7 @@ class GitClApi(recipe_api.RecipeApi): ...@@ -18,7 +18,7 @@ class GitClApi(recipe_api.RecipeApi):
with self.m.context(cwd=self.m.context.cwd or my_loc): with self.m.context(cwd=self.m.context.cwd or my_loc):
return self.m.python( return self.m.python(
name, self.repo_resource('git_cl.py'), [subcmd] + args, name, self.repo_resource('git_cl.py'), [subcmd] + args,
**kwargs) venv=True, **kwargs)
def get_description(self, patch_url=None, codereview=None, **kwargs): def get_description(self, patch_url=None, codereview=None, **kwargs):
"""DEPRECATED. Consider using gerrit.get_change_description instead.""" """DEPRECATED. Consider using gerrit.get_change_description instead."""
......
[ [
{ {
"cmd": [ "cmd": [
"python", "vpython",
"-u", "-u",
"RECIPE_REPO[depot_tools]/git_cl.py", "RECIPE_REPO[depot_tools]/git_cl.py",
"upload", "upload",
...@@ -12,7 +12,7 @@ ...@@ -12,7 +12,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python", "vpython",
"-u", "-u",
"RECIPE_REPO[depot_tools]/git_cl.py", "RECIPE_REPO[depot_tools]/git_cl.py",
"issue" "issue"
...@@ -21,7 +21,7 @@ ...@@ -21,7 +21,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python", "vpython",
"-u", "-u",
"RECIPE_REPO[depot_tools]/git_cl.py", "RECIPE_REPO[depot_tools]/git_cl.py",
"description", "description",
...@@ -33,7 +33,7 @@ ...@@ -33,7 +33,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python", "vpython",
"-u", "-u",
"RECIPE_REPO[depot_tools]/git_cl.py", "RECIPE_REPO[depot_tools]/git_cl.py",
"description", "description",
...@@ -54,7 +54,7 @@ ...@@ -54,7 +54,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python", "vpython",
"-u", "-u",
"RECIPE_REPO[depot_tools]/git_cl.py", "RECIPE_REPO[depot_tools]/git_cl.py",
"description", "description",
...@@ -72,7 +72,7 @@ ...@@ -72,7 +72,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python", "vpython",
"-u", "-u",
"RECIPE_REPO[depot_tools]/git_cl.py", "RECIPE_REPO[depot_tools]/git_cl.py",
"description", "description",
...@@ -85,7 +85,7 @@ ...@@ -85,7 +85,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python", "vpython",
"-u", "-u",
"RECIPE_REPO[depot_tools]/git_cl.py", "RECIPE_REPO[depot_tools]/git_cl.py",
"description", "description",
......
...@@ -106,7 +106,7 @@ class PresubmitApi(recipe_api.RecipeApi): ...@@ -106,7 +106,7 @@ class PresubmitApi(recipe_api.RecipeApi):
'--upstream', upstream, # '' if not in bot_update mode. '--upstream', upstream, # '' if not in bot_update mode.
]) ])
venv = None venv = True
# TODO(iannucci): verify that presubmit_support.py correctly finds and # TODO(iannucci): verify that presubmit_support.py correctly finds and
# uses .vpython files, then remove this configuration. # uses .vpython files, then remove this configuration.
if self._vpython_spec_path: if self._vpython_spec_path:
......
[ [
{ {
"cmd": [ "cmd": [
"python", "vpython",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gerrit_client.py", "RECIPE_REPO[depot_tools]/gerrit_client.py",
"changes", "changes",
...@@ -41,7 +41,7 @@ ...@@ -41,7 +41,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python", "vpython",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gerrit_client.py", "RECIPE_REPO[depot_tools]/gerrit_client.py",
"changes", "changes",
......
[ [
{ {
"cmd": [ "cmd": [
"python", "vpython",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gerrit_client.py", "RECIPE_REPO[depot_tools]/gerrit_client.py",
"changes", "changes",
...@@ -41,7 +41,7 @@ ...@@ -41,7 +41,7 @@
}, },
{ {
"cmd": [ "cmd": [
"python", "vpython",
"-u", "-u",
"RECIPE_REPO[depot_tools]/gerrit_client.py", "RECIPE_REPO[depot_tools]/gerrit_client.py",
"changes", "changes",
......
...@@ -7,6 +7,7 @@ ...@@ -7,6 +7,7 @@
import __builtin__ import __builtin__
import datetime import datetime
import httplib2
import json import json
import logging import logging
import os import os
...@@ -18,7 +19,6 @@ sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__)))) ...@@ -18,7 +19,6 @@ sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
from testing_support import auto_stub from testing_support import auto_stub
from third_party import httplib2
from third_party import mock from third_party import mock
import auth import auth
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment