Commit 8571dac9 authored by maruel@chromium.org's avatar maruel@chromium.org

In r84572, I forgot to move CheckChangeSvnEolStyle() to commit-only check.

This check is also handled by the commit bot so no need to harass people when
uploading.

R=dpranke@chromium.org
BUG=none
TEST=Nobody wrote a test for PanProjectChecks() and I didn't write this function, no way I won't.

Review URL: http://codereview.chromium.org/6998008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@84814 0039d316-1c4b-4281-b951-d872f2087c98
parent 2a471073
...@@ -936,9 +936,6 @@ def PanProjectChecks(input_api, output_api, ...@@ -936,9 +936,6 @@ def PanProjectChecks(input_api, output_api,
snapshot( "checking stray whitespace") snapshot( "checking stray whitespace")
results.extend(input_api.canned_checks.CheckChangeHasNoStrayWhitespace( results.extend(input_api.canned_checks.CheckChangeHasNoStrayWhitespace(
input_api, output_api, source_file_filter=sources)) input_api, output_api, source_file_filter=sources))
snapshot("checking eol style")
results.extend(input_api.canned_checks.CheckChangeSvnEolStyle(
input_api, output_api, source_file_filter=text_files))
snapshot("checking nsobjects") snapshot("checking nsobjects")
results.extend(_CheckConstNSObject( results.extend(_CheckConstNSObject(
input_api, output_api, source_file_filter=sources)) input_api, output_api, source_file_filter=sources))
...@@ -949,6 +946,9 @@ def PanProjectChecks(input_api, output_api, ...@@ -949,6 +946,9 @@ def PanProjectChecks(input_api, output_api,
# The following checks are only done on commit, since the commit bot will # The following checks are only done on commit, since the commit bot will
# auto-fix most of these. # auto-fix most of these.
if input_api.is_committing: if input_api.is_committing:
snapshot("checking eol style")
results.extend(input_api.canned_checks.CheckChangeSvnEolStyle(
input_api, output_api, source_file_filter=text_files))
snapshot("checking svn mime types") snapshot("checking svn mime types")
results.extend(input_api.canned_checks.CheckSvnForCommonMimeTypes( results.extend(input_api.canned_checks.CheckSvnForCommonMimeTypes(
input_api, output_api)) input_api, output_api))
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment