Commit 7044efcc authored by ukai@chromium.org's avatar ukai@chromium.org

GERRIT_PORT is no longer used in git_cl.py

BUG=maruel@chromium.org,szager@chromium.org

Review URL: https://codereview.chromium.org/90763004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@237657 0039d316-1c4b-4281-b951-d872f2087c98
parent 712d6105
...@@ -1019,9 +1019,8 @@ def LoadCodereviewSettingsFromFile(fileobj): ...@@ -1019,9 +1019,8 @@ def LoadCodereviewSettingsFromFile(fileobj):
SetProperty('tree-status-url', 'STATUS', unset_error_ok=True) SetProperty('tree-status-url', 'STATUS', unset_error_ok=True)
SetProperty('viewvc-url', 'VIEW_VC', unset_error_ok=True) SetProperty('viewvc-url', 'VIEW_VC', unset_error_ok=True)
if 'GERRIT_HOST' in keyvals and 'GERRIT_PORT' in keyvals: if 'GERRIT_HOST' in keyvals:
RunGit(['config', 'gerrit.host', keyvals['GERRIT_HOST']]) RunGit(['config', 'gerrit.host', keyvals['GERRIT_HOST']])
RunGit(['config', 'gerrit.port', keyvals['GERRIT_PORT']])
if 'PUSH_URL_CONFIG' in keyvals and 'ORIGIN_URL_CONFIG' in keyvals: if 'PUSH_URL_CONFIG' in keyvals and 'ORIGIN_URL_CONFIG' in keyvals:
#should be of the form #should be of the form
......
...@@ -662,7 +662,6 @@ class TestGitCl(TestCase): ...@@ -662,7 +662,6 @@ class TestGitCl(TestCase):
'rietveld.viewvc-url'],), ''), 'rietveld.viewvc-url'],), ''),
((['git', 'config', 'gerrit.host', ((['git', 'config', 'gerrit.host',
'gerrit.chromium.org'],), ''), 'gerrit.chromium.org'],), ''),
((['git', 'config', 'gerrit.port', '29418'],), ''),
# DownloadHooks(False) # DownloadHooks(False)
((['git', 'config', 'gerrit.host'],), ((['git', 'config', 'gerrit.host'],),
'gerrit.chromium.org'), 'gerrit.chromium.org'),
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment