Commit 6e7ddb69 authored by Aaron Gable's avatar Aaron Gable Committed by LUCI CQ

Remove agable from depot_tools OWNERS and TODOs

Change-Id: I0667af4562208a111ab3673f3fca6aab655f5f26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2218962
Auto-Submit: Aaron Gable <agable@chromium.org>
Reviewed-by: 's avatarAnthony Polito <apolito@google.com>
Commit-Queue: Anthony Polito <apolito@google.com>
parent cdaf0be1
set noparent set noparent
agable@chromium.org
apolito@google.com apolito@google.com
dpranke@chromium.org dpranke@chromium.org
ehmaldonado@chromium.org ehmaldonado@chromium.org
......
...@@ -2698,11 +2698,6 @@ def CMDsync(parser, args): ...@@ -2698,11 +2698,6 @@ def CMDsync(parser, args):
parser.add_option('--lock_timeout', type='int', default=5000, parser.add_option('--lock_timeout', type='int', default=5000,
help='GIT ONLY - Deadline (in seconds) to wait for git ' help='GIT ONLY - Deadline (in seconds) to wait for git '
'cache lock to become available. Default is %default.') 'cache lock to become available. Default is %default.')
# TODO(agable): Remove these when the oldest CrOS release milestone is M56.
parser.add_option('-t', '--transitive', action='store_true',
help='DEPRECATED: This is a no-op.')
parser.add_option('-m', '--manually_grab_svn_rev', action='store_true',
help='DEPRECATED: This is a no-op.')
parser.add_option('--no-rebase-patch-ref', action='store_false', parser.add_option('--no-rebase-patch-ref', action='store_false',
dest='rebase_patch_ref', default=True, dest='rebase_patch_ref', default=True,
help='Bypass rebase of the patch ref after checkout.') help='Bypass rebase of the patch ref after checkout.')
......
...@@ -425,7 +425,6 @@ class Annotated(Wrapper): ...@@ -425,7 +425,6 @@ class Annotated(Wrapper):
# Continue lockless. # Continue lockless.
obj[0] += out obj[0] += out
while True: while True:
# TODO(agable): find both of these with a single pass.
cr_loc = obj[0].find(b'\r') cr_loc = obj[0].find(b'\r')
lf_loc = obj[0].find(b'\n') lf_loc = obj[0].find(b'\n')
if cr_loc == lf_loc == -1: if cr_loc == lf_loc == -1:
......
...@@ -2300,7 +2300,7 @@ class Changelist(object): ...@@ -2300,7 +2300,7 @@ class Changelist(object):
if self.GetIssue() and (reviewers or cc): if self.GetIssue() and (reviewers or cc):
# GetIssue() is not set in case of non-squash uploads according to tests. # GetIssue() is not set in case of non-squash uploads according to tests.
# TODO(agable): non-squash uploads in git cl should be removed. # TODO(crbug.com/751901): non-squash uploads in git cl should be removed.
gerrit_util.AddReviewers( gerrit_util.AddReviewers(
self._GetGerritHost(), self._GetGerritHost(),
self._GerritChangeIdentifier(), self._GerritChangeIdentifier(),
......
...@@ -1612,7 +1612,6 @@ def CheckLucicfgGenOutput(input_api, output_api, entry_script): ...@@ -1612,7 +1612,6 @@ def CheckLucicfgGenOutput(input_api, output_api, entry_script):
output_api.PresubmitError) output_api.PresubmitError)
] ]
# TODO(agable): Add this to PanProjectChecks.
def CheckJsonParses(input_api, output_api): def CheckJsonParses(input_api, output_api):
"""Verifies that all JSON files at least parse as valid JSON.""" """Verifies that all JSON files at least parse as valid JSON."""
import json import json
......
...@@ -1119,12 +1119,12 @@ class Change(object): ...@@ -1119,12 +1119,12 @@ class Change(object):
def TBRsFromDescription(self): def TBRsFromDescription(self):
"""Returns all TBR reviewers listed in the commit description.""" """Returns all TBR reviewers listed in the commit description."""
tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()] tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()]
# TODO(agable): Remove support for 'Tbr:' when TBRs are programmatically # TODO(crbug.com/839208): Remove support for 'Tbr:' when TBRs are
# determined by self-CR+1s. # programmatically determined by self-CR+1s.
footers = self.GitFootersFromDescription().get('Tbr', []) footers = self.GitFootersFromDescription().get('Tbr', [])
return sorted(set(tags + footers)) return sorted(set(tags + footers))
# TODO(agable): Delete these once we're sure they're unused. # TODO(crbug.com/753425): Delete these once we're sure they're unused.
@property @property
def BUG(self): def BUG(self):
return ','.join(self.BugsFromDescription()) return ','.join(self.BugsFromDescription())
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment