Commit 4901daf1 authored by maruel@chromium.org's avatar maruel@chromium.org

Workaround a limitation in cygwin with Lock creation.

Reuse a common lock to reduce the number of locks created. Poor cygwin users.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8353010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@106494 0039d316-1c4b-4281-b951-d872f2087c98
parent 41071614
......@@ -480,17 +480,14 @@ def lockedmethod(method):
class WorkItem(object):
"""One work item."""
# On cygwin, creating a lock throwing randomly when nearing ~100 locks.
# As a workaround, use a single lock. Yep you read it right. Single lock for
# all the 100 objects.
lock = threading.Lock()
def __init__(self, name):
# A unique string representing this work item.
self._name = name
try:
self.lock = threading.Lock()
except: # pylint: disable=W0702
if sys.platform != 'cygwin':
raise
# On cygwin, it's throwing randomly. Hack and reuse the single
# sys.stdout.lock. Yep you read it right. Single lock.
self.lock = sys.stdout.lock
def run(self, work_queue):
"""work_queue is passed as keyword argument so it should be
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment