Commit 2f8e0fa4 authored by Gavin Mak's avatar Gavin Mak Committed by LUCI CQ

Fix testRebase

Running git rebase --continue may launch a text editor for editing commit messages. This causes testRebase to hang or to fail completely when running locally.
Setting GIT_EDITOR to ':' suppresses this.

Bug:1149625
Change-Id: Ia4a0b6564b198be945866cb890607ac8966c468f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2551375
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: 's avatarEdward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: 's avatarJosip Sokcevic <sokcevic@google.com>
parent cc2fe9b7
......@@ -36,6 +36,7 @@ class GitCommonTestBase(unittest.TestCase):
import git_common
cls.gc = git_common
cls.gc.TEST_MODE = True
os.environ["GIT_EDITOR"] = ":" # Supress git editor during rebase.
class Support(GitCommonTestBase):
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment