Commit 252ff1fe authored by Josip Sokcevic's avatar Josip Sokcevic Committed by LUCI CQ

Remove rev-parse --verify FETCH_HEAD

It's not used and causes some problems if refs on clone aren't set
properly.

R=ehmaldonado@chromium.org

Bug: 1049610
Change-Id: I71c1215c9a3355dd54e2d66860d755c6fe8032db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2224853Reviewed-by: 's avatarEdward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
parent 5c91cb1c
...@@ -1327,9 +1327,6 @@ class GitWrapper(SCMWrapper): ...@@ -1327,9 +1327,6 @@ class GitWrapper(SCMWrapper):
fetch_cmd.append('--quiet') fetch_cmd.append('--quiet')
self._Run(fetch_cmd, options, show_header=options.verbose, retry=True) self._Run(fetch_cmd, options, show_header=options.verbose, retry=True)
# Return the revision that was fetched; this will be stored in 'FETCH_HEAD'
return self._Capture(['rev-parse', '--verify', 'FETCH_HEAD'])
def _SetFetchConfig(self, options): def _SetFetchConfig(self, options):
"""Adds, and optionally fetches, "branch-heads" and "tags" refspecs """Adds, and optionally fetches, "branch-heads" and "tags" refspecs
if requested.""" if requested."""
......
...@@ -200,6 +200,8 @@ def call(args, **kwargs): ...@@ -200,6 +200,8 @@ def call(args, **kwargs):
Automatically convert stdout=PIPE or stderr=PIPE to VOID. Automatically convert stdout=PIPE or stderr=PIPE to VOID.
In no case they can be returned since no code path raises In no case they can be returned since no code path raises
subprocess2.CalledProcessError. subprocess2.CalledProcessError.
Returns exit code.
""" """
if kwargs.get('stdout') == PIPE: if kwargs.get('stdout') == PIPE:
kwargs['stdout'] = VOID kwargs['stdout'] = VOID
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment