Commit 16b51409 authored by iannucci@chromium.org's avatar iannucci@chromium.org

Fix parameters for git_cl and gcl.


TBR=maruel@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/12300005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@183022 0039d316-1c4b-4281-b951-d872f2087c98
parent 25a4ab43
......@@ -1045,7 +1045,8 @@ def CMDcommit(change_info, args):
elif revision:
change_info.description += "\nCommitted: " + revision
change_info.CloseIssue()
props = change_info.RpcServer().get_issue_properties(change_info.issue)
props = change_info.RpcServer().get_issue_properties(
change_info.issue, False)
patch_num = len(props['patchsets'])
comment = "Committed patchset #%d manually as r%s" % (patch_num, revision)
comment += ' (presubmit successful).' if not bypassed else '.'
......
......@@ -1495,7 +1495,7 @@ def SendUpstream(parser, args, cmd):
print ('Closing issue '
'(you may be prompted for your codereview password)...')
cl.CloseIssue()
props = cl.RpcServer().get_issue_properties(cl.GetIssue())
props = cl.RpcServer().get_issue_properties(cl.GetIssue(), False)
patch_num = len(props['patchset'])
comment = "Committed patchset #%d manually as r%s" % (patch_num, revision)
comment += ' (presubmit successful).' if not options.bypass_hooks else '.'
......
......@@ -59,7 +59,8 @@ class GclTestsBase(SuperMoxTestBase):
change_info._comments_added = []
class RpcServer(object):
def get_issue_properties(self, *_): # pylint: disable=R0201
# pylint: disable=R0201,W0613
def get_issue_properties(self, issue, messages):
return { 'patchsets': [1337] }
change_info.RpcServer = RpcServer
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment