Bot_update: kill git if it's too slow

BUG=635641 Change-Id: Ibfeda2ab32d10a8a4e229a428a846ce9809e8dcd Reviewed-on: https://chromium-review.googlesource.com/444094Reviewed-by: Daniel Jacques <dnj@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org>

Bot_update: kill git if it's too slow
BUG=635641 Change-Id: Ibfeda2ab32d10a8a4e229a428a846ce9809e8dcd Reviewed-on: https://chromium-review.googlesource.com/444094Reviewed-by: Daniel Jacques <dnj@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org>
0d21d19e · Ryan Tseng · Commit Bot · d8ee616e · 0d21d19e · 0d21d19e
Commit 0d21d19e authored Feb 16, 2017 by Ryan Tseng Committed by Commit Bot Feb 16, 2017
22 changed files
--- a/recipe_modules/bot_update/api.py
+++ b/recipe_modules/bot_update/api.py
@@ -37,6 +37,11 @@ class BotUpdateApi(recipe_api.RecipeApi):
    kwargs['env'].setdefault('PATH', '%(PATH)s')
    kwargs['env']['PATH'] = self.m.path.pathsep.join([
        kwargs['env']['PATH'], str(self._module.PACKAGE_REPO_ROOT)])
+    # These are to prevent git from hanging.  If the git connection is slower
+    # than 1KB/s for more than 5 minutes then git will kill the connection
+    # and die with an error "error: RPC failed; curl 28 Operation too slow"
+    kwargs['env']['GIT_HTTP_LOW_SPEED_LIMIT '] = 1000
+    kwargs['env']['GIT_HTTP_LOW_SPEED_TIME'] = 300
    return self.m.python(name, bot_update_path, cmd, **kwargs)

  @property

--- a/recipe_modules/bot_update/example.expected/basic.json
+++ b/recipe_modules/bot_update/example.expected/basic.json
@@ -18,6 +18,8 @@
      "src@abc"
    ],
    "env": {
+      "GIT_HTTP_LOW_SPEED_LIMIT ": "1000",
+      "GIT_HTTP_LOW_SPEED_TIME": "300",
      "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
    },
    "name": "bot_update (without patch)",

--- a/recipe_modules/bot_update/example.expected/basic_output_manifest.json
+++ b/recipe_modules/bot_update/example.expected/basic_output_manifest.json
@@ -19,6 +19,8 @@
      "--output_manifest"
    ],
    "env": {
+      "GIT_HTTP_LOW_SPEED_LIMIT ": "1000",
+      "GIT_HTTP_LOW_SPEED_TIME": "300",
      "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
    },
    "name": "bot_update",

--- a/recipe_modules/bot_update/example.expected/basic_with_branch_heads.json
+++ b/recipe_modules/bot_update/example.expected/basic_with_branch_heads.json
@@ -19,6 +19,8 @@
      "--with_branch_heads"
    ],
    "env": {
+      "GIT_HTTP_LOW_SPEED_LIMIT ": "1000",
+      "GIT_HTTP_LOW_SPEED_TIME": "300",
      "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
    },
    "name": "bot_update - with branch heads",

--- a/recipe_modules/bot_update/example.expected/buildbot.json
+++ b/recipe_modules/bot_update/example.expected/buildbot.json
@@ -18,6 +18,8 @@
      "src@abc"
    ],
    "env": {
+      "GIT_HTTP_LOW_SPEED_LIMIT ": "1000",
+      "GIT_HTTP_LOW_SPEED_TIME": "300",
      "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
    },
    "name": "bot_update (without patch)",

--- a/recipe_modules/bot_update/example.expected/clobber.json
+++ b/recipe_modules/bot_update/example.expected/clobber.json
@@ -19,6 +19,8 @@
      "--clobber"
    ],
    "env": {
+      "GIT_HTTP_LOW_SPEED_LIMIT ": "1000",
+      "GIT_HTTP_LOW_SPEED_TIME": "300",
      "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
    },
    "name": "bot_update",

--- a/recipe_modules/bot_update/example.expected/gerrit_no_rebase_patch_ref.json
+++ b/recipe_modules/bot_update/example.expected/gerrit_no_rebase_patch_ref.json
@@ -19,6 +19,8 @@
      "--gerrit_no_rebase_patch_ref"
    ],
    "env": {
+      "GIT_HTTP_LOW_SPEED_LIMIT ": "1000",
+      "GIT_HTTP_LOW_SPEED_TIME": "300",
      "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
    },
    "name": "bot_update",

--- a/recipe_modules/bot_update/example.expected/gerrit_no_reset.json
+++ b/recipe_modules/bot_update/example.expected/gerrit_no_reset.json
@@ -19,6 +19,8 @@
      "--gerrit_no_reset"
    ],
    "env": {
+      "GIT_HTTP_LOW_SPEED_LIMIT ": "1000",
+      "GIT_HTTP_LOW_SPEED_TIME": "300",
      "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
    },
    "name": "bot_update",

--- a/recipe_modules/bot_update/example.expected/no_shallow.json
+++ b/recipe_modules/bot_update/example.expected/no_shallow.json
@@ -19,6 +19,8 @@
      "--no_shallow"
    ],
    "env": {
+      "GIT_HTTP_LOW_SPEED_LIMIT ": "1000",
+      "GIT_HTTP_LOW_SPEED_TIME": "300",
      "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
    },
    "name": "bot_update",

--- a/recipe_modules/bot_update/example.expected/reset_root_solution_revision.json
+++ b/recipe_modules/bot_update/example.expected/reset_root_solution_revision.json
@@ -18,6 +18,8 @@
      "src@revision"
    ],
    "env": {
+      "GIT_HTTP_LOW_SPEED_LIMIT ": "1000",
+      "GIT_HTTP_LOW_SPEED_TIME": "300",
      "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
    },
    "name": "bot_update",

--- a/recipe_modules/bot_update/example.expected/trychange.json
+++ b/recipe_modules/bot_update/example.expected/trychange.json
@@ -20,6 +20,8 @@
      "+refs/change/1/2/333"
    ],
    "env": {
+      "GIT_HTTP_LOW_SPEED_LIMIT ": "1000",
+      "GIT_HTTP_LOW_SPEED_TIME": "300",
      "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
    },
    "name": "bot_update",

--- a/recipe_modules/bot_update/example.expected/trychange_oauth2_buildbot.json
+++ b/recipe_modules/bot_update/example.expected/trychange_oauth2_buildbot.json
@@ -22,6 +22,8 @@
      "src@HEAD"
    ],
    "env": {
+      "GIT_HTTP_LOW_SPEED_LIMIT ": "1000",
+      "GIT_HTTP_LOW_SPEED_TIME": "300",
      "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
    },
    "name": "bot_update",

--- a/recipe_modules/bot_update/example.expected/trychange_oauth2_json.json
+++ b/recipe_modules/bot_update/example.expected/trychange_oauth2_json.json
@@ -20,6 +20,8 @@
      "src@HEAD"
    ],
    "env": {
+      "GIT_HTTP_LOW_SPEED_LIMIT ": "1000",
+      "GIT_HTTP_LOW_SPEED_TIME": "300",
      "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
    },
    "name": "bot_update",

--- a/recipe_modules/bot_update/example.expected/trychange_oauth2_json_win.json
+++ b/recipe_modules/bot_update/example.expected/trychange_oauth2_json_win.json
@@ -20,6 +20,8 @@
      "src@HEAD"
    ],
    "env": {
+      "GIT_HTTP_LOW_SPEED_LIMIT ": "1000",
+      "GIT_HTTP_LOW_SPEED_TIME": "300",
      "PATH": "%(PATH)s;RECIPE_PACKAGE_REPO[depot_tools]"
    },
    "name": "bot_update",

--- a/recipe_modules/bot_update/example.expected/tryjob.json
+++ b/recipe_modules/bot_update/example.expected/tryjob.json
@@ -24,6 +24,8 @@
      "src@HEAD"
    ],
    "env": {
+      "GIT_HTTP_LOW_SPEED_LIMIT ": "1000",
+      "GIT_HTTP_LOW_SPEED_TIME": "300",
      "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
    },
    "name": "bot_update",

--- a/recipe_modules/bot_update/example.expected/tryjob_fail.json
+++ b/recipe_modules/bot_update/example.expected/tryjob_fail.json
@@ -24,6 +24,8 @@
      "src@HEAD"
    ],
    "env": {
+      "GIT_HTTP_LOW_SPEED_LIMIT ": "1000",
+      "GIT_HTTP_LOW_SPEED_TIME": "300",
      "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
    },
    "name": "bot_update",

--- a/recipe_modules/bot_update/example.expected/tryjob_fail_patch.json
+++ b/recipe_modules/bot_update/example.expected/tryjob_fail_patch.json
@@ -24,6 +24,8 @@
      "src@HEAD"
    ],
    "env": {
+      "GIT_HTTP_LOW_SPEED_LIMIT ": "1000",
+      "GIT_HTTP_LOW_SPEED_TIME": "300",
      "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
    },
    "name": "bot_update",

--- a/recipe_modules/bot_update/example.expected/tryjob_fail_patch_download.json
+++ b/recipe_modules/bot_update/example.expected/tryjob_fail_patch_download.json
@@ -24,6 +24,8 @@
      "src@HEAD"
    ],
    "env": {
+      "GIT_HTTP_LOW_SPEED_LIMIT ": "1000",
+      "GIT_HTTP_LOW_SPEED_TIME": "300",
      "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
    },
    "name": "bot_update",

--- a/recipe_modules/bot_update/example.expected/tryjob_gerrit_angle.json
+++ b/recipe_modules/bot_update/example.expected/tryjob_gerrit_angle.json
@@ -24,6 +24,8 @@
      "src/third_party/angle@HEAD"
    ],
    "env": {
+      "GIT_HTTP_LOW_SPEED_LIMIT ": "1000",
+      "GIT_HTTP_LOW_SPEED_TIME": "300",
      "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
    },
    "name": "bot_update",

--- a/recipe_modules/bot_update/example.expected/tryjob_gerrit_angle_deprecated.json
+++ b/recipe_modules/bot_update/example.expected/tryjob_gerrit_angle_deprecated.json
@@ -24,6 +24,8 @@
      "src/third_party/angle@HEAD"
    ],
    "env": {
+      "GIT_HTTP_LOW_SPEED_LIMIT ": "1000",
+      "GIT_HTTP_LOW_SPEED_TIME": "300",
      "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
    },
    "name": "bot_update",

--- a/recipe_modules/bot_update/example.expected/tryjob_v8.json
+++ b/recipe_modules/bot_update/example.expected/tryjob_v8.json
@@ -26,6 +26,8 @@
      "src/v8@abc"
    ],
    "env": {
+      "GIT_HTTP_LOW_SPEED_LIMIT ": "1000",
+      "GIT_HTTP_LOW_SPEED_TIME": "300",
      "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
    },
    "name": "bot_update",

--- a/recipe_modules/bot_update/example.expected/tryjob_v8_head_by_default.json
+++ b/recipe_modules/bot_update/example.expected/tryjob_v8_head_by_default.json
@@ -26,6 +26,8 @@
      "src/v8@HEAD"
    ],
    "env": {
+      "GIT_HTTP_LOW_SPEED_LIMIT ": "1000",
+      "GIT_HTTP_LOW_SPEED_TIME": "300",
      "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
    },
    "name": "bot_update",