Commit 091b7db6 authored by dcheng's avatar dcheng Committed by Commit bot

Expose fnmatch in presubmit's input_api.

BUG=611905

Review-Url: https://codereview.chromium.org/2070493002
parent adf9f0db
......@@ -16,7 +16,7 @@ import cpplint
import cPickle # Exposed through the API.
import cStringIO # Exposed through the API.
import contextlib
import fnmatch
import fnmatch # Exposed through the API.
import glob
import inspect
import itertools
......@@ -348,6 +348,7 @@ class InputApi(object):
self.cPickle = cPickle
self.cpplint = cpplint
self.cStringIO = cStringIO
self.fnmatch = fnmatch
self.glob = glob.glob
self.json = json
self.logging = logging.getLogger('PRESUBMIT')
......
......@@ -1190,17 +1190,58 @@ class InputApiUnittest(PresubmitTestsBase):
def testMembersChanged(self):
self.mox.ReplayAll()
members = [
'AbsoluteLocalPaths', 'AffectedFiles', 'AffectedSourceFiles',
'AffectedTextFiles', 'DEFAULT_BLACK_LIST', 'DEFAULT_WHITE_LIST',
'DepotToLocalPath', 'FilterSourceFile', 'LocalPaths', 'LocalToDepotPath',
'Command', 'RunTests', 'PresubmitLocalPath', 'ReadFile',
'RightHandSideLines', 'ServerPaths', 'basename', 'cPickle', 'cpplint',
'cStringIO', 'canned_checks', 'change', 'cpu_count', 'environ', 'glob',
'host_url', 'is_committing', 'json', 'logging', 'marshal', 'os_listdir',
'os_walk', 'os_path', 'os_stat', 'owners_db', 'pickle', 'platform',
'python_executable', 're', 'rietveld', 'subprocess', 'tbr', 'tempfile',
'time', 'traceback', 'unittest', 'urllib2', 'version', 'verbose',
'dry_run', 'gerrit',
'AbsoluteLocalPaths',
'AffectedFiles',
'AffectedSourceFiles',
'AffectedTextFiles',
'DEFAULT_BLACK_LIST',
'DEFAULT_WHITE_LIST',
'DepotToLocalPath',
'FilterSourceFile',
'LocalPaths',
'LocalToDepotPath',
'Command',
'RunTests',
'PresubmitLocalPath',
'ReadFile',
'RightHandSideLines',
'ServerPaths',
'basename',
'cPickle',
'cpplint',
'cStringIO',
'canned_checks',
'change',
'cpu_count',
'environ',
'fnmatch',
'glob',
'host_url',
'is_committing',
'json',
'logging',
'marshal',
'os_listdir',
'os_walk',
'os_path',
'os_stat',
'owners_db',
'pickle',
'platform',
'python_executable',
're',
'rietveld',
'subprocess',
'tbr',
'tempfile',
'time',
'traceback',
'unittest',
'urllib2',
'version',
'verbose',
'dry_run',
'gerrit',
]
# If this test fails, you should add the relevant test.
self.compareMembers(
......@@ -2735,7 +2776,7 @@ class CannedChecksUnittest(PresubmitTestsBase):
"sender": "ben@example.com", "text": "foo", "approval": False,
},
],
"reviewers":[],
"reviewers": [],
}
self.AssertOwnersWorks(
approvers=set(),
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment